From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "T.V. Raman" Newsgroups: gmane.emacs.devel Subject: fix interactive spec for kill-region Date: Fri, 7 Sep 2012 09:00:53 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1347033671 15791 80.91.229.3 (7 Sep 2012 16:01:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Sep 2012 16:01:11 +0000 (UTC) To: Stefan Monnier , Andreas Schwab , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 07 18:01:13 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TA0zY-0002D1-Dd for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2012 18:01:12 +0200 Original-Received: from localhost ([::1]:57421 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TA0zV-000672-C7 for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2012 12:01:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TA0zO-00066Z-FA for emacs-devel@gnu.org; Fri, 07 Sep 2012 12:01:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TA0zH-0003GW-1u for emacs-devel@gnu.org; Fri, 07 Sep 2012 12:01:02 -0400 Original-Received: from mail-ie0-f169.google.com ([209.85.223.169]:40010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TA0zG-0003GO-TV for emacs-devel@gnu.org; Fri, 07 Sep 2012 12:00:54 -0400 Original-Received: by iec9 with SMTP id 9so6064559iec.0 for ; Fri, 07 Sep 2012 09:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=WGCckmrWEBLlKdzs9/dQPXjJGI5Wsp0SYOEdIJhs2nU=; b=JKxXakfMNXISHgqeFLelXLWcbnWFZxWLhGnlPAjg0KVAiTfnZAniTNVZoa40+j4At8 r8hYxsskjlKR5cLzlQ2vkbFxa5gK55yFYpxe1Vbvhh0mxaSP2v1xioBnXLfuZ8ROMGv8 i3scLQjxBBMR10GHjkdVvAhQX1fWcZxp4mlkGS2iLlT981J1n8jsvemICy6m+Kd1EagD EiQC4bcNT87Mqh3JFQCvduxgtU7YsMp8gjsf4qdVEDYCRG7xCY89kOwDhfPtOQEARyXF l/cmhn1n+pkLmUGJ2418ovqd4Fh2bos/tiIB2JmI5Etc636bOxProOIJ9c+35N+xCKgL eeRQ== Original-Received: by 10.50.178.38 with SMTP id cv6mr7298106igc.1.1347033653670; Fri, 07 Sep 2012 09:00:53 -0700 (PDT) Original-Received: by 10.42.158.72 with HTTP; Fri, 7 Sep 2012 09:00:53 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.223.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153158 Archived-At: Here is the byte-compiler warning: emacs -batch -q -no-site-file -eval '(setq vc-handled-backends nil byte-compile-warnings t)' -l ".."/lisp/emacspeak-load-path.el -l ".."/lisp/emacspeak-loaddefs.el -l ".."/lisp/emacspeak-cus-load.el -l ".."/lisp/g-client/g-load-path.el -f batch-byte-compile emacspeak-advice.el Warning: Unknown defun property special in emacspeak-should-i-fix-interactive-p In toplevel form: emacspeak-advice.el:1607:52:Warning: ad-Orig-kill-region called with 3 arguments, but accepts only 2 Line 1607 is the last line of this advice form: (defadvice kill-region (around emacspeak pre act) "Indicate region has been killed. Use an auditory icon if possible." (cond ((ems-interactive-p ) (let ((count (count-lines (region-beginning) (region-end)))) ad-do-it (emacspeak-auditory-icon 'delete-object ) (message "Killed region containing %s lines" count))) (t ad-do-it)) ad-return-value) I'll attach just the advice form that triggers the error: -- -- On 9/3/12, Stefan Monnier wrote: >> The signature doesn't match, and you get byte compiler warnings. > > Please report the actual byte-compilation warnings instead, then. > I have a strong feeling you're confused about the source of the problem > (which probably comes from the fact that the 3 optional argument was > made obsolete and is hidden by an advertised signature). > > > Stefan >