From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Laws Newsgroups: gmane.emacs.bugs Subject: bug#19688: [patch] add support for emacs daemon on Windows Date: Sun, 15 Feb 2015 02:57:13 +0900 Message-ID: References: <83h9ver459.fsf@gnu.org> <83d262qdx6.fsf@gnu.org> <54C62B6C.3050608@dancol.org> <834mr8n5or.fsf@gnu.org> <83pp9e42n8.fsf@gnu.org> <8361b4y9qj.fsf@gnu.org> <83wq3kwrjx.fsf@gnu.org> <83r3tswm6d.fsf@gnu.org> <83iof4wi2c.fsf@gnu.org> <83egpswgnm.fsf@gnu.org> <83bnkwwfsz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1423936712 30300 80.91.229.3 (14 Feb 2015 17:58:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Feb 2015 17:58:32 +0000 (UTC) Cc: 19688@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 14 18:58:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YMgyr-0001Qw-O1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Feb 2015 18:58:13 +0100 Original-Received: from localhost ([::1]:60760 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMgyq-0005I7-VM for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Feb 2015 12:58:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMgym-0005HY-Ez for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 12:58:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMgyh-0001hK-5V for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 12:58:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMgyh-0001hG-2h for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 12:58:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YMgyg-0005HT-GA for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 12:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Laws Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Feb 2015 17:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19688 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19688-submit@debbugs.gnu.org id=B19688.142393664020252 (code B ref 19688); Sat, 14 Feb 2015 17:58:02 +0000 Original-Received: (at 19688) by debbugs.gnu.org; 14 Feb 2015 17:57:20 +0000 Original-Received: from localhost ([127.0.0.1]:44116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMgy0-0005Ga-9O for submit@debbugs.gnu.org; Sat, 14 Feb 2015 12:57:20 -0500 Original-Received: from mail-ie0-f177.google.com ([209.85.223.177]:38526) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMgxy-0005GN-TH for 19688@debbugs.gnu.org; Sat, 14 Feb 2015 12:57:19 -0500 Original-Received: by iecrd18 with SMTP id rd18so26315675iec.5 for <19688@debbugs.gnu.org>; Sat, 14 Feb 2015 09:57:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=68ft9UiAAFJavrbmo1E86GgV8SBrapYeVIydYpAamJc=; b=KRZLN3xHku9tY0Wgio5bxgpdXqWtCXsFg9OycOTKB8OG/dHolzl5q9rCkLL+Xyb+rr fbOobNsX0BU1oR1UYKn/BhV2J/XDmPstc9F47Qn4V8UzLPMziO8AaftfuLoJujeKU4gy CZVOB8oC8DKhtyHDfjCTLjk9qS4J4SQB9J41vwynzloVG0bdDL5WSCJXpXGiEQr9BxXh 8anNsP8cnNav9RPTfqCR0R5GWOXt0B95X53CybyEnLsKPeTVMj1aUHYZAeMfZMjipF1I YUvmuB+AgF886hLTtfc/MA5LpAF00leDhdCN4m9EAHngmS19vYpc+wAZYh5J9c9uN/I+ cKuQ== X-Gm-Message-State: ALoCoQkolWuLid0z6oEKjVfz0XAQHNxuTv8J1A+3/9UQWIvVTP4s6rvV1z34mzmvnZeJgNQOOgMc X-Received: by 10.107.47.22 with SMTP id j22mr20200388ioo.16.1423936633118; Sat, 14 Feb 2015 09:57:13 -0800 (PST) Original-Received: by 10.36.65.195 with HTTP; Sat, 14 Feb 2015 09:57:13 -0800 (PST) X-Originating-IP: [219.102.234.58] In-Reply-To: <83bnkwwfsz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99403 Archived-At: On Sun, Feb 15, 2015 at 2:42 AM, Eli Zaretskii wrote: > OK, I have only one comment to that: why did you need to make part of > daemon-initialized a separate function? That was because of the pre-C99 concern I mentioned earlier in the thread, but since you said emacs-25 will require a C99-compliant compiler, it shouldn't be necessary. However, see my next comment. > In general, it looks to me that we should make a separate > implementation of daemon-initialized for Windows, and put it on one of > the w32*.c files. Given that the Windows implementation of the function is three lines long and consists solely of side effects that are already localized to emacs.c, I think it's much clearer to keep it as-is. > Other than that, we are waiting for your assignment. OK. It should be waiting for whoever reads assign@gnu.org. -- |v\ /\ |\ |< |_ /\ \^| //