From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolai Weibull Newsgroups: gmane.emacs.help Subject: Re: Changes in how faces from themes are applied in 24.1? Date: Mon, 23 Jul 2012 19:07:22 +0200 Message-ID: References: <83629f1zkv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1343063276 32526 80.91.229.3 (23 Jul 2012 17:07:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 23 Jul 2012 17:07:56 +0000 (UTC) Cc: help-gnu-emacs@gnu.org To: Eli Zaretskii Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Jul 23 19:07:56 2012 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1StM6q-0003ps-Nb for geh-help-gnu-emacs@m.gmane.org; Mon, 23 Jul 2012 19:07:52 +0200 Original-Received: from localhost ([::1]:59337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StM6p-0005tE-UP for geh-help-gnu-emacs@m.gmane.org; Mon, 23 Jul 2012 13:07:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StM6g-0005nQ-4E for help-gnu-emacs@gnu.org; Mon, 23 Jul 2012 13:07:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StM6W-0007LG-Hb for help-gnu-emacs@gnu.org; Mon, 23 Jul 2012 13:07:42 -0400 Original-Received: from mail-yx0-f169.google.com ([209.85.213.169]:36142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StM6N-00075k-FZ; Mon, 23 Jul 2012 13:07:23 -0400 Original-Received: by yenr5 with SMTP id r5so6747056yen.0 for ; Mon, 23 Jul 2012 10:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=4tySyFldLj6PbQM1sueXeWxoRcoTUg2RRl+ByjZgTug=; b=zzAu7EoF9M6waQTHEtWR9QmsMxRAPNjRblUa14T21ixYvCGNq3yQcRplHlQkRRgZ4N rl9IzlE4PUxcsKJfEgXNDPyDKlVPpGNkhyOt3azsl2mI88YVevaL5NCLK/uUsxOXlGOL 4MZRWMexuaE95K8MAsRyFmV5CDWzPUh4MdjYQLkojKO7bMyguoymiSP1hZG1R5g1alO4 DD7I7CDkOWJ0NVSDMPGB+Q7cfZHFl7JwjePucQ22h6NUu/g6+iVQGomYq2+njYTg0Y4K cU/SPC4/NdpCPFtjb64nYjujWWgQSwPBu0VSA3iLIe0XyUZo/Y1vhin26xS0CI9S/nOX tlAQ== Original-Received: by 10.68.229.33 with SMTP id sn1mr36803766pbc.9.1343063242209; Mon, 23 Jul 2012 10:07:22 -0700 (PDT) Original-Received: by 10.68.42.106 with HTTP; Mon, 23 Jul 2012 10:07:22 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: 9xLC0uiOHvubPfuuwGqPdjs7oKg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.213.169 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:85987 Archived-At: On Sun, Jul 22, 2012 at 7:51 PM, Nikolai Weibull wrote: > On Sun, Jul 22, 2012 at 7:21 PM, Eli Zaretskii wrote: >>> Date: Sun, 22 Jul 2012 19:07:00 +0200 >>> From: Nikolai Weibull >>> >>> How do I get the previous behavior, where the face only had the >>> properties listed in the specification to custom-theme-set-faces? > >> Does it help to have a non-nil NOW member of the forms in the argument >> list to custom-theme-set-faces? > > Sorry, I should have mentioned that a non-nil NOW member seems to have > no effect. After further investigation there seems to be a problem with how custom--inhibit-theme-enable is used when considering how custom-theme-set-faces is implemented and how other functions depend on how it sets things up. I posted the following on the dev list: It seems that the interaction between load-theme and custom-theme-set-faces is broken. Previously, before a commit on 2011-03-21 that changed how custom--inhibit-theme-enable was used, custom-theme-set-faces would do quite a bit of work (setting properties) that other code depends upon (unless custom--inhibit-theme-enable was t, of course). For example, it would set 'saved-face, which face-spec-recalc checks for to determine how it should recalculate the specification of a face. As this code is no longer executed (ever, it seems, as custom--inhibit-theme-enable is never logically non-t while it=E2=80=99s being executed), this is now broke= n, which means that faces set through themes will always be a combination of the face-default-spec of the face and the spec of the theme. The same goes for custom-theme-set-variables, but isn=E2=80=99t as visually= apparent.