From: Nikolai Weibull <now@bitwi.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Changes in how faces from themes are applied in 24.1?
Date: Mon, 23 Jul 2012 19:07:22 +0200 [thread overview]
Message-ID: <CADdV=MuMSm+XCV9BNXHevWxRm=jjRpTwXU2NVUGfS9pEwJnKyg@mail.gmail.com> (raw)
In-Reply-To: <CADdV=Mtx9rkGVpoutyump8A34vwH=LSxVAM7Usx==QrgZSEwHA@mail.gmail.com>
On Sun, Jul 22, 2012 at 7:51 PM, Nikolai Weibull <now@bitwi.se> wrote:
> On Sun, Jul 22, 2012 at 7:21 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>> Date: Sun, 22 Jul 2012 19:07:00 +0200
>>> From: Nikolai Weibull <now@bitwi.se>
>>>
>>> How do I get the previous behavior, where the face only had the
>>> properties listed in the specification to custom-theme-set-faces?
>
>> Does it help to have a non-nil NOW member of the forms in the argument
>> list to custom-theme-set-faces?
>
> Sorry, I should have mentioned that a non-nil NOW member seems to have
> no effect.
After further investigation there seems to be a problem with how
custom--inhibit-theme-enable is used when considering how
custom-theme-set-faces is implemented and how other functions depend
on how it sets things up. I posted the following on the dev list:
It seems that the interaction between load-theme and
custom-theme-set-faces is broken. Previously, before a commit on
2011-03-21 that changed how custom--inhibit-theme-enable was used,
custom-theme-set-faces would do quite a bit of work (setting
properties) that other code depends upon (unless
custom--inhibit-theme-enable was t, of course). For example, it would
set 'saved-face, which face-spec-recalc checks for to determine how it
should recalculate the specification of a face. As this code is no
longer executed (ever, it seems, as custom--inhibit-theme-enable is
never logically non-t while it’s being executed), this is now broken,
which means that faces set through themes will always be a combination
of the face-default-spec of the face and the spec of the theme.
The same goes for custom-theme-set-variables, but isn’t as visually apparent.
prev parent reply other threads:[~2012-07-23 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 17:07 Changes in how faces from themes are applied in 24.1? Nikolai Weibull
2012-07-22 17:21 ` Eli Zaretskii
2012-07-22 17:51 ` Nikolai Weibull
2012-07-23 17:07 ` Nikolai Weibull [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADdV=MuMSm+XCV9BNXHevWxRm=jjRpTwXU2NVUGfS9pEwJnKyg@mail.gmail.com' \
--to=now@bitwi.se \
--cc=eliz@gnu.org \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.