From: Allen Li <darkfeline@felesatra.moe>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Allen Li <vianchielfaura@gmail.com>, 29575@debbugs.gnu.org
Subject: bug#29575: 25.3; Secret Service API treats labels as unique
Date: Mon, 21 May 2018 00:51:29 -0700 [thread overview]
Message-ID: <CADbSrJzOCeSvyBxM7=iA=o7XYhzX6Tgkd+uyZJs=T3ruH81e5A@mail.gmail.com> (raw)
In-Reply-To: <87bmdh3wnd.fsf@gmx.de>
Thanks. It doesn't look like there is a way to get the object path by
searching attributes? That means there's no way to get the object path for
a secret added from a cooperating application (that may not have a unique
label). secrets-search-items returns labels. Ideally there would be a
variant of secrets-search-items that returned object paths.
Also, the docstring for secrets-create-items now has this line which I
think is misleading:
The label ITEM must not be unique in COLLECTION.
Should it be:
The label ITEM does not have to be unique in COLLECTION.
On Tue, May 15, 2018 at 5:56 AM Michael Albinus <michael.albinus@gmx.de>
wrote:
> Michael Albinus <michael.albinus@gmx.de> writes:
> Hi Allen,
> >>> Well, inside the org.freedesktop.Secret.{Service,Collection,Item}
> >>> interfaces, an item is identified by an object path. We could extend
our
> >>> interface to allow both label and object path as item, and to throw
away
> >>> the "unique label rule" inside collections.
> >>
> >> That sounds like a better starting idea. One problem that comes to
> >> mind is that the object path could be a valid label value, I think.
> >
> > That's possible, yes. But I doubt it will happen in reality. At least in
> > Emacs we could check, that a label doesn't look like an object path, and
> > suppress such items for being considered.
> Finally, I found the time to implement this. `secrets-create-item' does
> allow labels now which exist already in a collection. `secrets-item-path',
> `secrets-get-secret', `secrets-get-attributes', 'secrets-get-attribute'
> and `secrets-delete-item' allow also object paths as argument.
> Pushed to the master branch. Could you pls check whether this fits your
needs?
> Best regards, Michael.
next prev parent reply other threads:[~2018-05-21 7:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 5:42 bug#29575: 25.3; Secret Service API treats labels as unique Allen Li
2017-12-11 13:02 ` Michael Albinus
2017-12-11 19:47 ` Allen Li
2017-12-12 8:35 ` Michael Albinus
2017-12-13 3:41 ` Allen Li
2017-12-13 14:41 ` Ted Zlatanov
2018-05-15 12:56 ` Michael Albinus
2018-05-21 7:51 ` Allen Li [this message]
2018-05-22 9:35 ` Michael Albinus
2018-09-05 9:00 ` Michael Albinus
2018-09-08 23:58 ` Allen Li
2018-09-11 9:49 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADbSrJzOCeSvyBxM7=iA=o7XYhzX6Tgkd+uyZJs=T3ruH81e5A@mail.gmail.com' \
--to=darkfeline@felesatra.moe \
--cc=29575@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.