Don't see PATCH on bug-gnu-emacs

Don't see PATCH on bug-gnu-emacs

[Niall Dooley]

I submitted a simple patch email titled as follows over two hours ago.

[PATCH] eglot: Add ruff-lsp as an alternative python server

This is my first patch so likely I did something wrong.

I did not attach a patch file but rather sent it inline in the mail.
Reading CONTRIBUTE more carefully I now see an attachment is preferred.
Is this why it does not appear on the list?  Should I send the mail
again with the attachment or reply to my original mail?

Thanks for your time.

Re: Don't see PATCH on bug-gnu-emacs

[Philip Kaludercic]

Niall Dooley <dooleyn@gmail.com> writes:

> I submitted a simple patch email titled as follows over two hours ago.
>
> [PATCH] eglot: Add ruff-lsp as an alternative python server
>
> This is my first patch so likely I did something wrong.
>
> I did not attach a patch file but rather sent it inline in the mail.
> Reading CONTRIBUTE more carefully I now see an attachment is preferred.
> Is this why it does not appear on the list?  Should I send the mail
> again with the attachment or reply to my original mail?

Both should appear on the mailing list, the issue with inline patches
depending on your MUA is that that might be misrendered.  I couldn't
find anything by your name on bug-gnu-emacs@gnu.org, so I guess
something else went wrong.  Try resending your message -- even if you
make a mistake, it is nothing to worry about, it happens all the time
and nobody will get annoyed or anything like that.

> Thanks for your time.

Re: Don't see PATCH on bug-gnu-emacs

[Eli Zaretskii]

> From: Niall Dooley <dooleyn@gmail.com>
> Date: Fri, 24 Nov 2023 19:39:10 +0100
> 
> I submitted a simple patch email titled as follows over two hours ago.
> 
> [PATCH] eglot: Add ruff-lsp as an alternative python server
> 
> This is my first patch so likely I did something wrong.
> 
> I did not attach a patch file but rather sent it inline in the mail.
> Reading CONTRIBUTE more carefully I now see an attachment is preferred.
> Is this why it does not appear on the list?

No, inline patches are also okay, although attachments are preferable.

> Should I send the mail again with the attachment or reply to my
> original mail?

Please wait for Michael (CC'ed) to chime in and tell why your
submission didn't get through.

Re: Don't see PATCH on bug-gnu-emacs

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

Hi,

>> I submitted a simple patch email titled as follows over two hours ago.
>>
>> [PATCH] eglot: Add ruff-lsp as an alternative python server
>>
>> This is my first patch so likely I did something wrong.
>>
>> I did not attach a patch file but rather sent it inline in the mail.
>> Reading CONTRIBUTE more carefully I now see an attachment is preferred.
>> Is this why it does not appear on the list?
>
> No, inline patches are also okay, although attachments are preferable.
>
>> Should I send the mail again with the attachment or reply to my
>> original mail?
>
> Please wait for Michael (CC'ed) to chime in and tell why your
> submission didn't get through.

In the mailman logs, there are the respective entries:

--8<---------------cut here---------------start------------->8---
Nov 24 10:53:35 2023 (731) Debbugs-submit post from dooleyn@gmail.com held, message-id=<20231124155236.49559-1-dooleyn@gmail.com>: Post by non-member to a members-only list
Nov 24 17:43:21 2023 (731) Debbugs-submit post from dooleyn@gmail.com held, message-id=<CADS3Lq4sAqT4vVyBm73A4B-U0erdmMCEY+voftkDRorxxNZwZg@mail.gmail.com>: Post by non-member to a members-only list
Nov 25 03:17:32 2023 (29192) debbugs-submit: held message approved, message-id: <20231124155236.49559-1-dooleyn@gmail.com>
Nov 25 03:17:32 2023 (29192) debbugs-submit: held message approved, message-id: <CADS3Lq4sAqT4vVyBm73A4B-U0erdmMCEY+voftkDRorxxNZwZg@mail.gmail.com>
--8<---------------cut here---------------end--------------->8---

And indeed, <20231124155236.49559-1-dooleyn@gmail.com> and
<CADS3Lq4sAqT4vVyBm73A4B-U0erdmMCEY+voftkDRorxxNZwZg@mail.gmail.com> are
visible in ML <bug-gnu-emacs.gnu.org>. So everything is fine.

There was a longer delay than usual before approving, but this could
happen if none of the moderators is online. But it is still less than a
day...

Best regards, Michael.

Re: Don't see PATCH on bug-gnu-emacs

[Niall Dooley]

On Sat, 25 Nov 2023 at 08:02, Eli Zaretskii <eliz@gnu.org> wrote:
> Please wait for Michael (CC'ed) to chime in and tell why your
> submission didn't get through.

Sorry, I had sent the mail again after Philip's reply.

Re: Don't see PATCH on bug-gnu-emacs

[Niall Dooley]

On Sat, 25 Nov 2023 at 11:07, Michael Albinus <michael.albinus@gmx.de> wrote:
> In the mailman logs, there are the respective entries:
>
> --8<---------------cut here---------------start------------->8---
> Nov 24 10:53:35 2023 (731) Debbugs-submit post from dooleyn@gmail.com held, message-id=<20231124155236.49559-1-dooleyn@gmail.com>: Post by non-member to a members-only list
> Nov 24 17:43:21 2023 (731) Debbugs-submit post from dooleyn@gmail.com held, message-id=<CADS3Lq4sAqT4vVyBm73A4B-U0erdmMCEY+voftkDRorxxNZwZg@mail.gmail.com>: Post by non-member to a members-only list
> Nov 25 03:17:32 2023 (29192) debbugs-submit: held message approved, message-id: <20231124155236.49559-1-dooleyn@gmail.com>
> Nov 25 03:17:32 2023 (29192) debbugs-submit: held message approved, message-id: <CADS3Lq4sAqT4vVyBm73A4B-U0erdmMCEY+voftkDRorxxNZwZg@mail.gmail.com>
> --8<---------------cut here---------------end--------------->8---
>
> And indeed, <20231124155236.49559-1-dooleyn@gmail.com> and
> <CADS3Lq4sAqT4vVyBm73A4B-U0erdmMCEY+voftkDRorxxNZwZg@mail.gmail.com> are
> visible in ML <bug-gnu-emacs.gnu.org>. So everything is fine.
>
> There was a longer delay than usual before approving, but this could
> happen if none of the moderators is online. But it is still less than a
> day...

Thanks Michael.