From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Psionic K Newsgroups: gmane.emacs.devel Subject: Re: Submitting Dslide to Non-GNU ELPA Date: Fri, 21 Jun 2024 22:42:26 +0900 Message-ID: References: <874j9o599o.fsf@posteo.net> <87zfrf4uaw.fsf@posteo.net> <87v8234i24.fsf@posteo.net> <871q4qrg9d.fsf@posteo.net> <87plsapyq9.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c417dd061b669aaa" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31307"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 21 15:43:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKeXw-000807-8i for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jun 2024 15:43:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKeXJ-0007gJ-QZ; Fri, 21 Jun 2024 09:42:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKeXI-0007g9-St for emacs-devel@gnu.org; Fri, 21 Jun 2024 09:42:40 -0400 Original-Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKeXG-0002aO-Tp for emacs-devel@gnu.org; Fri, 21 Jun 2024 09:42:40 -0400 Original-Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-e026a2238d8so2086018276.0 for ; Fri, 21 Jun 2024 06:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=positron.solutions; s=google; t=1718977357; x=1719582157; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FRGXmsWUc79w4nyYrKqyUa97kAt3DbghxFdsin/TDkI=; b=g3AYPaYaXWPkc6NW6YlQrKdY47XYUtSXJSWnFoMOl62dwgM+yJqcN9NOMwJmDDU0E1 mgILk0vnHZTco8go8dzffqvE4FbEXw+zTpsNzc8KZc4puDwYxEdxhsnmFKf2YmGC0oMJ 4x3Ag/urhthevvOMMcFJmoXrualIXV9zcz4S8oLjCiYFQZYHzaK7mrkX5XyXv/pcsSdi kOYd8N52mHRRjYdXmui8b21gY/S4NdrVetBEYFmYxUuBNq5mnlIdQJE2QK1dlmlGnj0d mQXMGQzn6arvn+iYJWdc5LX6o25QQEhhdHN2LTxsTkMAD7D+BTU97e0nUXlOgxidS/w1 Ldfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718977357; x=1719582157; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FRGXmsWUc79w4nyYrKqyUa97kAt3DbghxFdsin/TDkI=; b=gSsonyN9vciXaYCjoP/dzvLqe+kODmEwpHVL4TmVWU9GebCglQphvWU74DhFGyv2jj S2fQt84KT21SnOBrjKTWZZWZHzr0rW+qzEGEvDqtGQxvjapTcTty0XzS9B9oLt+8gXq7 d7UNrUMVLob2C9S24b4W6z5Sb35tb2PcYQF4ATjLllnKVTvIotcKjllh4c4X9AUF3tBC ryf3h48OaKlNuNioaK+ipjkvzeZZ5iycW0pERwIM+GqldHLUNcjksylUEQ+vfx+vF/jx xstvJPvkhWLydwHg1L/6adKzFJ1aQgicnFMG7DjhET6UIatscM2xIRkfCwcDqKBzYqcp ZHxA== X-Gm-Message-State: AOJu0Yyd6L3Joc4fkroSwHXbJiZAeqlukDyacBrq7y/u45Pl9/e6YYvT k57RlJEtP0oPIGdw/NwUSNYieW7I+yrtx+CAtoa7TEsmeOA3wooBYLUb6GmDyI2klUGTNzgQD2M mzTxJwqKn9PupaTjUeqicuBjt2txBRMOHPM+FanfxpKlCZmEJrurmQw== X-Google-Smtp-Source: AGHT+IEFXygkHs4OVobwaicAyZZU/R42vH+AlXXMnHbU3CH1l7DaS6ytPzNjNH1dTQKJ9UTZt02ASjXirVkTqbzgxQM= X-Received: by 2002:a25:bc91:0:b0:dfb:97b:479a with SMTP id 3f1490d57ef6-e02be20b8f8mr8892016276.50.1718977357412; Fri, 21 Jun 2024 06:42:37 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b30; envelope-from=exec@positron.solutions; helo=mail-yb1-xb30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320403 Archived-At: --000000000000c417dd061b669aaa Content-Type: text/plain; charset="UTF-8" I pushed updates. I declined two changes and wanted to point them out: > (defun dslide--list-item-contains (item loc) > - (when item > - (let ((beg (car item)) > - (end (car (last item)))) > - (and (>= loc beg) > - (< loc end))))) > + (and item (<= (car item) loc (+ (car (last item)))))) I omitted the call to `+'. No idea what it could do there. `item' is an org item, which will always contain an integer in this situation. I did not use `message--max' because it produced a compiler warning. If either of these are still recommended, just let me know. --000000000000c417dd061b669aaa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I pushed updates.=C2=A0 I declined t= wo changes and wanted to point them out:

> = =C2=A0(defun dslide--list-item-contains (item loc)
> - =C2=A0(when it= em
> - =C2=A0 =C2=A0(let ((beg (car item))
> - =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(end (car (last item))))
> - =C2=A0 =C2=A0 =C2=A0= (and =C2=A0(>=3D loc beg)
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(< loc end)))))
> + =C2=A0(and item (<=3D (car item) loc = (+ (car (last item))))))

I omitted the call to `+&= #39;.=C2=A0 No idea what it could do there.=C2=A0 `item' is an org item= , which will always contain an integer in this situation.

I did not use `message--max' because it produced a compiler war= ning.

If either of these are still recom= mended, just let me know.
--000000000000c417dd061b669aaa--