From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Henrik Nyman Newsgroups: gmane.emacs.bugs Subject: bug#22060: 25.1.50; Fringe faces or not honored in 25.1.50.1 on OSX 10.11 installed via homebrew --use-git-head --cocoa Date: Mon, 24 Apr 2017 10:30:43 +0000 Message-ID: References: <30EE68E8-0158-4079-8DD4-B80599305039@gmail.com> <20170424094808.GA99570@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1149aaaa1befbe054de71a29 X-Trace: blaine.gmane.org 1493048214 21933 195.159.176.226 (24 Apr 2017 15:36:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Apr 2017 15:36:54 +0000 (UTC) Cc: 22060@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 24 17:36:47 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2g2g-0005RD-2U for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Apr 2017 17:36:46 +0200 Original-Received: from localhost ([::1]:44693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2g2j-0001Tn-SB for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Apr 2017 11:36:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2g08-00089e-ED for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 11:34:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2g02-00006b-DI for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 11:34:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39975) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2g02-00006W-61 for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 11:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d2g01-0001q5-TH for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 11:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Henrik Nyman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Apr 2017 15:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22060-submit@debbugs.gnu.org id=B22060.14930479917007 (code B ref 22060); Mon, 24 Apr 2017 15:34:01 +0000 Original-Received: (at 22060) by debbugs.gnu.org; 24 Apr 2017 15:33:11 +0000 Original-Received: from localhost ([127.0.0.1]:38174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2fzC-0001ow-NF for submit@debbugs.gnu.org; Mon, 24 Apr 2017 11:33:11 -0400 Original-Received: from mail-qk0-f176.google.com ([209.85.220.176]:36351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2bGl-0005um-Vn for 22060@debbugs.gnu.org; Mon, 24 Apr 2017 06:31:00 -0400 Original-Received: by mail-qk0-f176.google.com with SMTP id u75so15780335qka.3 for <22060@debbugs.gnu.org>; Mon, 24 Apr 2017 03:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MbP2wCES4+uCqFzauu1zDR+erT30WpOcAXKw9Aughr0=; b=uW9EdVNjSjWVNj//QgzBLjhqbtzEssZsn9VwLuPIk63NYn2t4Z4GMmlk+vRHt/0plz WxtUKxn0nglPAILdbv4gLzIEO52+d9tYW3r4Hl8oiOyfe8s9b57vXrfUqImJS2BvsuW4 uDwR2dzKdEtqZa+PPGwdRvDrPmJWQL1zsA59LrZ9o43SfMClN39wF1tziuwGzij4bNZm 9noU1j5Vmaq7GxmwrxKzg4ZWQZJC3GSanPap8qo5lihdTsu43ffNRzNKMuFd0rwNVuWA XIFNjGE3/MQ2JGbYL9Nh9zuORGOl2rknS4d+Vo6fFoCiuHQDSdhHsng0dSYDLX3xh790 ps6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MbP2wCES4+uCqFzauu1zDR+erT30WpOcAXKw9Aughr0=; b=q/sls22ZJydjp8S4kdQ+gRJdR+LkOORJNQrilVOZw5htk8V29Yww+XHwD/wi8iIB56 j3qlmBsk/uVzGj4/0o9BMaByq6Joz3DYn/4a9bt7FS4cIU2IngGADGqGztGfNunt9tS6 6kLGVCtnagJpWvznnTMXb2I2F1SGE0ybm1BSo4rVHZ08UGTX6o2ZwCYcbpFf5ns8/EQc zJTH/jhhsFMVfYI8awDEkanOdHSBj1+GITh1vrNtnjPCKBLi3RcyI/HCdmWUOqNgMEcK /HlcLj9Tp3YZWGPyRLYaWqFGwsy3g6IBh7LqCKBWYT2xeUjUm636m0mkfe2STwIu1lXK Ir5A== X-Gm-Message-State: AN3rC/791QYq+PcYC+muj3Q8QFmdocCypBYs0mX8WkB5Mz5K0hpSVf5Z taeicrXVtAzu0pWUj5de/zL29rfEGUWP X-Received: by 10.55.192.21 with SMTP id o21mr19520994qki.10.1493029854374; Mon, 24 Apr 2017 03:30:54 -0700 (PDT) In-Reply-To: <20170424094808.GA99570@breton.holly.idiocy.org> X-Mailman-Approved-At: Mon, 24 Apr 2017 11:33:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131938 Archived-At: --001a1149aaaa1befbe054de71a29 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Can confirm that the bug is fixed on master now. Thanks for the quick response! -Henrik On Mon, Apr 24, 2017 at 12:48 PM Alan Third wrote: > On Sun, Apr 23, 2017 at 07:40:17PM +0000, Henrik Nyman wrote: > > Referred to this issue at: > > > > https://github.com/flycheck/flycheck/issues/811#issuecomment-29647640= 4 > > > > > > I hope this helps with creating a proper fix. > > I=E2=80=99ve pushed a fix to the master branch. Can you please give it a = try? > > > (there probably was a reason to save the foreground color in a > > member variable in the first place). > > I think the old code just looked at the alpha channel to determine > whether any particular pixel was background or foreground, but the new > code uses the actual colour value. > > If you then change the foreground colour, you have to look for that > new colour the next time you want to change it. > > I=E2=80=99m not really sure why that specific change was made. I can only > assume that the alpha channel isn=E2=80=99t always a perfect guide. > -- > Alan Third > --001a1149aaaa1befbe054de71a29 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Can confirm that the bug is fixed on master now. Thanks fo= r the quick response!

-Henrik

On Mon, Apr 24, 2017 at 12:48 PM Alan Thi= rd <alan@idiocy.org> wrote:
On Sun, Apr 23, 2017 at 07:40:17PM +0= 000, Henrik Nyman wrote:
> Referred to this issue at:
>
>=C2=A0 =C2=A0https://githu= b.com/flycheck/flycheck/issues/811#issuecomment-296476404
>
>
> I hope this helps with creating a proper fix.

I=E2=80=99ve pushed a fix to the master branch. Can you please give it a tr= y?

> (there probably was a reason to save the foreground color in a
> member variable in the first place).

I think the old code just looked at the alpha channel to determine
whether any particular pixel was background or foreground, but the new
code uses the actual colour value.

If you then change the foreground colour, you have to look for that
new colour the next time you want to change it.

I=E2=80=99m not really sure why that specific change was made. I can only assume that the alpha channel isn=E2=80=99t always a perfect guide.
--
Alan Third
--001a1149aaaa1befbe054de71a29--