all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Henrik Nyman <henrikjohannesnyman@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: 22060@debbugs.gnu.org
Subject: bug#22060: 25.1.50; Fringe faces or not honored in 25.1.50.1 on OSX 10.11 installed via homebrew --use-git-head --cocoa
Date: Mon, 24 Apr 2017 10:30:43 +0000	[thread overview]
Message-ID: <CADHidMon6zAP_7mR3J7rn0s6Qpid-mqpb3WspCYrGyi5ZTpJCg@mail.gmail.com> (raw)
In-Reply-To: <20170424094808.GA99570@breton.holly.idiocy.org>

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

Can confirm that the bug is fixed on master now. Thanks for the quick
response!

-Henrik

On Mon, Apr 24, 2017 at 12:48 PM Alan Third <alan@idiocy.org> wrote:

> On Sun, Apr 23, 2017 at 07:40:17PM +0000, Henrik Nyman wrote:
> > Referred to this issue at:
> >
> >   https://github.com/flycheck/flycheck/issues/811#issuecomment-296476404
> >
> >
> > I hope this helps with creating a proper fix.
>
> I’ve pushed a fix to the master branch. Can you please give it a try?
>
> > (there probably was a reason to save the foreground color in a
> > member variable in the first place).
>
> I think the old code just looked at the alpha channel to determine
> whether any particular pixel was background or foreground, but the new
> code uses the actual colour value.
>
> If you then change the foreground colour, you have to look for that
> new colour the next time you want to change it.
>
> I’m not really sure why that specific change was made. I can only
> assume that the alpha channel isn’t always a perfect guide.
> --
> Alan Third
>

[-- Attachment #2: Type: text/html, Size: 1519 bytes --]

      reply	other threads:[~2017-04-24 10:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 12:35 bug#22060: 25.1.50; Fringe faces or not honored in 25.1.50.1 on OSX 10.11 installed via homebrew --use-git-head --cocoa Julien Wintz
2015-12-04  6:46 ` Alex Dunn
2016-12-08 22:07   ` Glenn Morris
2017-04-23 19:40 ` Henrik Nyman
2017-04-24  9:48   ` Alan Third
2017-04-24 10:30     ` Henrik Nyman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADHidMon6zAP_7mR3J7rn0s6Qpid-mqpb3WspCYrGyi5ZTpJCg@mail.gmail.com \
    --to=henrikjohannesnyman@gmail.com \
    --cc=22060@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.