From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Fussner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53749: 29.0.50; [PATCH] Xref backend for TeX buffers Date: Mon, 29 Jul 2024 11:31:21 +0100 Message-ID: References: <83ba27b7-4d28-4a3f-b803-4bc49f62986c@yandex.ru> <82993b86-0f34-4adb-a392-c74db5176d14@yandex.ru> <86v832z5lp.fsf@gnu.org> <6efddf34-1f18-41c8-9125-b6b2e3ad3d21@yandex.ru> <75d6872c-4c31-44a5-8597-781741dca720@yandex.ru> <2fc35487-63c7-4d11-89ca-b87f4aad6e58@yandex.ru> Reply-To: David Fussner Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38308"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53749@debbugs.gnu.org, ikumi@ikumi.que.jp, Arash Esbati , stefankangas@gmail.com, tsdh@gnu.org, eliz@gnu.org, monnier@iro.umontreal.ca To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 29 12:33:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYNh3-0009mA-8d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jul 2024 12:33:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYNga-0001b2-Ii; Mon, 29 Jul 2024 06:33:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYNgQ-0001Yc-FW for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 06:32:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sYNgP-0003pE-E8 for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 06:32:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=V5nOs/aBTF+63ciTZj9Qs8dcHVTEijiPsnv7JdnjYP0=; b=UATIWtJ9G9/cR/GGgP8xxK+frtoWhkgKdVV6iJv59+1KTMXHYr/l7bv3svpCWr03BIVyOr6X+csuUeLXzQFgIxPWBqL6V15w4rpfwSiQFTBBf/z/Ss2fn1wRA5UChj6k5GSSlp4voL+fGEAmVacf8ZKmAvSFQ1IjDYZXI4dOjZCbw5cHqwUbdSonwnr7nZv06uH7b37UUhYDkH+1ismNKauIs7RKoTju4lHw+hDK0HyIm1V5F4JY1yTDA3lzfmlFxa4Z2OOsj6y3e0ix0PW/nBNqDETmP85j51KhwTs0thQJ3n0wy6BeXOIL0DZ7RTeY2zy5Ht89k7jvF78eQYFO5g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sYNgc-0007xZ-0E for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 06:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Fussner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jul 2024 10:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53749 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending patch Original-Received: via spool by 53749-submit@debbugs.gnu.org id=B53749.172224915530557 (code B ref 53749); Mon, 29 Jul 2024 10:33:01 +0000 Original-Received: (at 53749) by debbugs.gnu.org; 29 Jul 2024 10:32:35 +0000 Original-Received: from localhost ([127.0.0.1]:44933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYNgA-0007wn-Re for submit@debbugs.gnu.org; Mon, 29 Jul 2024 06:32:35 -0400 Original-Received: from mail-pg1-f170.google.com ([209.85.215.170]:49652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYNg8-0007wZ-Jv for 53749@debbugs.gnu.org; Mon, 29 Jul 2024 06:32:33 -0400 Original-Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7ae3d7222d4so868628a12.3 for <53749@debbugs.gnu.org>; Mon, 29 Jul 2024 03:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1722249074; x=1722853874; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V5nOs/aBTF+63ciTZj9Qs8dcHVTEijiPsnv7JdnjYP0=; b=Z/2WYMXRsR3+MfMdeqGKBfRpfmwfsNrLTa7D+Kf49x89VA+0SUBor/qBXVuKHtbabM SvEZ36D63MFxHO+ZLsyNJMh/CBF21EW8rONjzeq5I3K1y+S16rYss7hsC1llQthmPw/K IpvdIQxnvFxCcK14aIwKNpT6vnyucCMKFDfWrAKODm7suoGOv+kJliyfHmAXY+LQQ6T4 IIl4JzcapBwYsW8q3OsMq76pLp0OqcsM0CzJWePAAqVVBYiT7kUtfm9VjyZFQC34Os5I 6xtHET4hx9p0DD0XkN5VDoC9i7alzgYz4F1rfuLv3BnlJ0V7zJn4urUuDKknr/6ju2CR FtSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722249074; x=1722853874; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V5nOs/aBTF+63ciTZj9Qs8dcHVTEijiPsnv7JdnjYP0=; b=tGcQQ+E4Ks/e+DWFD1or7uFtaZSdDkRvVtvOOLskX9EKGtPDx7rj2F6PUnCbxmC05a xgR2xRU9jJWBfpJEzMrqXfuDoh8yNdD7mexu8m6p/fQWEHciRQruNORhniKRZw2/2HH/ Gdi8Sq61W0TrYOL1KazU1gpttMwptmz1x/SS7lkeN0SpxZu3kx2sg8hGqUX/Mfpte6np LEvDPcxfkzNMHcUzwUa8pdAiDc47r3m8MrajzqPiDvELdkTCdfbe7jBVBDIVVuCALUZR U+9LIRsg2j7EMM2eWD7DFd+ag0I7ZepEBEwNg+OR0aFFXK6FrUrn2BxAAo4cCE48s2qJ nbTw== X-Forwarded-Encrypted: i=1; AJvYcCXNdEJWCi/ToriViWrr4SLMvSaiVPzeAbCl7pr5wFLoW8KGQU4y/uyypyrSkIKTUbx9QmEme4kd6VSiLuuh0eidcjJzy5U= X-Gm-Message-State: AOJu0YxfmChG5O23shq1DdDmBWtBg7165uQSAeBZMBro1zhzi6sN2+O5 UJuIzUCk9Ix3R/wjeiivcwVytqqFnRq/L/OAO2vEJcZ2IdNG0ztMNYvhRWrqCAwli7JSSVQGG51 fAvFAZRZcggNxiEKN/KjYijeXyoU= X-Google-Smtp-Source: AGHT+IH0+3j3DxqEYVWqh8eTMXhK4A/VKYwAeWtAsxL+qp8/ix34FxLKlYJ/+OeHDQAq2VkxKrCJ3jtzjusi77fOoWM= X-Received: by 2002:a17:90b:3b46:b0:2c9:61f9:a141 with SMTP id 98e67ed59e1d1-2cf7e1c074emr8153037a91.16.1722249073894; Mon, 29 Jul 2024 03:31:13 -0700 (PDT) In-Reply-To: <2fc35487-63c7-4d11-89ca-b87f4aad6e58@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289510 Archived-At: Hi Dmitry and Arash, > Additionally though, it might or might not be too big a change for Emacs > 30 (I'm not sure), and if we're talking about 31 only, then it could > wait a little more for the review. Good point -- I'm OK either way. Getting it tested, even lightly, on master for a while might make sense for a patch of its size, but others will have a better sense of it. Best, David. On Mon, 29 Jul 2024 at 00:58, Dmitry Gutov wrote: > > On 27/07/2024 18:39, Arash Esbati wrote: > > David Fussner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > > > >> Hi Dmitry, Stefan M and Stefan K, > >> > >> Here's the latest patch, with most of the modifications requested by > >> Stefan K. The code populating `semantic-symref-filepattern-alist` I've > >> left in tex-mode.el, because I wasn't sure how to adjudicate the > >> differing opinions on where it should go. Moving it won't take any > >> time, should that be the verdict. I've had a stab at a NEWS entry, and > >> included the patches to the manual etags test files. The diffs for the > >> test files are large, since we remove the TeX escape char from any tag > >> names where it occurs, as discussed elsewhere on this thread. > >> > >> Please let me know if more changes are needed. > > Ping! Gents, is it possible to give David your comments? There was > > some effort behind this, maybe it's time to bring this to an end. TIA. > > It's good enough from my side, but I hope someone else could comment as > well. > > Additionally though, it might or might not be too big a change for Emacs > 30 (I'm not sure), and if we're talking about 31 only, then it could > wait a little more for the review.