From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Radon Rosborough Newsgroups: gmane.emacs.devel Subject: Re: git history tracking across renames (and emacs support) Date: Thu, 12 Jul 2018 11:03:09 -0600 Message-ID: References: <87a7yn7tqp.fsf@lifelogs.com> <878te75xa1.fsf@lifelogs.com> <87ind6l2tt.fsf@lifelogs.com> <877etklvsa.fsf@lifelogs.com> <83y3m0pv8u.fsf@gnu.org> <86608msw0h.fsf@dod.no> <838tdiet25.fsf@gnu.org> <87y3li4vh7.fsf@telefonica.net> <87efnan46u.fsf@linux-m68k.org> <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <838t6jgl1k.fsf@gnu.org> <601m6cc6.fsf@lifelogs.com> <83o9fefnv9.fsf@gnu.org> <83d0vtfx4f.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1531414918 6430 195.159.176.226 (12 Jul 2018 17:01:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jul 2018 17:01:58 +0000 (UTC) Cc: Ted Zlatanov , Lars Ingebrigtsen , emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 12 19:01:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdeyW-0001Y6-AZ for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 19:01:52 +0200 Original-Received: from localhost ([::1]:33176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdf0d-0004ti-9j for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 13:04:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdf0Q-0004sE-R0 for emacs-devel@gnu.org; Thu, 12 Jul 2018 13:03:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdf0P-00017a-LK for emacs-devel@gnu.org; Thu, 12 Jul 2018 13:03:50 -0400 Original-Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:36551) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdf0N-00013r-CI; Thu, 12 Jul 2018 13:03:47 -0400 Original-Received: by mail-lj1-x233.google.com with SMTP id u7-v6so19887861lji.3; Thu, 12 Jul 2018 10:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vmyYC0Ty3MVJL9WwTAt67KsyTSn7d1rGRR7lwgbSpAQ=; b=IDJn1nnaYUBnrAFMcTYtO/hBqE5l/ZDoZhGiXxrfrCMo2E+6tECz+aSgs+t8EfmMzW v24QF7xjzIZlXGIWVT0/5zI43JJGV5AUi7IBvBxRaw9vUR9tAV6bzRz0NMQ+qEnXtuvk rIJLas//dsiz/1vcNlageJhqI2prPVbI4j08/t+AhpXVFsxxuLahYonljmiR1VyBfDfo MAbFs0mEZQ6F+jsMnQFfwoF1jBRbpTs2siseC6Pdo+2wd62ZO25tsA7BaseE/kC5V+Yp q52WZclNLiW60yEvVS1/KQ1rZpXRvi9y3E3kkZL9DlaV8iI39g7J7UIN7LHriLj+TyS6 ALHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vmyYC0Ty3MVJL9WwTAt67KsyTSn7d1rGRR7lwgbSpAQ=; b=sw5eDx/30P8UUU+XOZKxVvP2NeczIqbVZXrTfVbMa9ZyOdXZ0AsvPNjROpO0bMrA3C AVenfcSn72eobuwKulVyj5KXcUyM69Z0eKVWm55ij+N/eSTYI7sgRhYV0nPaf6TmG51h 5xd5AFvWmHE+e3zFT4QuUFOJZQ9XOsRMZMfaE28GF+T9jSJFYDUsuxH0wIUePX25aS+n 6TOF/Zbj9gcaoFPu8qXm/br+RIArkT/zV43AOFs1A3a0kPUed85ukMNpnFfw0dqnbB2O SrE7j6On9dfonJL+VMl1bocl558Ynpz2QsbnzUzdMChVNA51cc30YVyL0g68wv74LiUI Fo0Q== X-Gm-Message-State: AOUpUlGwGgMuWL+7hSXteJyvedoNY6KivjNV5dBGzjlTyW+mJaN5laC/ DwGoyqLNKYQ6w9R9YWr0CvVfOnML1o0hB9YEBtW0QA== X-Google-Smtp-Source: AAOMgpc6BsFw/HiXFmFuy52CzqGrHm1hYyjdfCWu3AayDj++SoJBhylDNIMyWMbOE83rmZ9bjcCFtPhTyKumPj1tHrk= X-Received: by 2002:a2e:9c04:: with SMTP id s4-v6mr1174784lji.97.1531415025666; Thu, 12 Jul 2018 10:03:45 -0700 (PDT) In-Reply-To: <83d0vtfx4f.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227290 Archived-At: > But if you have suggestions for clarifying CONTRIBUTE, please tell. I think that CONTRIBUTE needs to give a step-by-step guide for how to generate a commit message with Magit, since Magit is certainly either the most popular or second most popular version-control frontend for Emacs. It should probably also provide a step-by-step guide for doing this with VC. As soon as I am linked to documentation about editing ChangeLog files, I will assume I've gone astray, unless it's explained why editing ChangeLog files is necessary in order to generate a commit message. > I guess it depends on the projects. I contribute to several other > projects, like GDB, Gawk, and Texinfo Well, those are all GNU projects. So I think that's the difference. It seems to me that ChangeLog is a "GNU thing". As are mailing lists, avoidance of GitLab, using debbugs, etc. > Like I said: free text log messages leave a lot of space for > disagreement about what is and what isn't a good message. This is true, but it seems to me that we already have this problem. After all, the current format doesn't say anything about how to actually describe your change. It just tells you how to replicate the diff in your commit message. By dropping the format, we would only be losing the replicated diff information; we wouldn't be losing any directions on how to communicate useful information that *can't* be auto-generated, because there are no such instructions now. > IME, new contributors want clear and concise instructions; telling > them to read a long blog will definitely turn off many of them. I think the blog does a much better job of getting across its information clearly, concisely, and understandably: 1. Separate subject from body with a blank line 2. Limit the subject line to 50 characters 3. Capitalize the subject line 4. Do not end the subject line with a period 5. Use the imperative mood in the subject line 6. Wrap the body at 72 characters 7. Use the body to explain what and why vs. how Plus, everybody knows this already, since virtually every open-source project follows more or less these guidelines for commit messages. I've seen many projects which link to exactly the same blog article, in fact! On the contrary, it seems to me like the only people who know about ChangeLog format are regular contributors to GNU projects. > Think about it: why would I support radical changes in our > procedures that get in the way of my work, when I have so little > time to work on Emacs and so much to do? Of course. And I don't mean to criticize your work at all; if I came across that way, it is my fault and I apologize. I only wish to push for an agreement that "if somebody were willing to do the work to remove the ChangeLog format, then the patch would be accepted". Otherwise, who is going to write a patch?