From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Moreau Subject: Re: Moving from org-mode 6.33/7.9.3 to 8.3.2 Date: Tue, 1 Dec 2015 08:33:31 +0100 Message-ID: References: <87two4lbw6.fsf@nicolasgoaziou.fr> <87lh9fles1.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113f8f0ab2c8a90525d12cf1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3fRN-0000WY-S8 for emacs-orgmode@gnu.org; Tue, 01 Dec 2015 02:33:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3fRM-0004xZ-NP for emacs-orgmode@gnu.org; Tue, 01 Dec 2015 02:33:33 -0500 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]:33486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3fRM-0004xV-Go for emacs-orgmode@gnu.org; Tue, 01 Dec 2015 02:33:32 -0500 Received: by iouu10 with SMTP id u10so571650iou.0 for ; Mon, 30 Nov 2015 23:33:31 -0800 (PST) In-Reply-To: <87lh9fles1.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Steve Moreau , emacs-orgmode@gnu.org --001a113f8f0ab2c8a90525d12cf1 Content-Type: text/plain; charset=UTF-8 Hello, Well, actually, it seems that I did not understand anything at all :-) Sorry about that, but I am new to the source code, and it is not very clear to me. So if I try to summarize what I have got: - In the past, what I could see with the standard 'M-x fill-region' over paragraphs or lists with empty lines between each inner items, was probably performed thanks to several calls to org-fill-paragraph. Removing the org-fill-paragraph-separate-nobreak-p function simply highlights that I was fortunate to use it this way before, and there is just no org-fill-region. - There are no unit tests, nor past discussions about how different text block contents should be filled with this new function Please tell if I am still wrong, and otherwise I gonna try to implement some unit tests over different cases I may think about. Have a nice day, 2015-11-30 15:53 GMT+01:00 Nicolas Goaziou : > Hello, > > Steve Moreau writes: > > > Thanks for you answer. > > OK, I understand. That explains why I needed to add blank lines between > > list items before to fill region, such as: > > > > - item1 > > > > - item2 > > > > This is a new paragraph > > > > I have 2 more questions for you please. > > Let say I would like to give a hand and try to improve the > org-fill-region > > to deal with this case. > > Actually, there is nothing to improve. It needs to be built from > scratch. There is no function in Org to fill a region ATM. > > > - Would it be local to fill-region only, as I would suspect, or would it > > put a mess around because it is used in some other contexts I am not > aware > > of, and would it be something interesting for the org-mode according > > to you? > > I think we should bind M-q to org-fill-paragraph. This function could > delegate the work to `org-fill-region' when a region is active. > > > - If you wanted to develop it, would you surround it with a when > condition > > so that user can disable it? > > Why would someone want to disable it? > > Regards, > > -- > Nicolas Goaziou > > --001a113f8f0ab2c8a90525d12cf1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

We= ll, actually, it seems that I did not understand anything at all :-)
Sor= ry about that, but I am new to the source code, and it is not very clear to= me.

So if I try to summarize what I have got:
- In the pas= t, what I could see with the standard 'M-x fill-region' over paragr= aphs or lists with empty lines between each inner items, was probably perfo= rmed thanks to several calls to org-fill-paragraph. Removing the org-fill-p= aragraph-separate-nobreak-p function simply highlights that I was fortunate= to use it this way before, and there is just no org-fill-region.
- Ther= e are no unit tests, nor past discussions about how different text block co= ntents should be filled with this new function

Please tell if I am still wrong, and otherwise I gonna try to implement s= ome unit tests over different cases I may think about.
Have a nice= day,


2015-11-30 15:53 GMT+01:00 Nicolas Goaziou <m= ail@nicolasgoaziou.fr>:
Hello,

Steve Moreau <moreau.steve@free.= fr> writes:

> Thanks for you answer.
> OK, I understand. That explains why I needed to add blank lines betwee= n
> list items before to fill region, such as:
>
>=C2=A0 =C2=A0- item1
>
>=C2=A0 =C2=A0- item2
>
>=C2=A0 =C2=A0This is a new paragraph
>
> I have 2 more questions for you please.
> Let say I would like to give a hand and try to improve the org-fill-re= gion
> to deal with this case.

Actually, there is nothing to improve. It needs to be built from
scratch. There is no function in Org to fill a region ATM.

> - Would it be local to fill-region only, as I would suspect, or would = it
> put a mess around because it is used in some other contexts I am not a= ware
> of, and would it be something interesting for the org-mode according > to you?

I think we should bind M-q to org-fill-paragraph. This function coul= d
delegate the work to `org-fill-region' when a region is active.

> - If you wanted to develop it, would you surround it with a when condi= tion
> so that user can disable it?

Why would someone want to disable it?

Regards,

--
Nicolas Goaziou


--001a113f8f0ab2c8a90525d12cf1--