Small problem with "unmark" in *Buffer List*

Small problem with "unmark" in *Buffer List*

[Alin Soare]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

When I mark a buffer for saving (S marker in the 3rd column), the unmark
does not clean the flag.

 This happens because the unmark does simply so:

    (tabulated-list-set-col 0 " " t)

and the "S" marker is on the 3rd column, and it's not cleared.

Now I discovered that in fact "Unmark" command should be called "unmark the
deletion".

Info page, 19.5 Operating on Several Buffers, quote:

`u'
     Remove all flags from the current line, and move down
     (`Buffer-menu-unmark').

This is not true. Either press "g" to revert the buffer, or re-define
"Buffer-menu-unmark" to really unmark the buffers.

[-- Attachment #2: Type: text/html, Size: 960 bytes --]

Re: Small problem with "unmark" in *Buffer List*

[Stefan Monnier]

> When I mark a buffer for saving (S marker in the 3rd column), the unmark
> does not clean the flag.

Please report this via M-x report-emacs-bug RET so we get a bug-number
for it, thank you,


        Stefan

Re: Small problem with "unmark" in *Buffer List*

[Alin Soare]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

If you tell me what can we do to fix it, I would like to send the pathch
with the correction as well.




2013/10/30 Stefan Monnier <monnier@iro.umontreal.ca>

> > When I mark a buffer for saving (S marker in the 3rd column), the unmark
> > does not clean the flag.
>
> Please report this via M-x report-emacs-bug RET so we get a bug-number
> for it, thank you,
>
>
>         Stefan
>

[-- Attachment #2: Type: text/html, Size: 774 bytes --]

Re: Small problem with "unmark" in *Buffer List*

[Stefan Monnier]

> If you tell me what can we do to fix it, I would like to send the pathch
> with the correction as well.

The fix would be to make unmark remove the S marker as well, I think.


        Stefan

RE: Small problem with "unmark" in *Buffer List*

[Drew Adams]

> The fix would be to make unmark remove the S marker as well

Which would just restore the traditional behavior.
The regression was introduced in Emacs 24.3.  Look at the
changes between 24.2 and 24.3 to see what needs to be done.

Re: Small problem with "unmark" in *Buffer List*

[Alin Soare]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

As a 2-minute looking over the definition of buff-menu.el and over the
definition of `19.5 Operating on Several Buffers`, I think I need to check
whether the buffer was modified, and in case that it was, I insert '*' on
the 3rd column, otherwise insert space.

I remember this problem repeating for many years, but today it disturbed me
again , and this is why I mailed.

In fact, the patch of the function "Buffer-menu-unmark" will look something
like:

if "the 3rd column is S (from Save)" then
      (if (buffer-modified-p current-buffer-from-the-point)
has-modified-flag-on then
           insert "*" else
           insert " ".

This is the complete logic of the patch . Correct ?

[-- Attachment #2: Type: text/html, Size: 977 bytes --]

RE: Small problem with "unmark" in *Buffer List*

[Drew Adams]

> I remember this problem repeating for many years,

No.  This regression was introduced in Emacs 24.3, which was released
on March 11, 2013 - not even one year ago.

> but today it disturbed me again , and this is why I mailed.
> In fact, the patch of the function "Buffer-menu-unmark" will look
> something like:...
> This is the complete logic of the patch . Correct ?

Diff the buff-menu.el changes from Emacs 24.2 to 24.3, and revert
the change that introduced the regression.
         

Re: Small problem with "unmark" in *Buffer List*

[Alp Aker]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

> Diff the buff-menu.el changes from Emacs 24.2 to 24.3, and revert
> the change that introduced the regression.

The problem was introduced when Buffer-menu-mode was re-written to derive
from tabulated-list-mode, so it's not a simple matter of reverting
anything.  The fix is still simple, though.  I'll push one in a few
minutes.

[-- Attachment #2: Type: text/html, Size: 405 bytes --]

bug#15761: Fwd: Small problem with "unmark" in *Buffer List*

[Alp Aker]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

Forwarding from emacs-devel in order to get a bug number.

---------- Forwarded message ----------
From: Alin Soare <as1789@gmail.com>
Date: Wed, Oct 30, 2013 at 2:55 AM
Subject: Small problem with "unmark" in *Buffer List*
To: emacs-devel@gnu.org


When I mark a buffer for saving (S marker in the 3rd column), the unmark
does not clean the flag.

 This happens because the unmark does simply so:

    (tabulated-list-set-col 0 " " t)

and the "S" marker is on the 3rd column, and it's not cleared.

Now I discovered that in fact "Unmark" command should be called "unmark the
deletion".

Info page, 19.5 Operating on Several Buffers, quote:

`u'
     Remove all flags from the current line, and move down
     (`Buffer-menu-unmark').

This is not true. Either press "g" to revert the buffer, or re-define
"Buffer-menu-unmark" to really unmark the buffers.

[-- Attachment #2: Type: text/html, Size: 1446 bytes --]

bug#15761: Fwd: Small problem with "unmark" in *Buffer List*

[Alp Aker]

[-- Attachment #1: Type: text/plain, Size: 18 bytes --]

Fixed in r114874.

[-- Attachment #2: Type: text/html, Size: 39 bytes --]