From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luciano Passuello <lucianop@litemind.com>
Subject: Bug: Archiving items with org-attach-archive-delete set to 'query'
 always asks for confirmation
Date: Fri, 10 Aug 2018 14:26:56 -0300
Message-ID: <CACqKfLeq8PE+F1yLB0YzEf4CCVv+qib5f3G0Px06WtVxqgSpcg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lucianop@litemind.com>) id 1foBCe-0007kt-43
	for emacs-orgmode@gnu.org; Fri, 10 Aug 2018 13:27:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lucianop@litemind.com>) id 1foBCZ-0006Te-62
	for emacs-orgmode@gnu.org; Fri, 10 Aug 2018 13:27:56 -0400
Received: from vps2.litemind.com ([192.159.65.166]:39142)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <lucianop@litemind.com>)
	id 1foBCZ-0005pf-0u
	for emacs-orgmode@gnu.org; Fri, 10 Aug 2018 13:27:51 -0400
Received: from mail-yw1-f46.google.com ([209.85.161.46]:33603)
	by vps2.litemind.com with esmtpsa
	(TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91)
	(envelope-from <lucianop@litemind.com>) id 1foBBs-0005qa-AK
	for emacs-orgmode@gnu.org; Fri, 10 Aug 2018 13:27:08 -0400
Received: by mail-yw1-f46.google.com with SMTP id c135-v6so9155360ywa.0
	for <emacs-orgmode@gnu.org>; Fri, 10 Aug 2018 10:27:08 -0700 (PDT)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hello,

When I set org-attach-archive-delete to query, Org is supposed to ask
me for confirmation when archiving entries with attachments. However,
I am always asked for confirmation,  regardless if the item has
attachments in the first place. This is to me clearly undesirable
behavior.

Looking at the source code for org-attach, at line 573, that's indeed
what code tells us.
https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-attach.el

My uninformed suggestion is to call org-attach-delete-all without the
force parameter, using the confirmation code already in
org-attach-delete-all.

Unfortunately, I'm not skilled enough in Elisp or knowledgeable in Org
source code to provide a reasonable patch.

Thanks!