From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Elijah G Newsgroups: gmane.emacs.devel Subject: Re: How to contribute to Emacs Windows(NT) installer? Date: Mon, 22 Apr 2024 19:45:26 -0600 Message-ID: References: <86jzksa6yz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19254"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Corwin Brust Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 23 03:46:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rz5Ei-0004o2-Gq for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Apr 2024 03:46:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rz5ED-0004YO-7k; Mon, 22 Apr 2024 21:45:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz5E5-0004W0-PG for emacs-devel@gnu.org; Mon, 22 Apr 2024 21:45:42 -0400 Original-Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rz5E4-0004c7-2h; Mon, 22 Apr 2024 21:45:41 -0400 Original-Received: by mail-qt1-x841.google.com with SMTP id d75a77b69052e-436ee76c3b8so36216191cf.1; Mon, 22 Apr 2024 18:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713836738; x=1714441538; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/rt/YKNouTydNnwZkdqhAs/snUybrdxHxgsUg6RWhE4=; b=hELPJdk+ZpXyhYDjSlSkaT4beqLH9aUendgvQiz4gLki8z19ObdEaqzg9gTkEP5ANQ r78CEtX3pEF9Aw1S/mKVkuA+w6FIs9oigaEa2P6YW3bibSi430lthNGwcB3JRvtWq7SJ O4J2108ZJESsab9AQJfzhsde8TFqU1QEocxLZbgX2nI5psgroWth9QYNQ2bTIuSnsb6W MAXfOG+HhNl3J/5JOjjRG6sn92AOf0kjKmF+68TKWcoafce+tKgASkjib7RkH1KmQ1ud SkQvMlbjGVGicQQiFJoo2evkWmLRLvbM+c2hN7OliixkOGNKSg7BjjCnCf3dmfJfOO9h NxEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713836738; x=1714441538; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/rt/YKNouTydNnwZkdqhAs/snUybrdxHxgsUg6RWhE4=; b=nkNLzApPJld/uisQaqZTWP6Qq5kSYudMVdTFsh3HzWUxCJrM5+7Cicwjugt+A46ps4 SFDTIEBzvCQkzQFe8UcqIMKXLpuiNy0Vzph1+OI2X3zP1ig8JnHQxkKJvpRGNpVEmKto QG7EuAKwc7FLH9Xgg2b5UpmDwHuKYNnUwu5XfSHdgBG1qI+xe+qy1o2Sknh2cKiELAi9 GDHr9hS0sWqImOLxNV3y1ONiGIF7ETMXGih1cdx3dCc3URPbWSUI9RMlT9uy0+0vW29E NaEgQx/aB9FQkyQuL7pWMtsq+M3ol29z2/VwX3D0j3nhyBhpoCGuUIDbBHG9+A3XpziQ NhcA== X-Forwarded-Encrypted: i=1; AJvYcCXkq9sSi98pca+Bry0UPx+bZeXgGKxHikqMskjIQ5USMubCOXacnjB+zdzuKGNNdVuV18E4vKyI+8RiW86h6/ESekP/ X-Gm-Message-State: AOJu0YwRpTRRqj24/Oo673l+QuhvtqYOtmKIHKlB0TkUvPWPWiGjB93G xxA5P4USc7bRt3fRyT0CxR0O+9qEMEz8ty9EDM4D/Codn0PCupHZQEV9RASfTjjRlQGmlF4g/LT HRrhsXYkGgFLhNDENNgEp5O3Px486BcIixsg= X-Google-Smtp-Source: AGHT+IEwV/BIjKZRsiLhmU6ZdpUN/UUS32kwZ+OfjgLIwXzICPLT84NPGY+ffATu1RnzpOCWgiOTFzuT/wKpzk588Ag= X-Received: by 2002:a05:622a:13d3:b0:437:aca0:d82a with SMTP id p19-20020a05622a13d300b00437aca0d82amr13336942qtk.67.1713836738631; Mon, 22 Apr 2024 18:45:38 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::841; envelope-from=eg642616@gmail.com; helo=mail-qt1-x841.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317992 Archived-At: On Sun, Apr 21, 2024 at 8:13=E2=80=AFPM Corwin Brust wrote: > > On Sun, Apr 21, 2024 at 7:04=E2=80=AFPM Elijah G wro= te: > > > > On Sun, Apr 21, 2024 at 4:38=E2=80=AFPM Elijah G w= rote: > > > > > > On Sun, Apr 21, 2024 at 4:00=E2=80=AFPM Corwin Brust = wrote: > > > > > > > > On Sat, Apr 20, 2024 at 1:22=E2=80=AFAM Eli Zaretskii wrote: > > > > > > > > > > > From: Elijah G > > > > > > Date: Fri, 19 Apr 2024 20:42:51 -0600 > > > > > > > > > > > > Hello, I'm interested in contributing to emacs windows installe= r such > > > > > > as providing more options and providing images/banners bitmap, = Where > > > > > > can I find information such as where to send them and which fil= es are > > > > > > needed to modify? > > > > > > > > > > I believe Corwin (CC'ed) is the person who currently takes care o= f the > > > > > Windows binaries. > > > > > > > > > > > > > Hi Elijah! > > > > > > > > The files specific to building on and for Windows port are in > > > > admin/nt/dist-build within the source tree. The NSIS installer is > > > > emacs.nsi in that folder. I would be happy to look at any patches. > > > > > > > > I have lots and lots of rather so-so code relating to making these > > > > builds, most of which I don't use when preparing release builds whi= ch > > > > I do rather manually. In any case, my local snapot "CI" build > > > > programs are here: https://git.sr.ht/~mplscorwin/emacs-local-ci > > > > > > > > Let me know how I can help most, and thanks for your interest in > > > > improving things. > > > > > > Hi Corwin, thank you for showing me the files I've tried building onl= y the > > > installer using "build-zips.sh -i" but i'm getting an error "Error > > > while loading icon from > > > "emacs-30.0.50\share\emacs\30.0.50\etc\images\icons\hicolor\scalable\= a > > > pps\emacs.ico": can't open file" can you tell me Where the share fold= er should > > > be? > > > > I think I found the error, it's because build-zips.sh was executing in = "C:\", > > i'm planning to add images/banners for the installer because the > > default is stretched and > > other stuff, i'm not sure if I should send the patch in this thread or > > create another. > > > > I think you are correct - build-zips.sh wants to be run from a folder > containing your newly built Emacs (or maybe one level up from that; > I'm not using it much at present; I run the installer directly). > > Once you have a patch ready to send please use the `report-emacs-bug' > command and attach your patch, which will open a new bug report for us > to discuss these "beautification" changes (which will be much > appreciated). I'm not sure it matters a great deal in the case of > these few files, but we most often work in terms of separate bugs for > specific finite changes, while using this list to discuss what bugs to > open and otherwise align on approaches to take when the given subject > may lead to more sweeping change, as best I understand regarding Emacs > development more generally. Thank you, I've now sent my patch to bug-gnu-emacs.