From: Jay Kamat <jaygkamat@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix ox-md remote image links export
Date: Sun, 6 Aug 2017 09:10:49 -0700 [thread overview]
Message-ID: <CACe_Yv_xKRQeS70nssODxZwDa-KM9FBig7c+iP82W1wTeRbdHw@mail.gmail.com> (raw)
In-Reply-To: <87a83df9q9.fsf@nicolasgoaziou.fr>
Hi,
> Thank you for the report and the patch. I have committed a slightly
> different change. Does it solve your issue?
Yup, this commit solves my issues, thanks! It's also a lot cleaner
than my patch :).
Thanks again,
-Jay
On Sun, Aug 6, 2017 at 12:15 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Jay Kamat <jaygkamat@gmail.com> writes:
>
>> I discovered a bug in the ox-md exporter and have created a patch to fix it:
>>
>> Previously, this image link:
>> [[https://git-scm.com/images/logo@2x.png]]
>>
>> would export to:
>> ![img](//git-scm.com/images/logo@2x.png)
>>
>> which is an invalid markdown image, and won't display properly in
>> browsers and other places.
>>
>> A workaround (which I have been using extremely heavily), is:
>> [[file:https://git-scm.com/images/logo@2x.png]]
>>
>> which exports to
>> ![img](https://git-scm.com/images/logo@2x.png)
>>
>> Which is the proper (unbroken) image link.
>>
>> I have attached a patch which fixes the first example, so it exports
>> the same link as the workaround (and is no longer broken).
>
> Thank you for the report and the patch. I have committed a slightly
> different change. Does it solve your issue?
>
>> My papers are currently being processed, but I thought I would post
>> this patch early to get feedback, since ideally I would like this bug
>> to be fixed as soon as possible :). Hopefully they'll be done before
>> the review is completed.
>
> Great! Let me know when the process is done.
>
> Regards,
>
> --
> Nicolas Goaziou
prev parent reply other threads:[~2017-08-06 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 2:43 [PATCH] Fix ox-md remote image links export Jay Kamat
2017-08-06 7:15 ` Nicolas Goaziou
2017-08-06 16:10 ` Jay Kamat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACe_Yv_xKRQeS70nssODxZwDa-KM9FBig7c+iP82W1wTeRbdHw@mail.gmail.com \
--to=jaygkamat@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.