From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Steven Degutis Newsgroups: gmane.emacs.devel Subject: Patch to ido.el Date: Fri, 5 Apr 2013 01:31:57 -0500 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b15a9976fa1c604d9973ee6 X-Trace: ger.gmane.org 1365143535 20209 80.91.229.3 (5 Apr 2013 06:32:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Apr 2013 06:32:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 05 08:32:43 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UO0CX-0003R6-TT for ged-emacs-devel@m.gmane.org; Fri, 05 Apr 2013 08:32:42 +0200 Original-Received: from localhost ([::1]:48281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO0C8-00060c-Qo for ged-emacs-devel@m.gmane.org; Fri, 05 Apr 2013 02:32:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO0Bx-0005zz-RN for emacs-devel@gnu.org; Fri, 05 Apr 2013 02:32:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UO0Br-0005Fw-0V for emacs-devel@gnu.org; Fri, 05 Apr 2013 02:32:05 -0400 Original-Received: from mail-da0-x231.google.com ([2607:f8b0:400e:c00::231]:34259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO0Bq-0005Fp-Me for emacs-devel@gnu.org; Fri, 05 Apr 2013 02:31:58 -0400 Original-Received: by mail-da0-f49.google.com with SMTP id t11so1449120daj.22 for ; Thu, 04 Apr 2013 23:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type; bh=Whxv24XxbEr79eM8ggEEj10Sn/rPWN9IXwSgNkY8cOk=; b=EAdv8fQkRnSgxQKALgL5Pd50TRh9hkACM4fLTPvIVhyWVCg5bABYHsgjf2aiYWXlEa hhpaE+6epyfei1Iby9qF/LUVFjFrXeNmK7VSWT9zBsaHYqWUVkJknaz5kd3JLpYWIqqU EuB/J3k5xqv5PTQBekiZ3tkd4xDYMGhwM0Eluc8pOZLOW445hvgO7W0nk9zLJEwevFw1 c7juoifjD2FIMA/ZDbUkNnSFv5JjVhr65T8erhwpsZlez0CCjV+SfxJhCHG35H77W226 MdTbIqag27rvGhrOE8dpZdDEWo/hoBEH/tqB75REyym9FuJzeO6S2l9P0jJ+kGjxqLtS D+RA== X-Received: by 10.66.228.105 with SMTP id sh9mr882389pac.65.1365143517633; Thu, 04 Apr 2013 23:31:57 -0700 (PDT) Original-Received: by 10.70.6.100 with HTTP; Thu, 4 Apr 2013 23:31:57 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c00::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158672 Archived-At: --047d7b15a9976fa1c604d9973ee6 Content-Type: text/plain; charset=ISO-8859-1 Disclaimer: I have absolutely no idea how this process works. This patch makes ido.el slightly more configurable. In particular, when using ido-decorations that make ido-mode display vertically (per http://emacswiki.org/emacs/InteractivelyDoThings#toc20), a pair of decorations are being used in two different places with two different meanings, even though by happenstance they look the same. This patch splits them out into two different pairs of decorations (which currently have the same value), allowing the user to customize them with greater precision. diff --git ido.el ido2.el index cda4021..dfb5b0a 100644 --- ido.el +++ ido2.el @@ -763,7 +763,7 @@ Obsolete. Set 3rd element of `ido-decorations' instead." :type '(choice string (const nil)) :group 'ido) -(defcustom ido-decorations '( "{" "}" " | " " | ..." "[" "]" " [No match]" " [Matched]" " [Not readable]" " [Too big]" " [Confirm]") +(defcustom ido-decorations '( "{" "}" " | " " | ..." "[" "]" " [No match]" " [Matched]" " [Not readable]" " [Too big]" " [Confirm]" "[" "]") "List of strings used by ido to display the alternatives in the minibuffer. There are 11 elements in this list: 1st and 2nd elements are used as brackets around the prospect list, @@ -4570,9 +4570,9 @@ For details of keybindings, see `ido-find-file'." (ido-name (car comps)))) "" ;; when there is one match, show the matching file name in full - (concat (nth 4 ido-decorations) ;; [ ... ] + (concat (nth 11 ido-decorations) ;; [ ... ] (ido-name (car comps)) - (nth 5 ido-decorations))) + (nth 12 ido-decorations))) (if (not ido-use-faces) (nth 7 ido-decorations)))) ;; [Matched] (t ;multiple matches (let* ((items (if (> ido-max-prospects 0) (1+ ido-max-prospects) 999)) So, now that I've said everything that can probably be said on the topic, how do I go about submitting this patch for review to the official emacs repo? Does this email count? Or maybe someone in here knows how to do it in like 3 seconds flat and wouldn't mind? -Steven --047d7b15a9976fa1c604d9973ee6 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Disclaimer: I have absolutely no idea how this process wor= ks.

This patch makes ido.el slightly more configur= able.

In particular, when using ido-de= corations that make ido-mode display vertically (per http://emacswiki.org/emacs/Int= eractivelyDoThings#toc20), a pair of decorations are being used in two = different places with two different meanings, even though by happenstance t= hey look the same. This patch splits them out into two different pairs of d= ecorations (which currently have the same value), allowing the user to cust= omize them with greater precision.


diff --git ido.el= ido2.el
index cda4021..dfb5b0a 100644
--- ido.el
=
+++ ido2.el
@@ -763,7 +763,7 @@ Obsolete. =A0Set 3rd element= of `ido-decorations' instead."
=A0 =A0:type '(choice string (const nil))
=A0 =A0:group = 'ido)
=A0
-(defcustom ido-decorations '( "= {" "}" " | " " | ..." "[" &quo= t;]" " [No match]" " [Matched]" " [Not readab= le]" " [Too big]" " [Confirm]")
+(defcustom ido-decorations '( "{" "}" " = | " " | ..." "[" "]" " [No match]&q= uot; " [Matched]" " [Not readable]" " [Too big]&qu= ot; " [Confirm]" "[" "]")
=A0 =A0"List of strings used by ido to display the alternatives i= n the minibuffer.
=A0There are 11 elements in this list:
=A01st and 2nd elements are used as brackets around the prospect list,
@@ -4570,9 +4570,9 @@ For details of keybindings, see `ido-find-file'.&= quot;
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 (ido-name (car comps))))
=A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 ""
=A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 ;; when there is one match, show the matching file nam= e in full
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (concat (nth 4 ido-decoratio= ns) =A0;; [ ... ]
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (conc= at (nth 11 ido-decorations) =A0;; [ ... ]
=A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (ido-name (car comps))
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (nth 5 ido-decora= tions)))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 (nth 12 ido-decorations)))
=A0 =A0 (if (not ido-use-faces) (nth 7 ido-decorations)))= ) =A0;; [Matched]
=A0 =A0(t ;multiple matches
=A0= =A0 (let* ((items (if (= > ido-max-prospects 0) (1+ ido-max-prospects) 999))



S= o, now that I've said everything that can probably be said on the topic= , how do I go about submitting this patch for review to the official emacs = repo? Does this email count? Or maybe someone in here knows how to do it in= like 3 seconds flat and wouldn't mind?

-Steven
--047d7b15a9976fa1c604d9973ee6--