From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tianxiang Xiong Newsgroups: gmane.emacs.devel Subject: Re: Proposal: font lock for `describe-variable` Date: Fri, 30 Sep 2016 00:34:12 -0700 Message-ID: References: <1474949378.32234.5.camel@gmail.com> <83shslbax3.fsf@gnu.org> <83ponpb5rv.fsf@gnu.org> <57d030e9-1f2e-bc8e-f032-6ac345798c5f@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114d72eae0ea91053db49ee7 X-Trace: blaine.gmane.org 1475220884 5898 195.159.176.226 (30 Sep 2016 07:34:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Sep 2016 07:34:44 +0000 (UTC) Cc: Eli Zaretskii , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 30 09:34:39 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpsKv-0007mt-78 for ged-emacs-devel@m.gmane.org; Fri, 30 Sep 2016 09:34:25 +0200 Original-Received: from localhost ([::1]:42355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpsKt-00027q-MV for ged-emacs-devel@m.gmane.org; Fri, 30 Sep 2016 03:34:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpsKn-00026s-8F for emacs-devel@gnu.org; Fri, 30 Sep 2016 03:34:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpsKl-0005AI-1E for emacs-devel@gnu.org; Fri, 30 Sep 2016 03:34:16 -0400 Original-Received: from mail-yw0-x233.google.com ([2607:f8b0:4002:c05::233]:34750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpsKj-00059h-4R; Fri, 30 Sep 2016 03:34:13 -0400 Original-Received: by mail-yw0-x233.google.com with SMTP id g192so63923071ywh.1; Fri, 30 Sep 2016 00:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VL9Fv210/zFpL6opVnrWS1I91kq9Mkh95CZEKeMzDFU=; b=wE3/pLDhmZok78gAxBObPYv/sGe2uEFY2IlFqcR357Z37jzK+GmY6Kup+iVt1Ow4lC FHC2LPksVRQDjtdAvcZr0vdY5M2aJcwdIdv1nUAzefR3umJZT7hgBdA/oC+SZB+uYwJU zqX5SIptFKRuRLM+OK2Z8+VGF4K0yD7jjO6r1BV28qQiCj8uCTb4SAUyBP6OHSAoujxA OMG4BUurRaf3N2NlMEqrzqOFb8c6RNLLZaUktBDao+cjrlV7GPel3wqCyKUTLZGXIPnh 5WKjK91zhz0fcPnBV4I/wjai0RG/z8cQYDmnEZ2qKD1hRHcrPEfwR1k/UkjLjybQ66ey x1XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VL9Fv210/zFpL6opVnrWS1I91kq9Mkh95CZEKeMzDFU=; b=Fdh1bEPmmBm2we9eK39MlZ6kzZnm7fi7zB4uAhJJLumbhNCQIMBLgU7T0M1ZLnEQmL KIk0I78ccsnv4h526papkdoW9tv10MObFE33HsO4gFCc7ne1WZh5bGPIOOEGvDXaiOGE lhQUPx2TrivApJpaud0XpO1Oe0a3enbQVO9r6nkoFexMyqLBo628E6orvHVX3QxwfaSd zbeqJ0FMsq3TVxVB0oYMtW7WXZQ8hlsIFerKUGz8gs0L390KcZ4+yuCl6T/TAZwpXKLv rAuQURRysvyzvLJS7yZoDcOsIP02C49znCMKpNf9NTYeB4IEYHctKx6FL/t0s6i2NC2n r1Qg== X-Gm-Message-State: AA6/9Rl8V1VsxyoUw7uh2yzPF6CWD2jpY6G9X9vz+fvJznH6NkYYFYipIjqIEZbVp4IbYEcaePdzZOjiHz/5ug== X-Received: by 10.129.71.11 with SMTP id u11mr3618240ywa.115.1475220852499; Fri, 30 Sep 2016 00:34:12 -0700 (PDT) Original-Received: by 10.129.104.67 with HTTP; Fri, 30 Sep 2016 00:34:12 -0700 (PDT) In-Reply-To: <57d030e9-1f2e-bc8e-f032-6ac345798c5f@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c05::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207907 Archived-At: --001a114d72eae0ea91053db49ee7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable OK, I'll try to remove the whitespace changes. On Tue, Sep 27, 2016 at 9:21 PM, Cl=C3=A9ment Pit--Claudel wrote: > I think Eli is pointing out that in every place where you made a > modification to the code, you also changed the whitespace. For example, > you untabified all three lines of the following chunk. > > - (setq output > - (format "This variable was introduced, or its default value > was changed, in\nversion %s of Emacs.\n" > - custom-version)) > + (setq output > + (format "This variable was introduced, or its default valu= e > was changed, in version %s of Emacs.\n" > + custom-version)) > > Cl=C3=A9ment. > > On 2016-09-27 23:45, Tianxiang Xiong wrote: > > @Eli I don't know what you mean, then. The diffs in the 0002 version ar= e > definitely not due to whitespace changes; I explicitly removed the > whitespace-only changes from 0001. > > > > There /is/ a good amount of refactoring, simply because the previous > code was very hard to follow. The new code is ~40 lines shorter and, if I > do say so myself, much clearer. > > > > I've attached the 0002 version again in case there's something wrong > with the previous one. > > > > 2016-09-27 10:40 GMT-07:00 Eli Zaretskii eliz@gnu.org>>: > > > > > From: Tianxiang Xiong tianxiang.xiong@gmail.com>> > > > Date: Tue, 27 Sep 2016 09:30:18 -0700 > > > Cc: emacs-devel@gnu.org , > monnier@iro.umontreal.ca , > > > Cl=C3=A9ment Pit--Claudel clement.pit@gmail.com>> > > > > > > Even the 0002 version? > > > > Yes. > > > > > > --001a114d72eae0ea91053db49ee7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
OK, I'll try to remove the whitespace changes.

On Tue, Sep 27, 201= 6 at 9:21 PM, Cl=C3=A9ment Pit--Claudel <clement.pit@gmail.com>= wrote:
I think Eli is pointing ou= t that in every place where you made a modification to the code, you also c= hanged the whitespace.=C2=A0 For example, you untabified all three lines of= the following chunk.

-=C2=A0 =C2=A0 =C2=A0 =C2=A0(setq output
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(format "This variabl= e was introduced, or its default value was changed, in\nversion %s of Emacs= .\n"
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0custom-version))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq output
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (format "This variab= le was introduced, or its default value was changed, in version %s of Emacs= .\n"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 custom-version))

Cl=C3=A9ment.

On 2016-09-27 23:45, Tianxiang Xiong wrote:
> @Eli I don't know what you mean, then. The diffs in the 0002 versi= on are definitely not due to whitespace changes; I explicitly removed the w= hitespace-only changes from 0001.
>
> There /is/ a good amount of refactoring, simply because the pre= vious code was very hard to follow. The new code is ~40 lines shorter and, = if I do say so myself, much clearer.
>
> I've attached the 0002 version again in case there's something= wrong with the previous one.
>
> 2016-09-27 10:40 GMT-07:00 Eli Zaretskii <eliz@gnu.org <mailto:e= liz@gnu.org>>:
>
>=C2=A0 =C2=A0 =C2=A0> From: Tianxiang Xiong <tianxiang.xiong@gmail.com <mailto:tianxiang.xiong@gmail.com>= ;>
>=C2=A0 =C2=A0 =C2=A0> Date: Tue, 27 Sep 2016 09:30:= 18 -0700
>=C2=A0 =C2=A0 =C2=A0> Cc: emacs-devel@gnu.org <mailto:emacs-devel@gnu.org>, monnier@iro.umontreal.ca <mailto:monnier@iro.umontreal.ca>,
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0Cl=C3=A9ment Pit--Cl= audel <clement.pit@gmail.com <mailto:clement.pit@gmail.com= >>
>=C2=A0 =C2=A0 =C2=A0>
>=C2=A0 =C2=A0 =C2=A0> Even the 0002 version?
>
>=C2=A0 =C2=A0 =C2=A0Yes.
>
>


--001a114d72eae0ea91053db49ee7--