From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: David Hull Newsgroups: gmane.emacs.bugs Subject: bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms Date: Tue, 25 Jun 2019 10:35:37 -0700 Message-ID: References: <83d1htdwgo.fsf@gnu.org> <838tsgd912.fsf@gnu.org> <83k1d9linv.fsf@gnu.org> <83h88dlgof.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000008de05058c295ce6" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="23065"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , 24960@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 19:36:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfpMX-0005qS-UC for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 19:36:10 +0200 Original-Received: from localhost ([::1]:34290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfpMW-0001MI-Ul for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 13:36:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35574) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfpMR-0001M2-Gt for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:36:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfpMQ-0006F0-Et for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48164) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfpMQ-0006Er-BW for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfpMQ-0001hD-6x for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 13:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Hull Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24960 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 24960-submit@debbugs.gnu.org id=B24960.15614841576501 (code B ref 24960); Tue, 25 Jun 2019 17:36:02 +0000 Original-Received: (at 24960) by debbugs.gnu.org; 25 Jun 2019 17:35:57 +0000 Original-Received: from localhost ([127.0.0.1]:33474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfpML-0001gm-Bm for submit@debbugs.gnu.org; Tue, 25 Jun 2019 13:35:57 -0400 Original-Received: from mail-lf1-f52.google.com ([209.85.167.52]:38089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfpMJ-0001gX-9E for 24960@debbugs.gnu.org; Tue, 25 Jun 2019 13:35:56 -0400 Original-Received: by mail-lf1-f52.google.com with SMTP id b11so13277142lfa.5 for <24960@debbugs.gnu.org>; Tue, 25 Jun 2019 10:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openx.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=opnO+vaqtLBW+1vxEnslM865uoA8KXQElFfIfb2blBY=; b=LhWvXKUWhEoT8MsumwI6okfiRZincPhJcSyDrwD23rRLukWTI5tlMH1IGk3j5uioM0 89Vt4jhuyqXCkvqISiWuey9IuUgWoJUDAmAaBR39eRFvYbE3i5mued+ZfpDTr4g6dUiw ec3KyykwbNti7T9xJdZlVTt007KbY9apQe2zQAZDO8hpHOEqj6XJTS5eP/8Fcfu1UDno PL0T4fSVIm1zIiDU3MNWTPxZNIDgrLou2795d49u7Xd2IyKvXD8cLSa7QxGz69AQfPW4 08YQ9PXVzlrs1P5vhfHVcr7xC5LkAWlFzG9zz3WjPj8TorIeXO01iMYJvZWDg1VG9WsM zlSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=opnO+vaqtLBW+1vxEnslM865uoA8KXQElFfIfb2blBY=; b=kuuNm8E+JhAxVYgMbKI9oRGvHHtYUT3cK8DyrsaG8GYzU4abkKAMFnNAk1Nrb6w3GD KdEZmxJgQMs94u5brmhFn+Fm5pURlVREWBCGpmt1c06p2Y6DuNvnfLLaFrvl5a7TBtAi 9ByFH02EMOVJdac/cAe8ZQmAh7xfvCQ+Nda4P660K3Py57ghU8VlKsWpqC63kVX6gkVN HbulWWkxVkyqNZlrspcmv8RhTsAPEdeem0ihs6CPcxPXfvEihqTFmDT3r1FL2LnjvxJ5 pyhyNCZpXw4wDHOWwaJkMz+xtzEqhTYk/Dmh7TY8N1Wuj8/SjCO0EddjLzSeSJPj8Kzb oASw== X-Gm-Message-State: APjAAAUTsSAWEbe5tG9klghXv8bG10TrS4ZTCxijcXc57rNDqwj7Aec7 JQMGNBbWHbt61BCS9XQy/rn0zfob8EcD9DGKtyPEdw== X-Google-Smtp-Source: APXvYqypiN1y/FqvAu2/R32ICNsBLcZkVaEFmK5O4PlawqJEsZAX3GzYxWXsL/TboQRsp3Au21401TPhSytmjK/nGxE= X-Received: by 2002:a19:f601:: with SMTP id x1mr79761567lfe.182.1561484149178; Tue, 25 Jun 2019 10:35:49 -0700 (PDT) In-Reply-To: <83h88dlgof.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161407 Archived-At: --00000000000008de05058c295ce6 Content-Type: text/plain; charset="UTF-8" Yes, I agree that my patch should have had the braces you're suggesting. Thanks for the fix. On Tue, Jun 25, 2019 at 10:26 AM Eli Zaretskii wrote: > > From: Lars Ingebrigtsen > > Cc: david.hull@openx.com, 24960@debbugs.gnu.org > > Date: Tue, 25 Jun 2019 19:13:55 +0200 > > > > if (len > 0) > > - make_tag (cp, len, true, s, cp + len - s, lineno, linecharno); > > + /* If the name is quoted, the quotes are not part of the name. > */ > > + if (len > 2 && cp[0] == '\'' && cp[len - 1] == '\'') > > + { > > + cp++; > > + len -= 2; > > + } > > + make_tag (cp, len, true, s, pos, lineno, linecharno); > > > > I think what was meant was that the make_tag should be in that "if" > > branch, so I slapped a brace pair around the new lines. > > Yes, thanks. > -- David Hull --00000000000008de05058c295ce6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, I agree that my patch should have had the braces you&= #39;re suggesting. Thanks for the fix.

On Tue, Jun 25, 2019 at 10:26 AM = Eli Zaretskii <eliz@gnu.org> wrot= e:
> From: La= rs Ingebrigtsen <lar= si@gnus.org>
> Cc: david.hu= ll@openx.com,=C2=A0 24960@debbugs.gnu.org
> Date: Tue, 25 Jun 2019 19:13:55 +0200
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (len > 0)
> -=C2=A0 =C2=A0 =C2=A0make_tag (cp, len, true, s, cp + len - s, lineno,= linecharno);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* If the name is quoted, the quotes are = not part of the name. */
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (len > 2 && cp[0] =3D=3D &#= 39;\'' && cp[len - 1] =3D=3D '\'')
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cp++;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 len -=3D 2;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
> +=C2=A0 =C2=A0 =C2=A0make_tag (cp, len, true, s, pos, lineno, linechar= no);
>
> I think what was meant was that the make_tag should be in that "i= f"
> branch, so I slapped a brace pair around the new lines.

Yes, thanks.


--
David Hull
--00000000000008de05058c295ce6--