all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: dalanicolai <dalanicolai@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 54688@debbugs.gnu.org
Subject: bug#54688: 29.0.50; Sliced image in margin looks bad
Date: Sun, 3 Apr 2022 15:09:59 +0200	[thread overview]
Message-ID: <CACJP=3maME+QWWN7DQKAEe0801XLrJjXB1VMraKkufxdp5gvgg@mail.gmail.com> (raw)
In-Reply-To: <CACJP=3nXLTvD-tQr9a4VH-QU847F3hxg3jkmeAJuB=McijjX5A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2949 bytes --]

In the first sentence, I mean text of the same height as the image height.
When I say 'current behavior' I mean that the 'line-pixel-height' when
combining
images and text of equal height on a single line, is larger than the
text/image height.

On Sun, 3 Apr 2022 at 15:05, dalanicolai <dalanicolai@gmail.com> wrote:

> Does this mean the problem is solved, and we can close this bug?
>
>
> I am not sure. It depends on what is the intended behavior. I would say it
> is desirable
> if inserting text after an image, of height equal to the text height,
> would not increase
> the `line-pixel-height`. The elisp manual
> <https://www.gnu.org/software/emacs/manual/html_node/elisp/Image-Descriptors.html>
> mentions that the default value for :ascent is
> 50, in which case the `line-pixel-height` is larger than the both the
> 'image height' and
> the 'text height'. So maybe the default value of :ascent should be 80, in
> which case
> the 'line-pixel-height' 'remains' equal to the image height and text
> height.
>
> However, there might be various arguments for the current default value of
> 50 (and its
> behavior of increasing the 'line-pixel'height' when combining images with
> text on a
> single line).
>
> > I would think that this :ascent of 80, behaves how :ascent 50 (the
>> default)
>> > is supposed to behave?
>>
>> I don't think I understand the question.
>>
>
> I mean that I would expect the default behavior to be that, when combining
> images and
> text of equal height on a single line, the 'line-pixel-height' would also
> be/stay of equal
> height.
> But as mentioned before, there might be various arguments for the current
> behavior,
> however (as a layman) I am not aware of any.
>
> If the current behavior is the desired behavior, then indeed this issue
> can be closed.
>
> On Sun, 3 Apr 2022 at 14:03, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > From: dalanicolai <dalanicolai@gmail.com>
>> > Date: Sun, 3 Apr 2022 13:03:27 +0200
>> > Cc: 54688@debbugs.gnu.org
>> >
>> > Playing around with :ascent, makes possible to keep the
>> line-pixel-height fixed.
>> >
>> > So in the following I simply use `insert-image`. Without the :ascent,
>> the
>> > 'line-pixel-height' increases when inserting another character. With the
>> > :ascent it is possible to reduce this 'increase'. For me the increase
>> is 0
>> > when I use an ascent value of 80.
>> > (below the used code)
>> >
>> > (with-current-buffer (get-buffer-create "test")
>> >   (setq left-margin-width 5)
>> >   (insert-image (svg-image (let* ((ph (line-pixel-height))
>> >                                   (size ph)
>> >                                   (svg (svg-create size size)))
>> >                              (svg-circle svg ph ph ph :fill "red")
>> >                              svg)
>> >                            :ascent 80))
>> >   (switch-to-buffer (current-buffer)))
>>
>> Does this mean the problem is solved, and we can close this bug?
>>
>

[-- Attachment #2: Type: text/html, Size: 4449 bytes --]

      reply	other threads:[~2022-04-03 13:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03  6:50 bug#54688: 29.0.50; Sliced image in margin looks bad dalanicolai
2022-04-03  8:57 ` Eli Zaretskii
2022-04-03 10:33   ` dalanicolai
2022-04-03 10:54     ` Eli Zaretskii
2022-04-03 11:03       ` dalanicolai
2022-04-03 11:04         ` dalanicolai
2022-04-03 12:02           ` Eli Zaretskii
2022-04-03 12:03         ` Eli Zaretskii
2022-04-03 13:05           ` dalanicolai
2022-04-03 13:09             ` dalanicolai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACJP=3maME+QWWN7DQKAEe0801XLrJjXB1VMraKkufxdp5gvgg@mail.gmail.com' \
    --to=dalanicolai@gmail.com \
    --cc=54688@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.