From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dalanicolai Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: toc-mode Date: Wed, 21 Sep 2022 09:18:36 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007bfae605e92ac1fe" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28371"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 21 09:29:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oauAW-00079o-GQ for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Sep 2022 09:29:16 +0200 Original-Received: from localhost ([::1]:36262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oauAV-0000mS-A0 for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Sep 2022 03:29:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oau0S-0004nM-4C for emacs-devel@gnu.org; Wed, 21 Sep 2022 03:18:53 -0400 Original-Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:45054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oau0P-00038M-Ii for emacs-devel@gnu.org; Wed, 21 Sep 2022 03:18:51 -0400 Original-Received: by mail-ej1-x62b.google.com with SMTP id r18so11477438eja.11 for ; Wed, 21 Sep 2022 00:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=lwBPiKxU/zYTIWX1+nIgNCvfBub+uSL6PF5sK6xNpBA=; b=EbfXBUoy2GB4mZ7yfwthBflOj0SAIzQTip8z+x1arOHSxOR8PWeIYvtcNk1QLt/wS5 XWZ/mK9XMm9SJ0vTvfEXi9tJkkC9PAujtQngAdnbG16RqDkb7o0lJPO9mIRN1IGtey5j +lmwxZb4wCB5zGUbqQAMK91LeILndF7MxycWyStcG9SO/wLeY9/DYiCd/W4ZQNCCUh6F nwVOsp6FsytcMNCCWxZsjyTWzE1Bwno9IWzA4/wUKnLiPUwa1veXoXewERG4WNP84mgE 8F6ww4NvV/cpEujsYyWgcIKo7TyS3uOOsh2BdTaQ52Ah1h+1CW7QeYgB8rKGqXior7nJ OZMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=lwBPiKxU/zYTIWX1+nIgNCvfBub+uSL6PF5sK6xNpBA=; b=xiwSMbe7wsHIMl+2zDZaKKFPw/Uc5tonCGt7X+0BSYxfqboc/pbKBwND4JM9sx1lTt t32wd3odCyBCgUUaCQbxT8bNdBHwCfXNIWen2hfinC+Ots4UgvSjmgqfQJgyJghmd2yC 8/CJULmkukFPSx5Os0qN22Qn1nwGIo6NGZxV3xwd4c0KTZrH2z0mR24lApVgACijTn/u r6Ab1vluSgx/oh1rd0NrytLH2M4dNXpgVNAgq+SvGqOGICF+PO/BD4LVvIEpr5rHRhvy ZEleaDPeFItjY/Nbe+xguPENe8Z8awYFvndDpxltlDXQYxhtUv34qn7FZlPqODGSZQXU umeA== X-Gm-Message-State: ACrzQf1WOfIC9cNSDWkqq9q3eEvmyrjDL13bOe9G8vlklKngk2KATQpn q9Pt58Gg6PYjUIKYBat3piKTVlTbPuAjjWP2aJE= X-Google-Smtp-Source: AMsMyM53bJihAh+n0zD1WQFIyokEtp0wfI3HZdwG0PeSiqP3a+MSYCCcGv/aV+dCxeOXi2ITCG0v1hL0TUygV0tJM3c= X-Received: by 2002:a17:907:d94:b0:77a:bf:9c93 with SMTP id go20-20020a1709070d9400b0077a00bf9c93mr19628690ejc.147.1663744727577; Wed, 21 Sep 2022 00:18:47 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=dalanicolai@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295863 Archived-At: --0000000000007bfae605e92ac1fe Content-Type: text/plain; charset="UTF-8" It seems that somehow I did not receive the answer by Jean, but the feedback about the name sounds useful. I will think about and rename the package. Actually, I adjusted that copyright line already and got rid of the compiler warnings, but indeed I see now that I did not push those 'fixes' yet. On Wed, 21 Sept 2022 at 00:03, Stefan Monnier wrote: > > This package has been for a while on MELPA now, but it would be nice if > it > > could be moved to ELPA. The source can be found at > > https://github.com/dalanicolai/toc-mode. > > > > I would like to mention that the PDF functionalities largely depend on > > pdf-tools, which is not on ELPA of course (doc-view unfortunately does > > not provide the right features). I am not sure if that somehow is > > a problem. > > Since pdf-tools is in NonGNU ELPA, this is not a problem, no. > > > The package description is: > > > > Create, cleanup, add and manage Table Of Contents (TOC) of pdf and djvu > > documents with Emacs > > Sounds handy, thanks. FWIW, I tend to agree with Jean that the name > suggests its purpose is more general (more like a kind of speedbar/imenu > maybe). Furthermore the "-mode" part of the name suggests it's a major > mode to edit some standard "toc" files rather than an actual tool to > extract things for non-toc files and then edit those files. > > So I'd support a renaming (in case you're out of ideas, maybe > "toc-edit/edit-doc-toc", tho maybe "create-doc-toc" is more precise > since it doesn't seem to care very much about editing an existing toc), > but I don't have a strong opinion about it. > > Once you've made up your mind about the package name, let me know so > I can add it to `elpa.git`. > > > ready for ELPA (although I guess it is already ready for publishing on > > ELPA). > > Indeed, except for the copyright line which needs to be adjusted. > > The patch below does that along with the obligatory cosmetic tweaks. > I also include the remaining compilation warnings. > > > Stefan > --0000000000007bfae605e92ac1fe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It seems that somehow I did not receive the answer by= Jean, but the
feedback about the name sounds useful. I will thin= k about and rename
the package.

Actually= , I adjusted that copyright line already and got rid of the compiler
<= div>warnings, but indeed I see now that I did not push those 'fixes'= ; yet.

On Wed, 21 Sept 2022 at 00:03, Stefan Monnier <monnier@iro.umontreal.ca> wrote= :
> This pack= age has been for a while on MELPA now, but it would be nice if it
> could be moved to ELPA. The source can be found at
> https://github.com/dalanicolai/toc-mode.
>
> I would like to mention that the PDF functionalities largely depend on=
> pdf-tools, which is not on ELPA of course (doc-view unfortunately does=
> not provide the right features). I am not sure if that somehow is
> a problem.

Since pdf-tools is in NonGNU ELPA, this is not a problem, no.

> The package description is:
>
> Create, cleanup, add and manage Table Of Contents (TOC) of pdf and djv= u
> documents with Emacs

Sounds handy, thanks.=C2=A0 FWIW, I tend to agree with Jean that the name suggests its purpose is more general (more like a kind of speedbar/imenu maybe).=C2=A0 Furthermore the "-mode" part of the name suggests i= t's a major
mode to edit some standard "toc" files rather than an actual tool= to
extract things for non-toc files and then edit those files.

So I'd support a renaming (in case you're out of ideas, maybe
"toc-edit/edit-doc-toc", tho maybe "create-doc-toc" is = more precise
since it doesn't seem to care very much about editing an existing toc),=
but I don't have a strong opinion about it.

Once you've made up your mind about the package name, let me know so I can add it to `elpa.git`.

> ready for ELPA (although I guess it is already ready for publishing on=
> ELPA).

Indeed, except for the copyright line which needs to be adjusted.

The patch below does that along with the obligatory cosmetic tweaks.
I also include the remaining compilation warnings.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan
--0000000000007bfae605e92ac1fe--