From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: yyoncho Newsgroups: gmane.emacs.bugs Subject: bug#38561: 27.0.50; Feature request: expose buffer size setting for process filters Date: Sat, 21 Dec 2019 21:30:15 +0200 Message-ID: References: <83woaqysf2.fsf@gnu.org> <83mublzi2e.fsf@gnu.org> <83h81tzgca.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008d5a24059a3bd33b" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="230800"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38561@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 21 20:31:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iikT4-000xtd-4X for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2019 20:31:14 +0100 Original-Received: from localhost ([::1]:41766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iikT1-0007aQ-U9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2019 14:31:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47221) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iikSu-0007a8-0I for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 14:31:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iikSs-0006pH-J1 for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 14:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iikSs-0006n7-9x for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 14:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iikSs-0002Hs-2h for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 14:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: yyoncho Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2019 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38561 X-GNU-PR-Package: emacs Original-Received: via spool by 38561-submit@debbugs.gnu.org id=B38561.15769566348755 (code B ref 38561); Sat, 21 Dec 2019 19:31:02 +0000 Original-Received: (at 38561) by debbugs.gnu.org; 21 Dec 2019 19:30:34 +0000 Original-Received: from localhost ([127.0.0.1]:48791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iikSQ-0002H9-GU for submit@debbugs.gnu.org; Sat, 21 Dec 2019 14:30:34 -0500 Original-Received: from mail-lj1-f177.google.com ([209.85.208.177]:45156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iikSO-0002Gw-J0 for 38561@debbugs.gnu.org; Sat, 21 Dec 2019 14:30:33 -0500 Original-Received: by mail-lj1-f177.google.com with SMTP id j26so13521909ljc.12 for <38561@debbugs.gnu.org>; Sat, 21 Dec 2019 11:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5xoLzSSsEBLnDSnjY7EtbspD+ekxE0cUOy8uVALskxk=; b=kLydkdf7TL+qnjy9n6nwqazY5IohXz7p1Qj3Ok/FFk4qMY/5Y6wDhKhVYgBDneSJXL wOINU5WiW7tPSHb9/L1p2WVB4rHzQR6Is0B41zi9wjU46ffbO97f1uvLDaGZzftjUc8W JHMcgarZ+M1JuB8pSI8yTfEM7Gzwg47zIPimfmve1kSp7ulvL0+PqNSNYa7VW70bXuVV F/EwvltycW7glNlRYx1gJJEj4rlnoUKlZ+em58rjMDTikWXIb+xmMe5gLcEQCMRltBrk gd8I27BjMDj4/qNVFVOeVAX4XTS68yUpjvZ6EePWYl8FF/16QL5zHfZmcRU+icdwmPDG HAkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5xoLzSSsEBLnDSnjY7EtbspD+ekxE0cUOy8uVALskxk=; b=URDfCUmHByciKGH34rTvTIHk9qr7qB9hpmmZ4ODmP21443N+G4fJcXsz0+5W3GNV6z SsDTHlbi/6/CTJzmvLTNScdQiPaUedA7bluslH0+v1b7jcbDoqc6j73+4OACZ/4UNuHc EOwIMQAC7UZIjQ4tJvVu4GLCKedlr+iqHXpmO8Dw4IzjVQt2jwcBHLBzHYgsIQuEjhvi yA2qW7VLZTm268zXfbO2S7UMtdZLHyCzg2Nn73XyapgUUh128WIgN+uElYfCYvbCe+SS Y/9uOg8YJYUe/LpQO/YXvBDH8q0ZDitfmvl7vWz5FM/SL60Qz2mm3lYFgrZUHWKc7E6C CgzQ== X-Gm-Message-State: APjAAAUXgExtbXiMHYwF4jzifmbunrUO35dALW/d5cXwpASZ5v/td8VZ oGRA9Z/zdu9ALChqiLmYjfdO7kTmJCIA6BK3QFE= X-Google-Smtp-Source: APXvYqyBtIvMNIkUCLafNZdoG2q5VauSM/gWYMLJ07iuL98M/XC0uz+fZcSsIX5TfTtkzSLjB7r173ViU3FWkC359OE= X-Received: by 2002:a2e:2283:: with SMTP id i125mr13695132lji.244.1576956626556; Sat, 21 Dec 2019 11:30:26 -0800 (PST) In-Reply-To: <83h81tzgca.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173611 Archived-At: --0000000000008d5a24059a3bd33b Content-Type: text/plain; charset="UTF-8" I think that it will be fairly common (e. g. everyone using lsp-mode) will have to use that setting. I am afraid that even if I choose option 1 the distributions like spacemacs/doom will set it globally(because they are allowed to be opinionated). When you create a process you provide a bunch of settings(e. g. :connection-type, :filter, :no-query). Can we make another property for the read max size? Thanks, Ivan On Sat, Dec 21, 2019 at 8:25 PM Eli Zaretskii wrote: > > > 1. Document it in lsp-mode's readme > > > 2. Override it with a setting in lsp-mode with a bigger value. > > > > > > Both have clear advantages and disadvantages. Can you advise? > > > > I'd suggest the former, because if lsp-mode sets the value, it will > > affect the entire Emacs session. > > > > If lsp-mode uses accept-process-output, it could bind the variable > > inside the form which calls accept-process-output. > > Btw, my assumption was that the value will have to be changed from > default only in very rare situations. If this is not the case, we > might indeed want that to be a parameter at process creation time (I > don't think we have process-local variables, do we?). > --0000000000008d5a24059a3bd33b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think that it will be fairly common (e. g. everyone=C2= =A0using lsp-mode)
will have to use that setting. I am afraid=C2=A0that= even if I choose option 1
the distributions like spacemacs/doom = will set it globally(because they
are allowed to be opinionated).=

When you create a process you provide a bunch of se= ttings(e. g.=C2=A0
:connection-type, :filter, :no-query). Can we = make another property for=C2=A0
the read max size?=C2=A0

Thanks,
Ivan

On Sat, Dec 2= 1, 2019 at 8:25 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > 1. Document it in lsp-mode's readme <= br> > > 2. Override it with a setting in lsp-mode with a bigger value. > >
> > Both have clear advantages and disadvantages. Can you advise? >
> I'd suggest the former, because if lsp-mode sets the value, it wil= l
> affect the entire Emacs session.
>
> If lsp-mode uses accept-process-output, it could bind the variable
> inside the form which calls accept-process-output.

Btw, my assumption was that the value will have to be changed from
default only in very rare situations.=C2=A0 If this is not the case, we
might indeed want that to be a parameter at process creation time (I
don't think we have process-local variables, do we?).
--0000000000008d5a24059a3bd33b--