From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: yyoncho Newsgroups: gmane.emacs.bugs Subject: bug#38561: 27.0.50; Feature request: expose buffer size setting for process filters Date: Sat, 21 Dec 2019 16:43:21 +0200 Message-ID: References: <83woaqysf2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000089d5b5059a37d12f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="209169"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38561@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 21 15:53:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iig8M-000sJS-VS for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2019 15:53:35 +0100 Original-Received: from localhost ([::1]:39812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iig8L-0002bB-55 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2019 09:53:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52734) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iifz9-0006sT-Li for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 09:44:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iifz8-0006E0-9D for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 09:44:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41705) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iifz8-0006Cc-28 for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 09:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iifz7-0001oJ-UN for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2019 09:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: yyoncho Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2019 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38561 X-GNU-PR-Package: emacs Original-Received: via spool by 38561-submit@debbugs.gnu.org id=B38561.15769394226927 (code B ref 38561); Sat, 21 Dec 2019 14:44:01 +0000 Original-Received: (at 38561) by debbugs.gnu.org; 21 Dec 2019 14:43:42 +0000 Original-Received: from localhost ([127.0.0.1]:47678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iifyo-0001nf-4N for submit@debbugs.gnu.org; Sat, 21 Dec 2019 09:43:42 -0500 Original-Received: from mail-lj1-f180.google.com ([209.85.208.180]:46964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iifyl-0001nR-07 for 38561@debbugs.gnu.org; Sat, 21 Dec 2019 09:43:40 -0500 Original-Received: by mail-lj1-f180.google.com with SMTP id m26so10507574ljc.13 for <38561@debbugs.gnu.org>; Sat, 21 Dec 2019 06:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EvtFDcvCiPZKuR2itdydf+l6y5lEZPWWsQQtT41Q9f8=; b=QO2W4TKDlxVHZtG1U/eyGBetrdJffez0Jb714qH5U7vSKE9azDMlYocZF6JkbcGzq6 FNKn1pOD6YyTw5TbXcd5poxkOBP8OSxdGqpo7Nn0gdxaOedAzWmmX8dWT7JT7AwTntg6 llaqtEIu7oepihJvwouuV9vd7pCKjPPCdRgJNPSp/1+5aMdJYWMbX50XrjsDoKrEOY8E epSOruv1OdrHqhfth2bPEBH+iTQNpIqtvitNG91P+wsLjnmYLK0e1rktZkDiIXN84juR HVd5WWXh9AThSA78gilQueeyhSZxEa44lyFcFAJNofpeeYJ4vevrTvzdI1i9FcmszpnM JXgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EvtFDcvCiPZKuR2itdydf+l6y5lEZPWWsQQtT41Q9f8=; b=hoBewd/J2/dmSiw7muSuCRfgBSBNXAjjftbRFA2J9RjMeHbODyZlJkAqoeOJ60QUJ6 zebfYm1tCJBTYzuiEMLofVhjXBNeoNcn5UaFVzxNtjgOZcjfod0oimMr4TktgALmKjei v+h1bYz/5AkHjWGmDPs/n9gxEP/bY2EK3f0oa9ALmFhwvKstvUH+cuAh/+NpOHWTmnDg EsL+DZiRf3XsrQUBSzOQVBu4kGZA4AF+hwN3XLyosGmASbil4gHZdxfdfKhF4JWm1OVB sNOcYjz8AzoI4E2c1izS7mvDimNNf/lWr+3EjQcINIs9zlMMa2TGgRYXpOXTgnXgPwA/ Dh/g== X-Gm-Message-State: APjAAAX6TQ0XMWD1SXozLrL356KW8UaMZ/CcQdAtS3D/pY6OdhF9gfZb TptvDXz59+PR2eDJSsH0S0XmUBuEOz5zZwEaEjo= X-Google-Smtp-Source: APXvYqxYhYanZ8Un5Bs/Wkmo+kS1h/+YSBQtDI+/6LP45KVAr1lWFjEVq8l+0EJT7JChyDQuQWiZ4AQTUjYZsr38ZLQ= X-Received: by 2002:a2e:9a11:: with SMTP id o17mr13063775lji.256.1576939412901; Sat, 21 Dec 2019 06:43:32 -0800 (PST) In-Reply-To: <83woaqysf2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173604 Archived-At: --00000000000089d5b5059a37d12f Content-Type: text/plain; charset="UTF-8" Hi Eli, Thank you for taking care of this! I can confirm that changing the new variable value is yielding the same results. I have a question on how am I supposed to use the new setting. Is it possible to set it per process? I tried (with-current-buffer (process-buffer proc) (setq-local read-process-output-max (* 1024 1024))) but it does not work. If it is not possible to use it per process then I think that I have 2 options: 1. Document it in lsp-mode's readme 2. Override it with a setting in lsp-mode with a bigger value. Both have clear advantages and disadvantages. Can you advise? Thanks, Ivan On Sat, Dec 21, 2019 at 10:49 AM Eli Zaretskii wrote: > > From: yyoncho > > Date: Tue, 10 Dec 2019 19:25:17 +0200 > > > > Adding some performance numbers from lsp-mode project. > > > > (with-current-buffer "DemoApplication.java" > > (benchmark-run 10 (lsp-request "workspace/symbol" (list :query "S")))) > > > > ;; Emacs from master > > => (4.203047857 0 0.0) > > > > ;; tested with emacs compiled with 1mb buffer. > > => (3.132925793 0 0.0) > > Your wish has been granted, see the new variable > read-process-output-max. > > I'd appreciate testing this with your use cases. > --00000000000089d5b5059a37d12f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Eli,

Thank you for taking care of th= is!

I can confirm that changing=C2=A0the new varia= ble value is yielding the same results.

I have a q= uestion=C2=A0on how am I supposed to use the new setting. Is it possible to= set it per process?

I tried=C2=A0

<= /div>
(with-current-buffer (process-buffer proc)
=C2=A0 =C2=A0(set= q-local read-process-output-max (* 1024 1024)))

but it d= oes not work. If it is not possible to use it per process then I think that= I have 2 options:

1. Document it in lsp-mode'= s readme=C2=A0
2. Override it with a setting in lsp-mode with a b= igger value.

Both have clear advantages and disadv= antages. Can you advise?=C2=A0

Thanks,
Ivan

On Sat, Dec 21, 2019 at 10:49 AM Eli Zaretskii <= eliz@gnu.org> wrot= e:
> From: yy= oncho <yyoncho@gm= ail.com>
> Date: Tue, 10 Dec 2019 19:25:17 +0200
>
> Adding some performance numbers from lsp-mode project.
>
> (with-current-buffer "DemoApplication.java"
>=C2=A0 =C2=A0(benchmark-run 10 (lsp-request "workspace/symbol"= ; (list :query "S"))))
>
> ;; Emacs from master
> =3D> (4.203047857 0 0.0)
>
> ;; tested with emacs compiled with 1mb buffer.
> =3D> (3.132925793 0 0.0)

Your wish has been granted, see the new variable
read-process-output-max.

I'd appreciate testing this with your use cases.
--00000000000089d5b5059a37d12f--