all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: yyoncho <yyoncho@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38561@debbugs.gnu.org
Subject: bug#38561: 27.0.50; Feature request: expose buffer size setting for process filters
Date: Sat, 21 Dec 2019 16:43:21 +0200	[thread overview]
Message-ID: <CACCVLQVcYLZ=LjbhzFd2bUceO8C7h5G_QM3dOdbgvzTz3HdjMg@mail.gmail.com> (raw)
In-Reply-To: <83woaqysf2.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

Hi Eli,

Thank you for taking care of this!

I can confirm that changing the new variable value is yielding the same
results.

I have a question on how am I supposed to use the new setting. Is it
possible to set it per process?

I tried

(with-current-buffer (process-buffer proc)
   (setq-local read-process-output-max (* 1024 1024)))

but it does not work. If it is not possible to use it per process then I
think that I have 2 options:

1. Document it in lsp-mode's readme
2. Override it with a setting in lsp-mode with a bigger value.

Both have clear advantages and disadvantages. Can you advise?

Thanks,
Ivan

On Sat, Dec 21, 2019 at 10:49 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: yyoncho <yyoncho@gmail.com>
> > Date: Tue, 10 Dec 2019 19:25:17 +0200
> >
> > Adding some performance numbers from lsp-mode project.
> >
> > (with-current-buffer "DemoApplication.java"
> >   (benchmark-run 10 (lsp-request "workspace/symbol" (list :query "S"))))
> >
> > ;; Emacs from master
> > => (4.203047857 0 0.0)
> >
> > ;; tested with emacs compiled with 1mb buffer.
> > => (3.132925793 0 0.0)
>
> Your wish has been granted, see the new variable
> read-process-output-max.
>
> I'd appreciate testing this with your use cases.
>

[-- Attachment #2: Type: text/html, Size: 1984 bytes --]

  reply	other threads:[~2019-12-21 14:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 17:17 bug#38561: 27.0.50; Feature request: expose buffer size setting for process filters yyoncho
2019-12-10 17:25 ` yyoncho
2019-12-21  8:49   ` Eli Zaretskii
2019-12-21 14:43     ` yyoncho [this message]
2019-12-21 17:47       ` Eli Zaretskii
2019-12-21 18:25         ` Eli Zaretskii
2019-12-21 19:30           ` yyoncho
2019-12-21 19:36             ` Eli Zaretskii
2019-12-21 19:59               ` yyoncho
2019-12-22 14:23           ` Dmitry Gutov
2019-12-22 17:25             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACCVLQVcYLZ=LjbhzFd2bUceO8C7h5G_QM3dOdbgvzTz3HdjMg@mail.gmail.com' \
    --to=yyoncho@gmail.com \
    --cc=38561@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.