all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [RFC] normalize kill-region in calc
@ 2015-07-04 23:28 Daniel Colascione
  2015-07-05 10:41 ` Wolfgang Jenkner
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Colascione @ 2015-07-04 23:28 UTC (permalink / raw)
  To: Emacs-devel

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

Right now, calc binds M-w to a special version of copy-region-as-kill
than copies the entire calc value (along with the calc stack prefix)
instead of just the highlighted region. This behavior is inconsistent
with other modes. Can we apply something like this patch? I'll fix the
documentation if we apply it.

diff --git a/lisp/calc/calc-ext.el b/lisp/calc/calc-ext.el
index 67d0c27..baf4c3b 100644
--- a/lisp/calc/calc-ext.el
+++ b/lisp/calc/calc-ext.el
@@ -133,8 +133,8 @@
   (define-key calc-mode-map "\C-k" 'calc-kill)
   (define-key calc-mode-map "\M-k" 'calc-copy-as-kill)
   (define-key calc-mode-map "\C-w" 'calc-kill-region)
-  (define-key calc-mode-map "\M-w" 'calc-copy-region-as-kill)
-  (define-key calc-mode-map "\M-\C-w" 'kill-ring-save)
+  (define-key calc-mode-map "\M-w" 'kill-ring-save)
+  (define-key calc-mode-map "\M-\C-w" 'calc-copy-region-as-kill)
   (define-key calc-mode-map "\M-\C-m" 'calc-last-args)

   (define-key calc-mode-map "a" nil)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RFC] normalize kill-region in calc
  2015-07-04 23:28 [RFC] normalize kill-region in calc Daniel Colascione
@ 2015-07-05 10:41 ` Wolfgang Jenkner
  2015-07-05 16:14   ` Jay Belanger
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Jenkner @ 2015-07-05 10:41 UTC (permalink / raw)
  To: Daniel Colascione; +Cc: Emacs-devel

On Sat, Jul 04 2015, Daniel Colascione wrote:

> Right now, calc binds M-w to a special version of copy-region-as-kill
> than copies the entire calc value (along with the calc stack prefix)
> instead of just the highlighted region. This behavior is inconsistent
> with other modes. Can we apply something like this patch? I'll fix the
> documentation if we apply it.

Calc has a maintainer (please see admin/MAINTAINERS).



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC] normalize kill-region in calc
  2015-07-05 10:41 ` Wolfgang Jenkner
@ 2015-07-05 16:14   ` Jay Belanger
  0 siblings, 0 replies; 3+ messages in thread
From: Jay Belanger @ 2015-07-05 16:14 UTC (permalink / raw)
  To: Daniel Colascione; +Cc: Emacs-devel

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

It seems like a reasonable thing to do.  My only concern, with keybindings
that have been around so long, is that some may be used to M-w operating on
whole lines in Calc.  But if nobody objects, the change looks fine.
On Jul 5, 2015 5:42 AM, "Wolfgang Jenkner" <wjenkner@inode.at> wrote:

> On Sat, Jul 04 2015, Daniel Colascione wrote:
>
> > Right now, calc binds M-w to a special version of copy-region-as-kill
> > than copies the entire calc value (along with the calc stack prefix)
> > instead of just the highlighted region. This behavior is inconsistent
> > with other modes. Can we apply something like this patch? I'll fix the
> > documentation if we apply it.
>
> Calc has a maintainer (please see admin/MAINTAINERS).
>
>

[-- Attachment #2: Type: text/html, Size: 1026 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-05 16:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-04 23:28 [RFC] normalize kill-region in calc Daniel Colascione
2015-07-05 10:41 ` Wolfgang Jenkner
2015-07-05 16:14   ` Jay Belanger

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.