From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gary Oberbrunner Newsgroups: gmane.emacs.bugs Subject: bug#3418: Issue with compile.el and compilation-parse-errors-filename-function Date: Thu, 10 Aug 2017 21:04:47 -0400 Message-ID: References: <4A1FF55B.4040202@genarts.com> <83vb6g1jwt.fsf@gnu.org> <799658909.580977.1453821327904.JavaMail.zimbra@genarts.com> <83fuxk1fxp.fsf@gnu.org> <681830756.582148.1453825181223.JavaMail.zimbra@genarts.com> <878tir2ai2.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114dbdf64156dd05566fe606" X-Trace: blaine.gmane.org 1502413513 31783 195.159.176.226 (11 Aug 2017 01:05:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 11 Aug 2017 01:05:13 +0000 (UTC) Cc: 3418@debbugs.gnu.org, Andrew Hyatt To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 11 03:05:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfyNw-0007yQ-Kj for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Aug 2017 03:05:08 +0200 Original-Received: from localhost ([::1]:40000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfyO2-0002K0-Ma for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Aug 2017 21:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfyNu-0002HY-E1 for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2017 21:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfyNr-0007uK-8S for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2017 21:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46232) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dfyNr-0007uD-5r for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2017 21:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dfyNq-0006YQ-GQ for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2017 21:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gary Oberbrunner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2017 01:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3418-submit@debbugs.gnu.org id=B3418.150241349625180 (code B ref 3418); Fri, 11 Aug 2017 01:05:02 +0000 Original-Received: (at 3418) by debbugs.gnu.org; 11 Aug 2017 01:04:56 +0000 Original-Received: from localhost ([127.0.0.1]:54913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfyNk-0006Y3-89 for submit@debbugs.gnu.org; Thu, 10 Aug 2017 21:04:56 -0400 Original-Received: from mail-vk0-f42.google.com ([209.85.213.42]:36051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfyNh-0006Xq-I8 for 3418@debbugs.gnu.org; Thu, 10 Aug 2017 21:04:55 -0400 Original-Received: by mail-vk0-f42.google.com with SMTP id u133so8734530vke.3 for <3418@debbugs.gnu.org>; Thu, 10 Aug 2017 18:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=genarts-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ctt/TRuaj5miev91r/GJkOYjpNEBOzM0+2IgP95ctaA=; b=V/rUukxRJSGkZUCuctTO1bqNjM7Bjg+wEyzmoRziodUSQIEpOGZAgFphQzipJc9Dqq f5EeUAlMzQPEraqvJ0udZabrARexX+6uTnMBPapPwMgwxLg7s8u5ASQN4tIkfSC6WmOU XU5AoXRjHQd/k8QpYiPV64Hg/YFxWrOqRcTStBaXfh6MxVrhIIXYdEuqxt5VUKgnQd/t Y+F14TiWakkXt2dZha2ZCWZWhIB4PZn25uCbEsKIo4md5Cg7QyXX6uVE1UB3KwxfDGJW Fp7QeZ6JLE3EJbbkdxonQJuhEdzB0hV6Mn8UOL2B73ZBoEHx/QXgdvSiqlkhI6Cce4EA trJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ctt/TRuaj5miev91r/GJkOYjpNEBOzM0+2IgP95ctaA=; b=fGVawpT7qN7t9ynrKGuhOqRI391aACAqT9xZIR+2cfaHDNGXDVOsxkh6FcfSGaYpLW L7RLD9eRy/zHAhGP8DZJ6F4NbsgWkVKhPTar2X9bOLe+BBbjhDUDEzajqsatq2g1yIeD LcbWGCMYk0OA0O2OcMWh7xz0a/zFu4E0pmMD5ZbJWlb1dXRvhfe7z6qtlUXSsoY5hp0w RVoMHuTnl0oeOhHP2V3cfU2k0aWs50mp8W3ZZKFQJ7safkEUf1A5gC1q/iXWGmHFc/X3 LcPAVKVXTCdX8r0fKahaKI3Od35Eou9QySKm49pzfSzqKKQh3QxbRdmwO4wf8zUE6QcV YPFQ== X-Gm-Message-State: AHYfb5hvXj4eIXuAN6708g5KQI04pjxBpFEOO8SHjlDwz16n7h0khEy3 hJRxbxXp2yQBzTNiEPxZgWcCmjVl6YkW X-Received: by 10.31.63.151 with SMTP id m145mr8788518vka.59.1502413487944; Thu, 10 Aug 2017 18:04:47 -0700 (PDT) Original-Received: by 10.103.86.78 with HTTP; Thu, 10 Aug 2017 18:04:47 -0700 (PDT) In-Reply-To: <878tir2ai2.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135636 Archived-At: --001a114dbdf64156dd05566fe606 Content-Type: text/plain; charset="UTF-8" This sounds perfect to me. On Thu, Aug 10, 2017 at 8:50 PM, wrote: > Gary Oberbrunner writes: > > > If a user (such as myself) has an implementation of this function in his > .emacs today, like so: > > > > (defun process-error-filename (filename) > > ;;; do stuff with filename > > filename) > > (setq compilation-parse-errors-filename-function > 'process-error-filename) > > > > and we add a new argument that gets passed to that function, it'll throw > an error. *Users* will have to add > > &optional spec-dir > > to their implementations of it to avoid the error. > > We could do something like > > (condition-case err > (funcall compilation-parse-errors-filename-function filename > spec-dir) > (wrong-number-of-arguments > ;; Try again with single arg for backwards compatibility. > (funcall compilation-parse-errors-filename-function filename))) > -- Gary Oberbrunner *--* CTO *--* Boris FX --001a114dbdf64156dd05566fe606 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This sounds perfect to me.

On Thu, Aug 10, 2017 at 8:50 PM, <npostavs@users.sourceforge.net> wrote:
Gary Oberbrunner <garyo@genarts.com> writes:

> If a user (such as myself) has an implementation of this function in h= is .emacs today, like so:
>
> (defun process-error-filename (filename)
>=C2=A0 =C2=A0;;; do stuff with filename
>=C2=A0 =C2=A0filename)
> (setq compilation-parse-errors-filename-function 'process-err= or-filename)
>
> and we add a new argument that gets passed to that function, it'll= throw an error. *Users* will have to add
>=C2=A0 =C2=A0&optional spec-dir
> to their implementations of it to avoid the error.

We could do something like

=C2=A0 =C2=A0 (condition-case err
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (funcall compilation-parse-errors-filename= -function filename spec-dir)
=C2=A0 =C2=A0 =C2=A0 (wrong-number-of-arguments
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; Try again with single arg for backwards compa= tibility.
=C2=A0 =C2=A0 =C2=A0 =C2=A0(funcall compilation-parse-errors-filename-= function filename)))



--
Ga= ry Oberbrunner --=C2=A0CTO -- Boris FX
--001a114dbdf64156dd05566fe606--