ido regression in trunk?

ido regression in trunk?

[Carsten Mattner]

Did anyone else notice that opening files with ido enabled
doesn't work as it did last week in current trunk?

The fuzzy match of file/dir to open always open the first
item of the list even if I continue typing a more precise
different sub-directory which is not the first entry of the list.

I cannot imagine this to go unnoticed.

Re: ido regression in trunk?

[Christopher Monsanto]

I've noticed this problem as well, very irritating. If the maintainer
of ido doesn't know what's up, I can do a bisect to find the problem.

Christopher Monsanto
chris@monsan.to  --  http://monsan.to/

Re: ido regression in trunk?

[Leo]

On 2012-09-28 02:19 +0800, Carsten Mattner wrote:
> Did anyone else notice that opening files with ido enabled
> doesn't work as it did last week in current trunk?
>
> The fuzzy match of file/dir to open always open the first
> item of the list even if I continue typing a more precise
> different sub-directory which is not the first entry of the list.
>
> I cannot imagine this to go unnoticed.

On 2012-09-28 07:05 +0800, Christopher Monsanto wrote:
> I've noticed this problem as well, very irritating. If the maintainer
> of ido doesn't know what's up, I can do a bisect to find the problem.
>
> Christopher Monsanto
> chris@monsan.to  --  http://monsan.to/

Sorry to all. It is my fault. I will install the following fix later
today:

diff --git a/lisp/ido.el b/lisp/ido.el
index d48e7ba8..f511dbbf 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -3701,14 +3701,14 @@ (defun ido-set-matches-1 (items &optional do-full)
 	 (rexq (concat rex0 (if slash ".*/" "")))
 	 (re (if ido-enable-prefix (concat "\\`" rexq) rexq))
 	 (full-re (and do-full
-		       (and (eq ido-cur-item 'buffer)
-			    (not ido-buffer-disable-smart-matches))
+		       (not (and (eq ido-cur-item 'buffer)
+				 ido-buffer-disable-smart-matches))
 		       (not ido-enable-regexp)
 		       (not (string-match "\$\\'" rex0))
 		       (concat "\\`" rex0 (if slash "/" "") "\\'")))
 	 (suffix-re (and do-full slash
-			 (and (eq ido-cur-item 'buffer)
-			      (not ido-buffer-disable-smart-matches))
+			 (not (and (eq ido-cur-item 'buffer)
+				   ido-buffer-disable-smart-matches))
 			 (not ido-enable-regexp)
 			 (not (string-match "\$\\'" rex0))
 			 (concat rex0 "/\\'")))

Re: ido regression in trunk?

[Carsten Mattner]

On Fri, Sep 28, 2012 at 5:33 AM, Leo <sdl.web@gmail.com> wrote:
> On 2012-09-28 02:19 +0800, Carsten Mattner wrote:
>> Did anyone else notice that opening files with ido enabled
>> doesn't work as it did last week in current trunk?
>>
>> The fuzzy match of file/dir to open always open the first
>> item of the list even if I continue typing a more precise
>> different sub-directory which is not the first entry of the list.
>>
>> I cannot imagine this to go unnoticed.
>
> On 2012-09-28 07:05 +0800, Christopher Monsanto wrote:
>> I've noticed this problem as well, very irritating. If the maintainer
>> of ido doesn't know what's up, I can do a bisect to find the problem.
>>
>> Christopher Monsanto
>> chris@monsan.to  --  http://monsan.to/
>
> Sorry to all. It is my fault. I will install the following fix later
> today:
>
> diff --git a/lisp/ido.el b/lisp/ido.el
> index d48e7ba8..f511dbbf 100644
> --- a/lisp/ido.el
> +++ b/lisp/ido.el
> @@ -3701,14 +3701,14 @@ (defun ido-set-matches-1 (items &optional do-full)
>          (rexq (concat rex0 (if slash ".*/" "")))
>          (re (if ido-enable-prefix (concat "\\`" rexq) rexq))
>          (full-re (and do-full
> -                      (and (eq ido-cur-item 'buffer)
> -                           (not ido-buffer-disable-smart-matches))
> +                      (not (and (eq ido-cur-item 'buffer)
> +                                ido-buffer-disable-smart-matches))
>                        (not ido-enable-regexp)
>                        (not (string-match "\$\\'" rex0))
>                        (concat "\\`" rex0 (if slash "/" "") "\\'")))
>          (suffix-re (and do-full slash
> -                        (and (eq ido-cur-item 'buffer)
> -                             (not ido-buffer-disable-smart-matches))
> +                        (not (and (eq ido-cur-item 'buffer)
> +                                  ido-buffer-disable-smart-matches))
>                          (not ido-enable-regexp)
>                          (not (string-match "\$\\'" rex0))
>                          (concat rex0 "/\\'")))

Thanks.

Re: ido regression in trunk?

[Leo]

On 2012-09-28 11:33 +0800, Leo wrote:
> Sorry to all. It is my fault. I will install the following fix later
> today:

Installed as r108149 in emacs-24 (see
http://permalink.gmane.org/gmane.emacs.diffs/116492).

It might take a few days to merge into trunk. (I tried doing it myself
but bzrmerge.el complaint about uncommitted changes when I have none.)

Leo

Re: ido regression in trunk?

[Glenn Morris]

Leo wrote:

> (I tried doing it myself but bzrmerge.el complaint about uncommitted
> changes when I have none.)

Make a bug report (with details).