From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jeffrey Honig Newsgroups: gmane.emacs.bugs Subject: bug#25552: 26.0.50; load cl unintendedly Date: Thu, 2 Feb 2017 21:21:22 -0500 Message-ID: References: <87vasuow8m.fsf@users.sourceforge.net> <29437.1486087555@alto> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113eae76804038054796f26e X-Trace: blaine.gmane.org 1486089919 29238 195.159.176.226 (3 Feb 2017 02:45:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Feb 2017 02:45:19 +0000 (UTC) Cc: yamaoka@jpl.org, Bill Wohler , 25552@debbugs.gnu.org, npostavs@users.sourceforge.net To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 03 03:45:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZTs6-0007Eu-7M for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Feb 2017 03:45:10 +0100 Original-Received: from localhost ([::1]:59925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZTsB-0005rZ-9K for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Feb 2017 21:45:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZTs1-0005nU-T2 for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2017 21:45:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZTry-0007Ys-QB for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2017 21:45:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZTry-0007Yl-M1 for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2017 21:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cZTry-0005oq-Fa; Thu, 02 Feb 2017 21:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jeffrey Honig Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, mh-e-devel@lists.sourceforge.net Resent-Date: Fri, 03 Feb 2017 02:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25552 X-GNU-PR-Package: emacs,mh-e X-GNU-PR-Keywords: Original-Received: via spool by 25552-submit@debbugs.gnu.org id=B25552.148608990122350 (code B ref 25552); Fri, 03 Feb 2017 02:45:02 +0000 Original-Received: (at 25552) by debbugs.gnu.org; 3 Feb 2017 02:45:01 +0000 Original-Received: from localhost ([127.0.0.1]:54355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZTrx-0005oQ-6o for submit@debbugs.gnu.org; Thu, 02 Feb 2017 21:45:01 -0500 Original-Received: from mail-lf0-f46.google.com ([209.85.215.46]:34326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZTVo-0005IC-Ia for 25552@debbugs.gnu.org; Thu, 02 Feb 2017 21:22:09 -0500 Original-Received: by mail-lf0-f46.google.com with SMTP id v186so3023307lfa.1 for <25552@debbugs.gnu.org>; Thu, 02 Feb 2017 18:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=honig.net; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=d5T17cCydWmm1ooGqplaxxcWxkl7mlS23Sl++bGHQUM=; b=CU7OukzW7xJ5XZsSSB2jsjcUdqsmaoUZdiJ5u1LJShHVaITvoUzR2m6ZsSIdrC2409 7kC1e2qlLKntjr41ZVfbs/xvh7x0qNKaU5EulseYTj/frGKM7BBTGRZSDq/7VF+KndNq eqAxDBi/Y/ImRNV5BYpBpwjt8GwIwbWFWEZ/w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d5T17cCydWmm1ooGqplaxxcWxkl7mlS23Sl++bGHQUM=; b=NwC/0QNy34r7GPov4I0pmkyBKvwmYLACM7iOkEU3Tsd8ics1lWw17XStfmcXjRwCPn 34bdQffuAuop1t6aptwuEPk+6oAF1escua08tsbwJCcVBHn1IAocw9GjKjpNYbtYHo6Y yELAMI3eyyc9cYuK+j1asC9hsQFlSyeo7uxOmdWwOphTRmrCe8X29ggNXVdF1FiAyq9i XJYBK4ne66cT/Aac4vijOU2c6bGT9Zs6XFicuBWLbuCoFSRF8NzbJQCyGycfdmJcdXUk zKstvJlZrioz7dfIdsoepSFy1idwCj5mqpQcgXVkLc3FOyeH6koRUIkWrSAMtuts4GU2 Bc7w== X-Gm-Message-State: AIkVDXJ4YZ3Yd+zeJK8uz3Mr6kMUeqpLY2Y+OiWIOr+TwaT9zqcAmJBgxNZLulHoX2VAoLH83ycSzvHIAmNcrQ== X-Received: by 10.25.129.147 with SMTP id c141mr4043445lfd.93.1486088522704; Thu, 02 Feb 2017 18:22:02 -0800 (PST) Original-Received: by 10.25.86.9 with HTTP; Thu, 2 Feb 2017 18:21:22 -0800 (PST) In-Reply-To: <29437.1486087555@alto> X-Mailman-Approved-At: Thu, 02 Feb 2017 21:45:00 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128901 Archived-At: --001a113eae76804038054796f26e Content-Type: text/plain; charset=UTF-8 Bill should weigh in on this change, he did extensive work in this area. Thanks Jeff -- Jeffrey C. Honig http://jch.honig.net GnuPG ID:14E29E13 Keybase: jchonig On Thu, Feb 2, 2017 at 9:05 PM, Mike Kupfer wrote: > npostavs@users.sourceforge.net wrote: > > > Mike Kupfer writes: > > > > > Hi Katsumi and Glenn, I applied Glenn's patch to 25.1.90, and I'm > afraid > > > that it introduced a failure. > [...] > > I guess it's because defun-mh checks whether the alias target is fbound > > at compile time: > > > > (defmacro defun-mh (name function arg-list &rest body) > > "Create function NAME. > > If FUNCTION exists, then NAME becomes an alias for FUNCTION. > > Otherwise, create function NAME with ARG-LIST and BODY." > > (let ((defined-p (fboundp function))) > > (if defined-p > > `(defalias ',name ',function) > > `(defun ,name ,arg-list ,@body)))) > > > > It would be better to check at runtime: > > > > (defmacro defun-mh (name function arg-list &rest body) > > `(if (fboundp ',function) > > (defalias ',name ',function) > > (defun ,name ,arg-list ,@body))) > > > > And/or require `mail-abbrev' at compile time > > > > --- i/lisp/mh-e/mh-compat.el > > +++ w/lisp/mh-e/mh-compat.el > > @@ -260,7 +260,7 @@ 'mh-line-end-position > > 'line-end-position > > 'point-at-eol)) > > > > -(mh-require 'mailabbrev nil t) > > +(eval-and-compile (mh-require 'mailabbrev nil t)) > > (defun-mh mh-mail-abbrev-make-syntax-table > > mail-abbrev-make-syntax-table () > > "Emacs 21 and XEmacs don't have `mail-abbrev-make-syntax-table'. > > Thanks, Noam! > > I did some light testing of Noam's change to defun-mh plus Glenn's > patch. The problem that I reported is gone, and I haven't seen any > other issues. I did the testing with both Emacs 25.1.90 and master > (7cb7a58). > > Does anyone on the MH-E dev team have any concerns about this > combination of changes? > > mike > > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > mh-e-devel mailing list > mh-e-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mh-e-devel > --001a113eae76804038054796f26e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Bill should weigh in on this change, he did extensive work= in this area.

<= div dir=3D"ltr">
Thanks

Jeff

--
Jeffrey C. Honig <= jch@honig.net>http://jch.honig.net
=

On Thu, Feb 2, 2017 at 9:05 PM, Mike Kupfer = <mkupfer@alum.berkeley.edu> wrote:
npostavs@users.sourceforge.net wrote:

> Mike Kupfer <mkupfer@a= lum.berkeley.edu> writes:
>
> > Hi Katsumi and Glenn, I applied Glenn's patch to 25.1.90, and= I'm afraid
> > that it introduced a failure.
[...]
> I guess it's because defun-mh checks whethe= r the alias target is fbound
> at compile time:
>
>=C2=A0 =C2=A0 =C2=A0(defmacro defun-mh (name function arg-list &res= t body)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0"Create function NAME.
>=C2=A0 =C2=A0 =C2=A0If FUNCTION exists, then NAME becomes an alias for = FUNCTION.
>=C2=A0 =C2=A0 =C2=A0Otherwise, create function NAME with ARG-LIST and B= ODY."
>=C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((defined-p (fboundp function)))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if defined-p
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0`(defalias ',name &= #39;,function)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0`(defun ,name ,arg-list ,@body= ))))
>
> It would be better to check at runtime:
>
>=C2=A0 =C2=A0 =C2=A0(defmacro defun-mh (name function arg-list &res= t body)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0`(if (fboundp ',function)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (defalias ',name ',fu= nction)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (defun ,name ,arg-list ,@body)))
>
> And/or require `mail-abbrev' at compile time
>
> --- i/lisp/mh-e/mh-compat.el
> +++ w/lisp/mh-e/mh-compat.el
> @@ -260,7 +260,7 @@ 'mh-line-end-position
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 'line-end-position
>=C2=A0 =C2=A0 =C2=A0 'point-at-eol))
>
> -(mh-require 'mailabbrev nil t)
> +(eval-and-compile (mh-require 'mailabbrev nil t))
>=C2=A0 (defun-mh mh-mail-abbrev-make-syntax-table
>=C2=A0 =C2=A0 mail-abbrev-make-syntax-table ()
>=C2=A0 =C2=A0 "Emacs 21 and XEmacs don't have `mail-abbrev-mak= e-syntax-table'.

Thanks, Noam!

I did some light testing of Noam's change to defun-mh plus Glenn's<= br> patch.=C2=A0 The problem that I reported is gone, and I haven't seen an= y
other issues.=C2=A0 I did the testing with both Emacs 25.1.90 and master (7cb7a58).

Does anyone on the MH-E dev team have any concerns about this
combination of changes?

mike



-----------------------------------------------------------------= -------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
mh-e-devel mailing list
mh-e-devel@lists.source= forge.net
https://lists.sourceforge.net/lists/list= info/mh-e-devel

--001a113eae76804038054796f26e--