From: Jeffrey Honig <jch@honig.net>
To: Mike Kupfer <mkupfer@alum.berkeley.edu>
Cc: yamaoka@jpl.org, Bill Wohler <wohler@newt.com>,
25552@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#25552: 26.0.50; load cl unintendedly
Date: Thu, 2 Feb 2017 21:21:22 -0500 [thread overview]
Message-ID: <CAC5WE8qFGjt5bLsbVJrvUttPOom8nN+Xe-WuW1zTvpaHvf=5BQ__2922.66063993356$1486089919$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <29437.1486087555@alto>
[-- Attachment #1: Type: text/plain, Size: 2502 bytes --]
Bill should weigh in on this change, he did extensive work in this area.
Thanks
Jeff
--
Jeffrey C. Honig <jch@honig.net>
http://jch.honig.net
GnuPG ID:14E29E13 <http://jch.honig.net/Home/pgp_key>
Keybase: jchonig <https://keybase.io/jchonig>
On Thu, Feb 2, 2017 at 9:05 PM, Mike Kupfer <mkupfer@alum.berkeley.edu>
wrote:
> npostavs@users.sourceforge.net wrote:
>
> > Mike Kupfer <mkupfer@alum.berkeley.edu> writes:
> >
> > > Hi Katsumi and Glenn, I applied Glenn's patch to 25.1.90, and I'm
> afraid
> > > that it introduced a failure.
> [...]
> > I guess it's because defun-mh checks whether the alias target is fbound
> > at compile time:
> >
> > (defmacro defun-mh (name function arg-list &rest body)
> > "Create function NAME.
> > If FUNCTION exists, then NAME becomes an alias for FUNCTION.
> > Otherwise, create function NAME with ARG-LIST and BODY."
> > (let ((defined-p (fboundp function)))
> > (if defined-p
> > `(defalias ',name ',function)
> > `(defun ,name ,arg-list ,@body))))
> >
> > It would be better to check at runtime:
> >
> > (defmacro defun-mh (name function arg-list &rest body)
> > `(if (fboundp ',function)
> > (defalias ',name ',function)
> > (defun ,name ,arg-list ,@body)))
> >
> > And/or require `mail-abbrev' at compile time
> >
> > --- i/lisp/mh-e/mh-compat.el
> > +++ w/lisp/mh-e/mh-compat.el
> > @@ -260,7 +260,7 @@ 'mh-line-end-position
> > 'line-end-position
> > 'point-at-eol))
> >
> > -(mh-require 'mailabbrev nil t)
> > +(eval-and-compile (mh-require 'mailabbrev nil t))
> > (defun-mh mh-mail-abbrev-make-syntax-table
> > mail-abbrev-make-syntax-table ()
> > "Emacs 21 and XEmacs don't have `mail-abbrev-make-syntax-table'.
>
> Thanks, Noam!
>
> I did some light testing of Noam's change to defun-mh plus Glenn's
> patch. The problem that I reported is gone, and I haven't seen any
> other issues. I did the testing with both Emacs 25.1.90 and master
> (7cb7a58).
>
> Does anyone on the MH-E dev team have any concerns about this
> combination of changes?
>
> mike
>
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> mh-e-devel mailing list
> mh-e-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mh-e-devel
>
[-- Attachment #2: Type: text/html, Size: 4260 bytes --]
next prev parent reply other threads:[~2017-02-03 2:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 1:24 bug#25552: 26.0.50; load cl unintendedly Katsumi Yamaoka
2017-01-27 1:50 ` Katsumi Yamaoka
2017-01-29 17:03 ` npostavs
2017-01-30 3:37 ` Mark Oteiza
2017-01-30 22:35 ` Glenn Morris
2017-01-31 22:39 ` Glenn Morris
2017-02-01 1:09 ` Katsumi Yamaoka
[not found] ` <b4m60kuk98u.fsf@jpl.org>
2017-02-01 4:02 ` Mike Kupfer
[not found] ` <17104.1485921740@alto>
2017-02-01 13:51 ` npostavs
2017-02-03 2:05 ` Mike Kupfer
2017-02-03 2:21 ` Jeffrey Honig [this message]
[not found] ` <CAC5WE8qFGjt5bLsbVJrvUttPOom8nN+Xe-WuW1zTvpaHvf=5BQ@mail.gmail.com>
2017-02-03 6:30 ` Bill Wohler
2017-02-06 1:25 ` Jeffrey Honig
2017-02-06 2:03 ` Glenn Morris
2017-04-09 12:01 ` npostavs
2017-04-09 14:25 ` Mike Kupfer
2017-04-14 1:30 ` Mike Kupfer
[not found] ` <12659.1492133413@alto>
2017-04-14 14:36 ` Noam Postavsky
2017-04-14 17:05 ` Glenn Morris
[not found] ` <4mefwu2a3a.fsf@fencepost.gnu.org>
2017-04-15 18:17 ` Bill Wohler
[not found] ` <CAM-tV-9fuKGbSBY8sDfL5MvAq0iAua5-4USgRrD11AQ+C52Avg@mail.gmail.com>
2017-05-01 5:10 ` Bill Wohler
[not found] ` <27497.1493615440@olgas.newt.com>
2017-05-01 13:43 ` Mike Kupfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5WE8qFGjt5bLsbVJrvUttPOom8nN+Xe-WuW1zTvpaHvf=5BQ__2922.66063993356$1486089919$gmane$org@mail.gmail.com' \
--to=jch@honig.net \
--cc=25552@debbugs.gnu.org \
--cc=mkupfer@alum.berkeley.edu \
--cc=npostavs@users.sourceforge.net \
--cc=wohler@newt.com \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.