Submitting patches: need I do more than send them to the bug tracker?

Submitting patches: need I do more than send them to the bug tracker?

[Daniel Pittman]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

G'day.  I'm sorry to trouble y'all, but I'm trying to work out if I have
missed something when I read through the contributing guide.

I have a couple of patches in the bug tracker at the moment, one feature,
and one bug fix, which have attracted no response.  In the former case it
has been five days, which I had assumed would be enough time to get some
sort of response.

Now, I'm not asking for special treatment, or someone to rush and review
the code, but rather, to ensure that I have done all the right things to
get this into the queue for Emacs.  I'd rather ask than miss something.

The two tickets in question are:

Feature added to emacsclient, five days old:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33095

Bug fix for `vc-hg-find-file-hook', one day old:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33129

Again, if getting them there is all that was needed, great, and I'm happy
for them to be reviewed at whatever schedule suits you best.

[-- Attachment #2: Type: text/html, Size: 1370 bytes --]

Re: Submitting patches: need I do more than send them to the bug tracker?

[Noam Postavsky]

On Wed, 24 Oct 2018 at 10:15, Daniel Pittman <slippycheeze@google.com> wrote:

> I have a couple of patches in the bug tracker at the moment, one feature, and one bug fix, which have attracted no response.  In the former case it has been five days, which I had assumed would be enough time to get some sort of response.
>
> Now, I'm not asking for special treatment, or someone to rush and review the code, but rather, to ensure that I have done all the right things to get this into the queue for Emacs.  I'd rather ask than miss something.

If you don't get a response to a patch, sending a short message to
make sure it hasn't gotten lost like you've done is the right thing to
do. I would generally say to wait a full week.

> The two tickets in question are:
>
> Feature added to emacsclient, five days old:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33095
>
> Bug fix for `vc-hg-find-file-hook', one day old:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33129
>
> Again, if getting them there is all that was needed, great, and I'm happy for them to be reviewed at whatever schedule suits you best.

I see Eli has by now applied the first one; the second looks
reasonable, though not being an hg user, I'd hesitate to apply it
myself.

Re: Submitting patches: need I do more than send them to the bug tracker?

[Eli Zaretskii]

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Sat, 27 Oct 2018 18:24:18 -0400
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> If you don't get a response to a patch, sending a short message to
> make sure it hasn't gotten lost like you've done is the right thing to
> do. I would generally say to wait a full week.

Yes, a good advice.  I usually wait for comments for at least a week,
if I have no comments myself.

Re: Submitting patches: need I do more than send them to the bug tracker?

[Daniel Pittman]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Sun, Oct 28, 2018 at 11:43 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Noam Postavsky <npostavs@gmail.com>
> > Date: Sat, 27 Oct 2018 18:24:18 -0400
> > Cc: Emacs developers <emacs-devel@gnu.org>
> >
> > If you don't get a response to a patch, sending a short message to
> > make sure it hasn't gotten lost like you've done is the right thing to
> > do. I would generally say to wait a full week.
>
> Yes, a good advice.  I usually wait for comments for at least a week,
> if I have no comments myself.
>

Great, thank you.  That was roughly what I figured was reasonable, but ...
I'm occasionally too good at missing things. :)

Thank you for applying (and reviewing) my changes, also.

[-- Attachment #2: Type: text/html, Size: 1170 bytes --]