From: Daniel Pittman <slippycheeze@google.com>
To: 33129@debbugs.gnu.org
Subject: bug#33129: 26.1; `vc-hg-find-file-hook' can never detect files with conflicts
Date: Tue, 23 Oct 2018 12:03:36 -0400 [thread overview]
Message-ID: <CAC45yQtnGQ+VFKPD3bTPPKQJK6=1QBLaw+8XOTCcQihufYOHCA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
The `vc-hg-find-file-hook' tries to automatically invoke `smerge-mode'
when a file with conflicts is visited. Unfortunately, due to incorrect
assumptions, it rarely -- possibly never -- actually manages to detect
the files.
There are two incorrect assumptions in the code that prevent this:
First, that `vc-state' will already be cached by the backend, which is
not true in at least the cases of visiting the file, reverting the file,
or using `vc-refresh-state'.
It is certainly possible that in some case or other the hook works, this
assumption means that it is almost never going to behave as intended.
Second, it assumes that a ".orig" backup file is created by Mercurial
next to the current file, which is only true by default: these files can
be redirected to an alternate path, or disabled entirely, by the user.
This is especially common when working on a network file-system, since
additional file operations can slow down the Mercurial merge process, or
when users have some other mechanism to handle the failure case.
[-- Attachment #2: Type: text/html, Size: 1149 bytes --]
next reply other threads:[~2018-10-23 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 16:03 Daniel Pittman [this message]
[not found] ` <handler.33129.B.15403106928776.ack@debbugs.gnu.org>
2018-10-23 16:10 ` bug#33129: Acknowledgement (26.1; `vc-hg-find-file-hook' can never detect files with conflicts) Daniel Pittman
2018-11-03 8:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC45yQtnGQ+VFKPD3bTPPKQJK6=1QBLaw+8XOTCcQihufYOHCA@mail.gmail.com' \
--to=slippycheeze@google.com \
--cc=33129@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.