From: Daniel Pittman <slippycheeze@google.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: `process-send-*` performance seems ... bad?
Date: Wed, 19 Jun 2019 14:02:34 -0400 [thread overview]
Message-ID: <CAC45yQsbqBc2rTm3bUTu9ngvqwT7L1c9cu2Ka1ziJRTvDUv8Pg@mail.gmail.com> (raw)
In-Reply-To: <CAM-tV-8tmW821UuwGrnrVqpF_qGqfWMqLzg-bY91j98VRzU29g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]
Ah, no, that is running locally – the call to make-process is not using
file handlers, and the purpose of setting that default directory was to
ensure that it didn't.
That said, I retested with `(default-directory (expand-file-name "~"))`
there, and performance is identical:
========== pass 1 ==========
write-with-temp-buffer: 5.8827s with 0 GCs taking 0.0000s: (5.882696 0 0.0)
write-with-two-calls: 2.4786s with 0 GCs taking 0.0000s: (2.478616 0 0.0)
write-with-one-call: 1.9073s with 0 GCs taking 0.0000s: (1.907256 0 0.0)
========== pass 2 ==========
write-with-temp-buffer: 5.6867s with 0 GCs taking 0.0000s: (5.686659 0 0.0)
write-with-two-calls: 2.2408s with 0 GCs taking 0.0000s: (2.240782 0 0.0)
write-with-one-call: 1.8802s with 0 GCs taking 0.0000s: (1.8801780000000001
0 0.0)
========== pass 3 ==========
write-with-temp-buffer: 5.7305s with 0 GCs taking 0.0000s:
(5.730538999999999 0 0.0)
write-with-two-calls: 2.3394s with 0 GCs taking 0.0000s: (2.339416 0 0.0)
write-with-one-call: 1.9350s with 0 GCs taking 0.0000s: (1.9350479999999999
0 0.0)
On Wed, Jun 19, 2019 at 10:58 AM Noam Postavsky <npostavs@gmail.com> wrote:
> On Tue, 18 Jun 2019 at 17:55, Daniel Pittman <slippycheeze@google.com>
> wrote:
>
> > ] cat obarray.data > in & wc < out & time fzf -f "hook mode" < in > out
> ; wait
>
> > The code behind those results is attached
>
> (let ((default-directory
>
> "/gssh:slippycheeze.c.googlers.com:
> /google/src/cloud/slippycheeze/work/google3/production/storage/chronicle/")
>
> It looks you're running locally in the shell case, but over TRAMP in
> the elisp case. I imagine that could have a pretty large effect on
> timing. Is there a reason for binding default-directory like this?
>
[-- Attachment #2: Type: text/html, Size: 2279 bytes --]
next prev parent reply other threads:[~2019-06-19 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 21:41 `process-send-*` performance seems ... bad? Daniel Pittman
2019-06-19 14:57 ` Noam Postavsky
2019-06-19 18:02 ` Daniel Pittman [this message]
2019-06-19 18:15 ` Noam Postavsky
2019-06-19 19:35 ` Daniel Pittman
2019-06-19 15:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC45yQsbqBc2rTm3bUTu9ngvqwT7L1c9cu2Ka1ziJRTvDUv8Pg@mail.gmail.com \
--to=slippycheeze@google.com \
--cc=emacs-devel@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.