Bug: org-set-property does not leave the point still [8.1.1 (release_8.1.1-29-gc5f2ae @ /home/mboes/.emacs.d/lisp/org/lisp/)]

Bug: org-set-property does not leave the point still [8.1.1 (release_8.1.1-29-gc5f2ae @ /home/mboes/.emacs.d/lisp/org/lisp/)]

[Mathieu Boespflug]

Hi,

consider the following very simple org file:

* TODO Thing1[]

where "[]" marks where the point is. Now if I C-S-RET to insert a new
TODO heading, I get

* TODO Thing1
* TODO []

Note that there is a trailing space at the end of the last line, as
expected. The problem is that if I now press C-c C-x p to set
a property (any property), then I end up with the following situation:

* TODO Thing1
* TODO
  :PROPERTIES:
  :PROP:     val
  :END: []

The point is now at the end of the property drawer, rather than where it
was before. Notice how the trailing whitespace in the heading has
moreover been moved to after the property drawer.

Expected behaviour:

After C-c C-x p, I expect to get:

* TODO Thing1
* TODO []
  :PROPERTIES:
  :PROP:     val
  :END:

This is exactly what I get if there is *no trailing whitespace* in the
TODO heading before hitting C-c C-x p. So it seems that the bug is that
org-set-property does not deal well with trailing whitespace.

This is a problem because it messes up setting properties by advising
org-insert-todo-heading, say to set a CREATED property automatically for
new TODO items.

Emacs  : GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.2)
 of 2013-08-07 on -mnt-storage-buildroots-staging-x86_64-eric
Package: Org-mode version 8.1.1 (release_8.1.1-29-gc5f2ae @
/home/mboes/.emacs.d/lisp/org/lisp/)

Re: Bug: org-set-property does not leave the point still [8.1.1 (release_8.1.1-29-gc5f2ae @ /home/mboes/.emacs.d/lisp/org/lisp/)]

[Carsten Dominik]

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

Hi Mathieu,

thank you for your report, this is now fixed.

- Carsten

On 16.9.2013, at 00:16, Mathieu Boespflug <mboes@tweag.net> wrote:

> Hi,
> 
> consider the following very simple org file:
> 
> * TODO Thing1[]
> 
> where "[]" marks where the point is. Now if I C-S-RET to insert a new
> TODO heading, I get
> 
> * TODO Thing1
> * TODO []
> 
> Note that there is a trailing space at the end of the last line, as
> expected. The problem is that if I now press C-c C-x p to set
> a property (any property), then I end up with the following situation:
> 
> * TODO Thing1
> * TODO
>  :PROPERTIES:
>  :PROP:     val
>  :END: []
> 
> The point is now at the end of the property drawer, rather than where it
> was before. Notice how the trailing whitespace in the heading has
> moreover been moved to after the property drawer.
> 
> Expected behaviour:
> 
> After C-c C-x p, I expect to get:
> 
> * TODO Thing1
> * TODO []
>  :PROPERTIES:
>  :PROP:     val
>  :END:
> 
> This is exactly what I get if there is *no trailing whitespace* in the
> TODO heading before hitting C-c C-x p. So it seems that the bug is that
> org-set-property does not deal well with trailing whitespace.
> 
> This is a problem because it messes up setting properties by advising
> org-insert-todo-heading, say to set a CREATED property automatically for
> new TODO items.
> 
> Emacs  : GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.2)
> of 2013-08-07 on -mnt-storage-buildroots-staging-x86_64-eric
> Package: Org-mode version 8.1.1 (release_8.1.1-29-gc5f2ae @
> /home/mboes/.emacs.d/lisp/org/lisp/)
> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: Bug: org-set-property does not leave the point still [8.1.1 (release_8.1.1-29-gc5f2ae @ /home/mboes/.emacs.d/lisp/org/lisp/)]

[Mathieu Boespflug]

Hi Carsten,

thank you for the timely fixes!

Best,

--
Mathieu

On Mon, Sep 16, 2013 at 8:23 AM, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
> Hi Mathieu,
>
> thank you for your report, this is now fixed.
>
> - Carsten
>
> On 16.9.2013, at 00:16, Mathieu Boespflug <mboes@tweag.net> wrote:
>
>> Hi,
>>
>> consider the following very simple org file:
>>
>> * TODO Thing1[]
>>
>> where "[]" marks where the point is. Now if I C-S-RET to insert a new
>> TODO heading, I get
>>
>> * TODO Thing1
>> * TODO []
>>
>> Note that there is a trailing space at the end of the last line, as
>> expected. The problem is that if I now press C-c C-x p to set
>> a property (any property), then I end up with the following situation:
>>
>> * TODO Thing1
>> * TODO
>>  :PROPERTIES:
>>  :PROP:     val
>>  :END: []
>>
>> The point is now at the end of the property drawer, rather than where it
>> was before. Notice how the trailing whitespace in the heading has
>> moreover been moved to after the property drawer.
>>
>> Expected behaviour:
>>
>> After C-c C-x p, I expect to get:
>>
>> * TODO Thing1
>> * TODO []
>>  :PROPERTIES:
>>  :PROP:     val
>>  :END:
>>
>> This is exactly what I get if there is *no trailing whitespace* in the
>> TODO heading before hitting C-c C-x p. So it seems that the bug is that
>> org-set-property does not deal well with trailing whitespace.
>>
>> This is a problem because it messes up setting properties by advising
>> org-insert-todo-heading, say to set a CREATED property automatically for
>> new TODO items.
>>
>> Emacs  : GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.2)
>> of 2013-08-07 on -mnt-storage-buildroots-staging-x86_64-eric
>> Package: Org-mode version 8.1.1 (release_8.1.1-29-gc5f2ae @
>> /home/mboes/.emacs.d/lisp/org/lisp/)
>>
>