From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#73117: 30.0.90; Imenu missing entries when flattening by group Date: Sun, 5 Jan 2025 19:15:47 -0500 Message-ID: References: <86v7z6skkj.fsf@mail.linkov.net> <86y142p0hu.fsf@mail.linkov.net> <867cb66bvb.fsf@mail.linkov.net> <86bk086so2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25816"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73117@debbugs.gnu.org, mail@daniel-mendler.de, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 06 01:17:25 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUao8-0006Zv-Gd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jan 2025 01:17:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUano-0000Od-FW; Sun, 05 Jan 2025 19:17:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUanm-0000OU-Rh for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 19:17:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUanm-0004PG-Jg for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 19:17:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=hTkekvgM3rRkcM3hFLdM1UhS3b2alXDsD9QCp+tuJmg=; b=DjnnCVjFts3zm6aNDgykouj6bqq1IDeDaq/VYrxLYZVH/gM1Q6VBTPXW+fyDCU0Zc7ZN+nJVkoTQ9HV0/xfENEvTUaVguQXYBaQr7xlGjHa5dBuRi5cIx8TY3HbTWqFh6CzBrEgymQhDPg2+gRMHpcxel6AxJ4pEgg4vM7dY+ZwXmOzTlYJAPpY54zJ1WPk4UACsUSKM9ZqH0j4MquvL6kf0qN5Fq+o/nU1EP3/cnwXBn8bwmdiEg5DVSQWA9AKna8Xp+IkS6ST0y2Cik/4UyPNJr6YhPkVRoRC6RNzUKsThTqYSCLsDLRZiCuY0k7vot30Ond8RqS5MVUKkJrQcTw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUanm-0005xv-7f for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 19:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2025 00:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73117 X-GNU-PR-Package: emacs Original-Received: via spool by 73117-submit@debbugs.gnu.org id=B73117.173612257122839 (code B ref 73117); Mon, 06 Jan 2025 00:17:02 +0000 Original-Received: (at 73117) by debbugs.gnu.org; 6 Jan 2025 00:16:11 +0000 Original-Received: from localhost ([127.0.0.1]:35948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUamw-0005wI-So for submit@debbugs.gnu.org; Sun, 05 Jan 2025 19:16:11 -0500 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:55688) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUams-0005vW-Sw for 73117@debbugs.gnu.org; Sun, 05 Jan 2025 19:16:09 -0500 Original-Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-aa689a37dd4so2248645866b.3 for <73117@debbugs.gnu.org>; Sun, 05 Jan 2025 16:16:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736122560; x=1736727360; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hTkekvgM3rRkcM3hFLdM1UhS3b2alXDsD9QCp+tuJmg=; b=QAvj/2KQj0fLP1x+AjEVcBaFk85UzyZiZd36L0O46YiUkIYMqZ7gUpJk1Ke1W3Pc68 2mtkrsIzBuYuvsiWxl+J9tAyHMPQjyIAOlV8Cuc672ADv3mCPGtmDzIymiPx5SNONUMI MBhQvoJOfNGT18u3s+9crqFJNrGvvmZln/ybeU6VAwoAD92Li3ePJ7oR3gZJq2v/jSjP yj/XMB6fwWeMzJNLjInJQCDXHKSyF4ZrnnCnd/lLYM9bmrFl4u4dm5Wj/R+fYCXfcdaO gWFw1WMlbKA1OEF1q2W5J+7YUUDnMzFi/rhhc3ZeA7iD9Jz55rRdFZs6hTi3TAHSZtYw gcNw== X-Forwarded-Encrypted: i=1; AJvYcCVgyYSDID5o+vi/Ymk3HfqFHjh4d/ZqMywSdLcLG+eUKkm7VxBS6AgRYGnSoDpMdrYjWWR1Yw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx1dE29td864DljQ4Z+d6u7EA3/dbfbjsOhug5O7te6YTxvBGVS BtF/19f+wixbb+mqfhj3ypsb3h1vUHs22e0PJNu/BjPHlr41y5BHgtfDFwda8xs= X-Gm-Gg: ASbGncuGXvsMWSB6YiEDILFcjCWKV3MAVb1HKHioDn0dPSEyR2mECBgr6Se5c1ZlFuR G+oFPqL539RrtiyQI5aiLzaIEHmQbOaAcp8P1VTwtKiRJsA/gJunkPtXXJxsWAPjaBGYgOY3xeL g156z5X8k/NxrJpmoui51B6cK+cRO9jp/IGoffO1+DFlHVQM4+g0/E5LFaNaJwG6AlxAB/aN1lR 0F7FuNV4mwAb7xABjwh9wL8SWdaqKJ3h2JLaprHug1ZcEpfbDnX/0Vl1IYRp9a05Tw8JXtn1x7l cxwYhAdu6MFFvxZ+zcug X-Google-Smtp-Source: AGHT+IH6nNN80Dsy7Z5P0n3B6i/JJZPN8BUwGBMMiKaO9oiJRBXtnp1N3ocbCG1yR14OT1rCSHfQnw== X-Received: by 2002:a17:907:3e90:b0:aa6:abb2:be12 with SMTP id a640c23a62f3a-aac3354ff4dmr3975115266b.37.1736122560053; Sun, 05 Jan 2025 16:16:00 -0800 (PST) Original-Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com. [209.85.218.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0efe49ccsm2191539766b.94.2025.01.05.16.15.59 for <73117@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jan 2025 16:15:59 -0800 (PST) Original-Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-aafc9d75f8bso198372866b.2 for <73117@debbugs.gnu.org>; Sun, 05 Jan 2025 16:15:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWrBdH60Gwp1pdxguaEgIVCaH9jzse5srJzvDWph4vOWdHOKqf6KeWeuB63V4Ll8qBWlqqHfA==@debbugs.gnu.org X-Received: by 2002:a17:907:318c:b0:aaf:ab6f:da49 with SMTP id a640c23a62f3a-aafab6fdc82mr888689966b.39.1736122559679; Sun, 05 Jan 2025 16:15:59 -0800 (PST) In-Reply-To: <86bk086so2.fsf@gnu.org> X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298622 Archived-At: On Sat, Sep 28, 2024 at 5:20=E2=80=AFAM Eli Zaretskii wrote: > > > Cc: 73117@debbugs.gnu.org, Daniel Mendler > > From: Juri Linkov > > Date: Fri, 20 Sep 2024 09:58:24 +0300 > > > > > The following example configures `imenu-flatten" to "group" and then > > > shows the menu, first with `completions-format` set to "horizontal" > > > and then "vertical". > > > > > > ```elisp > > > (progn > > > (setopt completions-group t) > > > (setopt imenu-eager-completion-buffer nil) > > > (setopt minibuffer-visible-completions t) > > > (setopt imenu-flatten 'group) > > > > > > (require 'imenu) > > > > > > (dolist (format '(horizontal vertical)) > > > (setopt completions-format format) > > > > Any fixes for completion--insert-horizontal should be pushed > > only to master, not to the release branch. > > > > But for the release branch we should push the documentation fixes > > that will mention all prerequisites for this feature to work > > correctly: > > Feel free to install on the release branch, and thanks. While discussing a similar issue for Vertico here (https://github.com/minad/vertico/discussions/553), Daniel discovered that icomplete-mode also won't display all of the grouped candidates. The following is a reproducer which can be used to demonstrate this issue. In the reproducer, the first time through the loop, icomplete-mode is not enabled and the completion buffer shows all four possible candidates along with their corresponding groups, however the next time through the loop, icomplete-vertical-mode is enabled and only 3 of the 4 candidates are displayed. See his comments in the provided link for his take on the issue as well as his discovery of yet more places that groups don't seem to work correctly (e.g., completion--insert-column). ```elisp (progn (setopt completions-group t) (setopt completions-format 'vertical) (setopt imenu-flatten 'group) (setopt icomplete-show-matches-on-no-input t) (require 'imenu) (dolist (arg '(-1 +1)) (icomplete-mode arg) (icomplete-vertical-mode arg) (setopt imenu-eager-completion-buffer icomplete-vertical-mode) (imenu-choose-buffer-index (format "(icomplete-vertical-mode =3D %s) Index item: " icomplete-vertical-mode) `(("XYZ" . (("123" . ,(point-min-marker)))) ("ABC" . (("124" . ,(point-min-marker)))) ("Bar" . (("Foo" . ,(point-min-marker)))) ("Baz" . (("Foo" . ,(point-max-marker)))))= ))) ```