From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks Date: Tue, 4 Jun 2024 08:37:59 -0400 Message-ID: References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000806e1061a0fb909" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39756"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71353@debbugs.gnu.org To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 04 14:41:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sETTN-000A4R-01 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jun 2024 14:41:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sETT8-0002Nm-W2; Tue, 04 Jun 2024 08:40:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sETT7-0002Nb-AI for bug-gnu-emacs@gnu.org; Tue, 04 Jun 2024 08:40:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sETT7-0002WE-21 for bug-gnu-emacs@gnu.org; Tue, 04 Jun 2024 08:40:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sETTK-0008G1-Dr for bug-gnu-emacs@gnu.org; Tue, 04 Jun 2024 08:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jun 2024 12:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71353 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71353-submit@debbugs.gnu.org id=B71353.171750482231597 (code B ref 71353); Tue, 04 Jun 2024 12:41:02 +0000 Original-Received: (at 71353) by debbugs.gnu.org; 4 Jun 2024 12:40:22 +0000 Original-Received: from localhost ([127.0.0.1]:46461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sETSf-0008DT-Pp for submit@debbugs.gnu.org; Tue, 04 Jun 2024 08:40:22 -0400 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:48558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sETQu-00088P-2o for 71353@debbugs.gnu.org; Tue, 04 Jun 2024 08:38:33 -0400 Original-Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a6266ffdba8so107152666b.1 for <71353@debbugs.gnu.org>; Tue, 04 Jun 2024 05:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717504692; x=1718109492; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VWtN4Wjz2peMQH9lDj41NNSa5v4foNBXigEOFwSRy04=; b=QOgEhkD3A3GW8Hgs2UKMH/dngPvhLU+kZ1BN64XJIcZN5+L2Y0oJzchgDSrjL315HY ln+gjNPCZrDQoSQ4Iw5bB1cMZhytib7+kLyPcWAAA3t3vcxN16YlQB7GMCe8RqhttLqQ wG+onfLttFzgzprrVp4vEXHbiShyH+9hlW7IQOxJKqw0+vNyvREiH4oHJTKpLWFjYjep 7JIZb61AuL6P6patR/B0DStro0HNtadJRWUb5k4WEczxm1meqsd4H912AvIfSLwys065 TWkIWwVhzc/FbuIslyyOAchGCl2ww8VIN3uogVx6THS3hqqxi6OlJra5mGBcvJuUwPs7 qTlg== X-Gm-Message-State: AOJu0Yyfe6G6xpF5GkxmSpNpb0ww3aCIDKoT8pSVupZAllfdLrIGmYef 85SPN+W1BWhmqw0NU4Qnz87YrN0IIpVUGNRSgT86+VDLDLB1oIrivmILFg5vPfw= X-Google-Smtp-Source: AGHT+IGBRv9t33a7PuemiU4ZoTrgF1TOZMq9OtC67lpmcbFJEftoJagrgTgWERL6jEm4Hk8hWeDPyg== X-Received: by 2002:a17:907:971f:b0:a68:362a:bfdb with SMTP id a640c23a62f3a-a68362acb0bmr943348266b.9.1717504691956; Tue, 04 Jun 2024 05:38:11 -0700 (PDT) Original-Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68ff7836f0sm338080866b.33.2024.06.04.05.38.11 for <71353@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 05:38:11 -0700 (PDT) Original-Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-57a31d63b6bso1296435a12.0 for <71353@debbugs.gnu.org>; Tue, 04 Jun 2024 05:38:11 -0700 (PDT) X-Received: by 2002:a17:906:fb06:b0:a68:c2f4:eac with SMTP id a640c23a62f3a-a68c30351f7mr530134966b.59.1717504691394; Tue, 04 Jun 2024 05:38:11 -0700 (PDT) In-Reply-To: <87zfs1j6lo.fsf@betli.tmit.bme.hu> X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286536 Archived-At: --0000000000000806e1061a0fb909 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 4, 2024 at 7:22=E2=80=AFAM Felician Nemeth wrote: > > In any case, why not just turn a MarkedString into a markdown-formatted > text and give it gfm-view-mode? Thanks for the detailed explanation. I've created a new patch which creates a fenced code block and uses gfm-view-mode, as you suggest. --0000000000000806e1061a0fb909 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Eglot-Support-formatting-MarkedString-code-block.patch" Content-Disposition: attachment; filename="0001-Eglot-Support-formatting-MarkedString-code-block.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lx0dtcwf0 RnJvbSBlOWM2Mzg3ZWIxMjNhYWMxZmU0NzQxYTg3MWJlMmI2ODEyOGRlNDFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcm95IEJyb3duIDxicm93bnRzQHRyb3licm93bi5kZXY+CkRh dGU6IFR1ZSwgNCBKdW4gMjAyNCAwODozMDo1MyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEVnbG90 OiBTdXBwb3J0IGZvcm1hdHRpbmcgTWFya2VkU3RyaW5nIGNvZGUtYmxvY2sKCiogbGlzcC9wcm9n bW9kZXMvZWdsb3QuZWwgKGVnbG90LS1mb3JtYXQtbWFya3VwKTogQWRkIHN1cHBvcnQKZm9yIE1h cmtlZFN0cmluZyBjb2RlLWJsb2NrLgoKQ29weXJpZ2h0LXBhcGVyd29yay1leGVtcHQ6IHllcwot LS0KIGxpc3AvcHJvZ21vZGVzL2VnbG90LmVsIHwgMTQgKysrKysrKysrLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9wcm9nbW9kZXMvZWdsb3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAppbmRleCA1Y2Nh ZTUyMTBmZS4uNzAyMjRkMGRjZDYgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVs CisrKyBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCkBAIC0xODYxLDExICsxODYxLDE1IEBAIGVn bG90LS1mb3JtYXQtbWFya3VwCiAgICJGb3JtYXQgTUFSS1VQIGFjY29yZGluZyB0byBMU1AncyBz cGVjLiIKICAgKHBjYXNlLWxldCAoKGAoLHN0cmluZyAsbW9kZSkKICAgICAgICAgICAgICAgIChp ZiAoc3RyaW5ncCBtYXJrdXApIChsaXN0IG1hcmt1cCAnZ2ZtLXZpZXctbW9kZSkKLSAgICAgICAg ICAgICAgICAgKGxpc3QgKHBsaXN0LWdldCBtYXJrdXAgOnZhbHVlKQotICAgICAgICAgICAgICAg ICAgICAgICAocGNhc2UgKHBsaXN0LWdldCBtYXJrdXAgOmtpbmQpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgKCJtYXJrZG93biIgJ2dmbS12aWV3LW1vZGUpCi0gICAgICAgICAgICAgICAgICAg ICAgICAgKCJwbGFpbnRleHQiICd0ZXh0LW1vZGUpCi0gICAgICAgICAgICAgICAgICAgICAgICAg KF8gbWFqb3ItbW9kZSkpKSkpKQorICAgICAgICAgICAgICAgICAoaWYtbGV0ICgobGFuZ3VhZ2Ug KHBsaXN0LWdldCBtYXJrdXAgOmxhbmd1YWdlKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg KHZhbHVlIChwbGlzdC1nZXQgbWFya3VwIDp2YWx1ZSkpKQorICAgICAgICAgICAgICAgICAgICAg KGxpc3QgKGNvbmNhdCAiYGBgIiBsYW5ndWFnZSAiXG4iIHZhbHVlICJcbmBgYCIpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAnZ2ZtLXZpZXctbW9kZSkKKyAgICAgICAgICAgICAgICAgICAo bGlzdCAocGxpc3QtZ2V0IG1hcmt1cCA6dmFsdWUpCisgICAgICAgICAgICAgICAgICAgICAgICAg KHBjYXNlIChwbGlzdC1nZXQgbWFya3VwIDpraW5kKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgKCJtYXJrZG93biIgJ2dmbS12aWV3LW1vZGUpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAoInBsYWludGV4dCIgJ3RleHQtbW9kZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChf IG1ham9yLW1vZGUpKSkpKSkpCiAgICAgKHdpdGgtdGVtcC1idWZmZXIKICAgICAgIChzZXRxLWxv Y2FsIG1hcmtkb3duLWZvbnRpZnktY29kZS1ibG9ja3MtbmF0aXZlbHkgdCkKICAgICAgIChpbnNl cnQgc3RyaW5nKQotLSAKMi4zNy4xCgo= --0000000000000806e1061a0fb909--