From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown Date: Mon, 27 May 2024 10:32:01 -0400 Message-ID: References: <86y17yz5sr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26141"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70958@debbugs.gnu.org, Eli Zaretskii , Felician Nemeth , Stefan Monnier To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 27 16:33:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBbPb-0006f1-UT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 May 2024 16:33:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBbPE-0002u5-81; Mon, 27 May 2024 10:32:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBbPC-0002ta-4b for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 10:32:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBbPB-0000xs-Sg for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 10:32:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBbPK-0000Yx-8K for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 10:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2024 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70958 X-GNU-PR-Package: emacs Original-Received: via spool by 70958-submit@debbugs.gnu.org id=B70958.17168203512121 (code B ref 70958); Mon, 27 May 2024 14:33:02 +0000 Original-Received: (at 70958) by debbugs.gnu.org; 27 May 2024 14:32:31 +0000 Original-Received: from localhost ([127.0.0.1]:45017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBbOp-0000Y9-GO for submit@debbugs.gnu.org; Mon, 27 May 2024 10:32:31 -0400 Original-Received: from mail-lf1-f44.google.com ([209.85.167.44]:52389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBbOn-0000Xt-8n for 70958@debbugs.gnu.org; Mon, 27 May 2024 10:32:29 -0400 Original-Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-52388d9ca98so16958747e87.0 for <70958@debbugs.gnu.org>; Mon, 27 May 2024 07:32:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716820334; x=1717425134; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TuG5b7Q4bVfj73Hud3K1X+zl1HMrGOXAL3crQHIX8vo=; b=H+GPM5DdDutXpJm7tbDJxNrSs9xsq328BkJhSeQG01w6u/58hKjF0+PGrnck6HuAI0 SSBB5iI9TjHFauNqB6bHeofEcNc3WXSVfWU3B2NrqxYNGy/kUMNHPUbIGU6Vqg25X+NF 9XZLlIqoM0c7XMXGogyLX1dAUrrnkloY3om9jnxwzm2DbhFLEqfUJVFH6houSdQ1eQ+O IhWGV04fADAQloKoWUvyIQsI08CviBVPNjkqi9zeqslLmQmchKHjhCuO2XzJoVfOht/M MYx8224zWCstTo1fawMWpr2cGAX5VyfjUEgHeHSAlVkwi8JD22f1MjUN99NxFu02VDgP RX6A== X-Forwarded-Encrypted: i=1; AJvYcCU283GjB6gf94vfWc1+U/0tfcYPFjm+XLDoYDW1KRvq6eelYN4QOvQY5Uw1kWkKErrsjWhCvQvejGvo8jv/MRrIDC0ZYhc= X-Gm-Message-State: AOJu0YzfQQHFVcz0d9NpIhFd9LDNTMdJ9i6OXcZ91TfbBhHO5e0nuOO4 9+8x4jgQrSQDMEKTuQGQ9sxp9vqgyC4odZKdwAAaGSQM/JhLlPYsifee0cHnG+/Nbv8b X-Google-Smtp-Source: AGHT+IHwi/n0QlMTu6CymwlIw0RwkWaKrlrzUU8PC/N9efH63iiaRXjIyiQKDORHcOddDlb4brm5kQ== X-Received: by 2002:ac2:5bce:0:b0:51d:9aa7:23e with SMTP id 2adb3069b0e04-52967a26deemr6761377e87.65.1716820334050; Mon, 27 May 2024 07:32:14 -0700 (PDT) Original-Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5296e885c84sm568672e87.59.2024.05.27.07.32.13 for <70958@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 07:32:13 -0700 (PDT) Original-Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52388d9ca98so16958718e87.0 for <70958@debbugs.gnu.org>; Mon, 27 May 2024 07:32:13 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVRKtNxENaQmdCGk4jzJkD96sfCK7JEO6vP9Oz8yhcXltxV8RGkQ5mOqivZsQg0eMLAU/40E0NLqfadd6ejLxO6wgdkpoU= X-Received: by 2002:a05:6512:1251:b0:523:b068:a6d4 with SMTP id 2adb3069b0e04-5296736b99emr9535828e87.45.1716820333175; Mon, 27 May 2024 07:32:13 -0700 (PDT) In-Reply-To: X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286041 Archived-At: On Mon, May 27, 2024 at 10:09=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > Bugs are only "legitimate" when they are harming someone somewhere. > This hook has been there for a number of years, and noone has complained > that I can remember. If you have a use for the on-shutdown, then it's > a bug. It'd help to know about this use case. If you don't have a use, > it's just a doc bug, and patches welcome. > The use case is that I was experimenting with updating the buffer-local indent-region-function (and indirectly indent-line-function) to be based on eglot-format when the buffer was connected to the language server. I was attempting to use the eglot-managed-mode-hook so I could update these variables when the Eglot buffer management changed. Since the hook wasn't being called on shutdown it would still attempt to call eglot-format when it was no longer managing the buffer. The workaround was to use a mode-specific function for indent-region-function and then having that call eglot-managed-p to determine if it should call eglot-format or something else (e.g., indent-relative).