From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown Date: Mon, 27 May 2024 08:29:40 -0400 Message-ID: References: <86y17yz5sr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10136"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70958@debbugs.gnu.org, Eli Zaretskii , Felician Nemeth , Stefan Monnier To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 27 14:31:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBZVW-0002Xe-JV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 May 2024 14:31:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBZVF-0004ph-Ew; Mon, 27 May 2024 08:31:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBZV7-0004md-Kk for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 08:30:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBZV7-0004CF-BV for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 08:30:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBZVG-0005Lg-0F for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 08:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2024 12:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70958 X-GNU-PR-Package: emacs Original-Received: via spool by 70958-submit@debbugs.gnu.org id=B70958.171681301220498 (code B ref 70958); Mon, 27 May 2024 12:31:01 +0000 Original-Received: (at 70958) by debbugs.gnu.org; 27 May 2024 12:30:12 +0000 Original-Received: from localhost ([127.0.0.1]:43286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBZUR-0005KX-UR for submit@debbugs.gnu.org; Mon, 27 May 2024 08:30:12 -0400 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:46353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBZUN-0005Ig-An for 70958@debbugs.gnu.org; Mon, 27 May 2024 08:30:09 -0400 Original-Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-57857e0f45cso3096414a12.1 for <70958@debbugs.gnu.org>; Mon, 27 May 2024 05:29:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716812992; x=1717417792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Jfj6t7Xkc3SCjvka8VPvWZHytDcXInRRf5Xiwn2Ihk=; b=MV2JasviElY3wkS6Gk9PosFwyEwctLB0WEag9QbfFQSucvn9kGcGyOVIKhf/8H6MxK 7QQtudPD6E3GR7pOVoh1mqkzl9YkJeyBORvV4IvrWfIAlmehw7RhhaDVOg9CI1Ag8EPo +N6zXcqob3lsLjtQV8YoF4RNzBXHyNZWwDb3Jqn5OaM2NHwUonGlypZF19ERige20HOP L0/UbASj7UziPGMoOuebToFYR2UlfwsISPzGsrqahUzEB/tp/ExmqpHU9Xnee5j8PqJl PQ/HX9WDleLYLuhJ1auAEeaMAa1TVsvXzb/5qq1cNS2HyGgz1KbL2cBTtrk+MHVFHJce Nsjg== X-Forwarded-Encrypted: i=1; AJvYcCVklNxbVcBgPYPUyEIh795CvuHVk+Lys62RPIFa1XQ6nUQiiVqXjknLIp0DnF/h9Wy7UONzVrN7NvV7ZxN/IU6LLBRbQZs= X-Gm-Message-State: AOJu0YyQV3TkyyDklMwpMvjnO6YN9sn7jeDafQRLD2sAPBx0IapfzK3l iHkScIlGOG6lV9XVxkWMhqaqe/bv2pxFq1oTzO4Cdoe3OvMCEz9DJTQIjxp3zFQ= X-Google-Smtp-Source: AGHT+IEknEwDK9pYy9itityS5Eon5wM8pASu7Hce1HYOH5PVnqwB6c2FOUpoAJTEPlxoUjXE8pe+vg== X-Received: by 2002:a50:aa9a:0:b0:578:6901:7454 with SMTP id 4fb4d7f45d1cf-578690175b6mr4239892a12.15.1716812992218; Mon, 27 May 2024 05:29:52 -0700 (PDT) Original-Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57852339fc4sm5682419a12.15.2024.05.27.05.29.51 for <70958@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 05:29:51 -0700 (PDT) Original-Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-578517c7ae9so3804030a12.3 for <70958@debbugs.gnu.org>; Mon, 27 May 2024 05:29:51 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWaVaDJ4N/QsSvvG6qOXGIDbxKb9mpQE59ECj4F+cKhUm1mynA1ElnYDkSgu29/zDL6NUJ+kv5HHePpymNGHZ7OwuEPIwM= X-Received: by 2002:a17:906:fad8:b0:a5c:e9e4:99b8 with SMTP id a640c23a62f3a-a6265116471mr621836566b.74.1716812991760; Mon, 27 May 2024 05:29:51 -0700 (PDT) In-Reply-To: X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286026 Archived-At: On Sun, May 26, 2024 at 6:46=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > So when e-m-m-hook was added it was made to run only on "turn on" > because that's where it was most needed. We can try changing Eglot > to also run it on "turn off", but that is a backward incompatible > change. > If it was never intended to run on "turn off", then the comment string for eglot-managed-mode-hook likely should be updated as it indicates it is run when Eglot stops managing the buffer (i.e., "... run by Eglot after it started/stopped managing a buffer").