From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Troy Brown Newsgroups: gmane.emacs.bugs Subject: bug#73280: 30.0.90; Eglot: eglot-workspace-configuration might not be found in .dir-locals.el Date: Mon, 16 Sep 2024 14:53:53 -0400 Message-ID: References: <86ttefde1d.fsf@gnu.org> <86a5g7cvnx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8299"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73280@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 16 20:55:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqGsS-00021j-5N for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Sep 2024 20:55:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqGsB-0007AH-QO; Mon, 16 Sep 2024 14:54:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqGs7-00079n-Hs for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 14:54:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqGs4-0002vz-49 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 14:54:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=wuihC1VF3tEmGOviXp131I+VhGHNbglTrCysjtRCKoA=; b=bpPiqQAYgCTArke+D6E7fzJCbWPOdbnlbYsYeP4e1J2FOz8Cqget4fHfTAlfjruUdEKaeyXxM2mXVL3QTjEjAYsjET6DVTL3b7Gc40hLckN8/RYsW//1SxqmD2YJzGL4IrONIsbHi03RSWhhtMLnvikuWZeBuK5y2pytOpLEfnKuAreq6L/hZQbY7DjPSbz3sr8EOuoJlQdBS6awdS1Vh4r/rDpvb/23Fa5wNb9y91kxjHIJOSPPy3pZKebNpvKQgFMvLjtCwgs95XKvdi0nI7bt88cjOchVlb3rtM2iocDEqjmYswuzb3Ile8DGiy9qdJ0UKTPEhvyYOuA27JjMjQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqGsH-0001On-Ls for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 14:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Sep 2024 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73280 X-GNU-PR-Package: emacs Original-Received: via spool by 73280-submit@debbugs.gnu.org id=B73280.17265128685326 (code B ref 73280); Mon, 16 Sep 2024 18:55:01 +0000 Original-Received: (at 73280) by debbugs.gnu.org; 16 Sep 2024 18:54:28 +0000 Original-Received: from localhost ([127.0.0.1]:53277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqGrk-0001No-7J for submit@debbugs.gnu.org; Mon, 16 Sep 2024 14:54:28 -0400 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:59718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqGrh-0001NW-Sb for 73280@debbugs.gnu.org; Mon, 16 Sep 2024 14:54:26 -0400 Original-Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c3d209db94so5952348a12.3 for <73280@debbugs.gnu.org>; Mon, 16 Sep 2024 11:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726512846; x=1727117646; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wuihC1VF3tEmGOviXp131I+VhGHNbglTrCysjtRCKoA=; b=NE01hfx5Aux2yU9WRgzm8o4cTX+KoHb4OO4iJYbj/xonsvuFpz9HGgOlrFSFRuCtLQ sovSmG7qYsnmK4c24mzLPkddfktalTnNGnHIApHkElxZq5Jluf8qa9LChcZ5yVNfggzu oYWlQs5lLdot7sOKkU85SscpgEf8IBh9ZfGlJfV5+X/2e3R0oaRnEO1lNH+tuiYk5dNb ImLt96M8/266FzdUKvxuNmQtNbPgLGrX9fqU4HIvcsc803/jFM8QhovkIaWVk8Pt7Q8O tN2n8rOVtGVzyUeNroSYDB/9im0WdDXXBndjh9ptMNzCn5p5p5EyLW234233ocl9jlhQ bOYQ== X-Forwarded-Encrypted: i=1; AJvYcCW1aSY87xa5CilCDWZYlJuSr99GvCHH1xII5n0q4rzkflhuvhK3NOIHxQv7dUC7+qP53SaiMA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwyvWcmljqbXg5VkFhQgUgms/sgraLSAu7P3h9Sob/U6ripFb34 d26LsuxkGMZ1/kj/hvP5OvXMLkrP9eofHm2WtCvhA+mfxc4P2u8OWCyIw6mfL8U= X-Google-Smtp-Source: AGHT+IFwR2XOg/l3RzZc0Xd1KnIzLHTn2/HDKxwJH4Hs+NUHt9WH5spxgpx3qF5I5ZArKLTyROwsPA== X-Received: by 2002:a05:6402:26c9:b0:5c2:4ad9:6d9f with SMTP id 4fb4d7f45d1cf-5c413e0942dmr14874336a12.1.1726512844876; Mon, 16 Sep 2024 11:54:04 -0700 (PDT) Original-Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bc88fe2sm2883269a12.87.2024.09.16.11.54.04 for <73280@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2024 11:54:04 -0700 (PDT) Original-Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5c25554ec1eso5899466a12.1 for <73280@debbugs.gnu.org>; Mon, 16 Sep 2024 11:54:04 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX3GE5kebBVDi3my7lsz/clcOQfxe119LPdW8Aj3QWZukpDrALlxftYJfGIteZ/0CUs3Jn0MA==@debbugs.gnu.org X-Received: by 2002:a05:6402:3228:b0:5c2:67d9:3578 with SMTP id 4fb4d7f45d1cf-5c413e54206mr14629401a12.29.1726512844465; Mon, 16 Sep 2024 11:54:04 -0700 (PDT) In-Reply-To: <86a5g7cvnx.fsf@gnu.org> X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291908 Archived-At: On Mon, Sep 16, 2024 at 2:15=E2=80=AFPM Eli Zaretskii wrote: > > > > I would say the major downside is that it is not intuitive at all. > > With the emergence of the *-ts-mode modes, we need to adjust our > intuition. We decided that having foo-mode settings cover foo-ts-mode > as well as much as possible is an advantage, not a disadvantage. So > our intuition needs to follow suit. > That would be fine if this was isolated to only "ts" vs "non-ts" modes. Another example is "typescript-mode". In order to configure the server, you have to use "js-mode" in .dir-locals.el. Why? Because it's the first one in the list. > > It's not consistent with how directory-local variables behave. > > I disagree. Certain settings in .dir-locals are completely global, > which is even more radical than this case. Having to specify a > setting once for several related modes is a Good Thing, IMO. > I proposed in my last response a mechanism where you could specify a configuration for any of the modes associated with a server and have it applied, rather than ignoring a configuration if it wasn't explicitly specified for the first one in the list. The way it currently exists, you'll never be able to change the first mode in the list or you will likely break someone's .dir-locals.el which had to rely on this ordering in order to properly configure their server. > > I don't think I'd agree with the first mode being representative, it > > seems somewhat arbitrary. For instance, in order to change > > eglot-workspace-configuration for "sh-mode", you have to set the > > configuration in .dir-locals.el for "bash-ts-mode"...who would've > > guessed this? > > I'd like to think that in a not-so-distant future, _everyone_ will > guess that. Why not? it makes perfect sense to me. What is that? It's not consistent with the "foo-mode settings cover foo-ts-mode", it's actually the other way around. You have to set the "ts" version in order to have it apply to the "non-ts" version. YAML is another one where the "ts" version is listed first in the list. These are inconsistent. Some lists specify the "non-ts" version before the "ts" version, others swap those. And furthermore, some lists contain multiple "non-ts" modes, so it's arbitrary which one is listed first.