From: Mathias Dahl <mathias.dahl@gmail.com>
To: emacs-devel@gnu.org
Subject: May I do this small change to image-dired now?
Date: Sat, 27 Feb 2016 14:21:58 +0100 [thread overview]
Message-ID: <CABrcCQ6J+_ZYcdNn8epOk9PmbEDzc7tX8-wZcyNz3OoH1mJ7cA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
Hi,
I got some inspiration today to actually "maintain" `image-dired' again :)
I cloned the Git repo and have committed a small local change. Here is what
git show tells me has happened:
==
Author: Mathias Dahl <mathias.dahl@gmail.com>
Date: Sat Feb 27 14:11:02 2016 +0100
Try to preserve the current column when using `image-dired-next-line'
and `image-dired-previous-line'.
diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index a8274f5..67b023d 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -1143,7 +1143,8 @@ image."
(defun image-dired-next-line ()
"Move to next line and display properties."
(interactive)
- (forward-line 1)
+ (let ((goal-column (current-column)))
+ (next-line))
;; If we end up in an empty spot, back up to the next thumbnail.
(if (not (image-dired-image-at-point-p))
(image-dired-backward-image))
@@ -1155,7 +1156,8 @@ image."
(defun image-dired-previous-line ()
"Move to previous line and display properties."
(interactive)
- (forward-line -1)
+ (let ((goal-column (current-column)))
+ (previous-line))
;; If we end up in an empty spot, back up to the next
;; thumbnail. This should only happen if the user deleted a
;; thumbnail and did not refresh, so it is not very common. But we
==
I have two questions:
1. If I git push this change, will it end up on the main Emacs branch (or
trunk, Git and VCSes are not my strongest skill...)? I initially cloned the
repo using my username on Savannah according to the guideline on EmacsWiki.
2. Is it a good time to do this now?
Thanks!
/Mathias
[-- Attachment #2: Type: text/html, Size: 2268 bytes --]
next reply other threads:[~2016-02-27 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 13:21 Mathias Dahl [this message]
2016-02-28 3:42 ` May I do this small change to image-dired now? Lars Ingebrigtsen
2016-02-29 21:58 ` Mathias Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABrcCQ6J+_ZYcdNn8epOk9PmbEDzc7tX8-wZcyNz3OoH1mJ7cA@mail.gmail.com \
--to=mathias.dahl@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.