From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mathias Dahl Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add abbrev suggestions Date: Sun, 19 Jul 2020 19:40:17 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000cb060005aacee2fb" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5522"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 19 19:41:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxDJQ-0001O3-BB for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Jul 2020 19:41:20 +0200 Original-Received: from localhost ([::1]:58836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxDJP-0003Nq-CM for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Jul 2020 13:41:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxDIe-0002sx-1D for emacs-devel@gnu.org; Sun, 19 Jul 2020 13:40:32 -0400 Original-Received: from mail-vk1-xa43.google.com ([2607:f8b0:4864:20::a43]:45476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxDIc-00036c-9w for emacs-devel@gnu.org; Sun, 19 Jul 2020 13:40:31 -0400 Original-Received: by mail-vk1-xa43.google.com with SMTP id h1so3187366vkn.12 for ; Sun, 19 Jul 2020 10:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=9PdQluLvHHy926amAKHMp4Kmr1Q0RxvpVj1LrWZ3Ev8=; b=l1F7Toaalzc+mnTXtT4oo7vZ62ndq7azydztveR7TszGBvWx3RYal0ZyG9Hcvxe5ou L2DML7b+skeIsdBW+zpBo3KEwQvFwQVMCilxB2xp5JchYkUQ2xdgK8Bm7t8auLxPzi6e eIWtY4nWjY5yLO8bX1jrH5k+Y/2D7XWCGcdpD3uh6MowCUGSLwMWPCUHvaTI3wABSyta uhipTZbEPqqGn9HgrSnB03tqOytTI+cJuhNNvRaBd6EfzbwU25+jzUIN9HvythR6DFVU cItcPYTTa9xIrbSuyl42qlSeRm2tEZ98bQBUfbqDCh0LQClkl//Gy2hSap9jmHOM1Mbh IGBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=9PdQluLvHHy926amAKHMp4Kmr1Q0RxvpVj1LrWZ3Ev8=; b=Z1mP/jIGNRq84v7ZK49ztNTNohjaqLK1tHo3p+Fv+1gvuh1PTtGSXanUbQxyUw3Lx1 DAzz/0xTnckeFUehbSqapcrgEeN/XNZEE7+UQcZ/SrTGnS8OSMlU60rhTJinrqJY64l+ Cg5nQOED/QYANVTAzvC8oM0yWn/7XM1WxhJrq6YU3UhBFjTscPUZrxbyf3BCOM50/gTy 8dta3xpZZceSXja6DPu5QSfvZwjrgfafOfDQA0y0KIcgQrUgd2ZCSY1VRBBvhX+vjvQp hYmXuZwRN7AfcgyMZu5z0ni+eVCUEguzCTalFtvRSiSIlgLlhc/FjzzgPCSUOhzsCiZx +apQ== X-Gm-Message-State: AOAM531AXUbLXZQt4gMZIq2g6riELRZXXYSI9VhoMf7WUYiLxdnVA29j yyk3oI9yFqZW2vOFU/qa/jLh/3m2g9D2NIU51dG/eVtEnzU= X-Google-Smtp-Source: ABdhPJzBpVVc4FV/DrDZseBfER2Ko9wcyyvqyPB/cMqoUxkCp1CdsDkwRBmxq5WWxOOB+/p3/q5aXuWzVr1g4WKphtk= X-Received: by 2002:a05:6122:128e:: with SMTP id i14mr12664116vkp.20.1595180428492; Sun, 19 Jul 2020 10:40:28 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::a43; envelope-from=mathias.dahl@gmail.com; helo=mail-vk1-xa43.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253111 Archived-At: --000000000000cb060005aacee2fb Content-Type: text/plain; charset="UTF-8" Hi, Could someone help out with the below? Alternatively, what is needed for me to merge this into Emacs myself (how do I get access, which branch to I work on, etc)? I have basic knowledge of Git branching and merging. Thanks! /Mathias On Mon, Jul 6, 2020 at 1:40 AM Mathias Dahl wrote: > Hi, > > After some time I decided to try to send a patch for this. > > As for what it is, check the source :) > > Or read this short documentation string for the new abbrev-suggest option: > > * Non-nil means we should suggest abbrevs to the user.* > *By enabling this option, if abbrev mode is enabled and if the* > *user has typed some text that exists as an abbrev, suggest to the* > *user to use the abbrev instead."* > > > You can also read this thread to get the background: > > https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00449.html > > The recent discussions can be found here: > > https://lists.gnu.org/archive/html/emacs-devel/2020-05/msg01605.html > > If this patch looks good (a lot of changes has been done as per the > discussions with Eli, Stefan and others in the threads above, and I hope I > also managed to use the correct format for the patch), I'd be glad if > someone could commit this, and I will get started on the changes to the > Emacs documentation as well. I have signed papers before. > > Thanks! > > /Mathias > > --000000000000cb060005aacee2fb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Could someone help out with the= below?

Alternatively, what is needed for me to me= rge this into Emacs myself (how do I get access, which branch to I work on,= etc)? I have basic knowledge of Git branching and merging.

<= /div>
Thanks!

/Mathias

On Mon, Jul 6, 202= 0 at 1:40 AM Mathias Dahl <mat= hias.dahl@gmail.com> wrote:
Hi,

After some time = I decided to try to send a patch for this.

As for = what it is, check the source :)

Or read this short= documentation string for the new=C2=A0abbrev-suggest option:
https://list= s.gnu.org/archive/html/emacs-devel/2017-09/msg00449.html=C2=A0=C2=A0

The recent discussions can be found here:
<= div>

If this patch looks good (a lot of changes has been done as per the = discussions with Eli, Stefan and others in the threads above, and I hope I = also managed to use the correct format for the patch), I'd be glad if s= omeone could commit this, and I will get started on the changes to the Emac= s documentation as well. I have signed papers before.

<= div>Thanks!

/Mathias

--000000000000cb060005aacee2fb--