all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathias Dahl <mathias.dahl@gmail.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>,
	Tino Calancha <tino.calancha@gmail.com>
Subject: Re: [PATCH] New command to invert lines in region
Date: Sun, 16 Oct 2016 13:03:25 +0200	[thread overview]
Message-ID: <CABrcCQ4mn-J5PDSWrfVY-=eVY0XH12e-uA3rp19PMvA8tACmtw@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY2855Uk+ot+EVd4Tm+1uy_uxP94FE=eO_g1+396wfDXkw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

>
> Out of curiosity I had a look at the current implementation of
>> `reverse-region' and found it quite complicated and hard to understand what
>> it does.
>>
>
> I don't have any for or against opinion on this (may be a slight against,
> based on the "if it's not broken, why 'fix'" motto). I have been using
> `reverse-region` for many years and it works just fine.
>

Probably it works just fine, as you say. I agree there is a risk fixing
something that is not broken. I also think it is generally a good thing to
make code more readable and if code can be made more readable and at the
same time be made smaller (which often increase readability), without any
negative side effects, it is a win for maintainability of that code base,
in my opinion.

At any rate, this was just something I happened to notice and I thought it
would be fun to have a go at it.

[-- Attachment #2: Type: text/html, Size: 1594 bytes --]

  reply	other threads:[~2016-10-16 11:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03 10:43 [PATCH] New command to invert lines in region Tino Calancha
2016-10-03 11:02 ` Kaushal Modi
2016-10-03 11:21   ` Tino Calancha
2016-10-03 11:33     ` Tino Calancha
2016-10-15 22:25       ` Mathias Dahl
2016-10-15 23:57         ` Kaushal Modi
2016-10-16 11:03           ` Mathias Dahl [this message]
2016-10-16 13:24         ` Noam Postavsky
2016-10-16 14:00           ` Eli Zaretskii
2016-10-16 18:25         ` Kalle Olavi Niemitalo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABrcCQ4mn-J5PDSWrfVY-=eVY0XH12e-uA3rp19PMvA8tACmtw@mail.gmail.com' \
    --to=mathias.dahl@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=kaushal.modi@gmail.com \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.