Hi,

here is another, cleaner, patch to the OS X 10.6.8 build problem. It adds a non-notification version of windowDidBecomeKey, which windowDidEnterFullScreen now calls. This mean that 1) all functions now use the same pattern (the notification version calls the non-notification version) and 2) there is no need for the locally defined symbol NSWindowDidEnterFullScreenNotification any more.

David (R), if you think this is a good way to solve this, would you like to commit this patch, or would you prefer me to do it?

-- Anders

On Wed, Nov 11, 2015 at 7:56 AM, Anders Lindgren <andlind@gmail.com> wrote:

I don’t think you should unconditionally declare this one:

+- (void)windowDidEnterFullScreen:(NSNotification *)notification;

Only declare it for the 10.6 build, please.

Ah, yes, that seems correct. It is provided from 10.7 onwards.

Alternatively, we can implement a non-notification variant of windowDidBecomeKey (it doesn't use the notification anyway), that way we can move the code from windowDidEnterFullScreen from the notification variant to the non-notification variant, and avoid a lot of the notification complexity.

-- Anders