all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Anders Lindgren <andlind@gmail.com>
To: David Reitter <david.reitter@gmail.com>
Cc: 21862@debbugs.gnu.org, 21862-done@debbugs.gnu.org,
	David Caldwell <david@porkrind.org>
Subject: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6)
Date: Wed, 11 Nov 2015 07:56:16 +0100	[thread overview]
Message-ID: <CABr8ebbVCsouLyUFi-mZN88ADQ3cd8Pi=jU-nA_vTuGtPoxX2g@mail.gmail.com> (raw)
In-Reply-To: <3F4353A6-B088-4DC3-B196-F7AB3EFE5FCE@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

>
> I don’t think you should unconditionally declare this one:
>
> +- (void)windowDidEnterFullScreen:(NSNotification *)notification;
>

> Only declare it for the 10.6 build, please.
>

Ah, yes, that seems correct. It is provided from 10.7 onwards.

Alternatively, we can implement a non-notification variant of
windowDidBecomeKey (it doesn't use the notification anyway), that way we
can move the code from windowDidEnterFullScreen from the notification
variant to the non-notification variant, and avoid a lot of the
notification complexity.

    -- Anders

[-- Attachment #2: Type: text/html, Size: 978 bytes --]

  reply	other threads:[~2015-11-11  6:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-08 13:16 bug#21862: 24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6 David Caldwell
     [not found] ` <handler.21862.B.14469886195908.ack@debbugs.gnu.org>
2015-11-10 19:37   ` bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6) David Caldwell
2015-11-10 19:43     ` David Reitter
2015-11-10 21:02     ` David Reitter
2015-11-10 21:11       ` David Caldwell
2015-11-10 21:39       ` Anders Lindgren
2015-11-10 22:10         ` David Reitter
2015-11-11  6:56           ` Anders Lindgren [this message]
2015-11-14 20:14             ` Anders Lindgren
2015-11-14 20:23               ` David Reitter
2015-11-14 23:23                 ` John Wiegley
2015-11-15  7:18                   ` Anders Lindgren
2015-11-15 17:57                 ` Anders Lindgren
2015-11-10 22:12         ` David Caldwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABr8ebbVCsouLyUFi-mZN88ADQ3cd8Pi=jU-nA_vTuGtPoxX2g@mail.gmail.com' \
    --to=andlind@gmail.com \
    --cc=21862-done@debbugs.gnu.org \
    --cc=21862@debbugs.gnu.org \
    --cc=david.reitter@gmail.com \
    --cc=david@porkrind.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.