From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#21662: visible-bell causes display artifacts on OS X 10.11 Date: Sat, 21 Nov 2015 21:05:07 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114560ce31bd29052512828a X-Trace: ger.gmane.org 1448136385 7102 80.91.229.3 (21 Nov 2015 20:06:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Nov 2015 20:06:25 +0000 (UTC) To: 21662@debbugs.gnu.org, John Wiegley , Steve Purcell , Mustafa Kocaturk Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 21 21:06:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0EQE-00041D-6X for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Nov 2015 21:06:10 +0100 Original-Received: from localhost ([::1]:53511 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0EQD-000153-S3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Nov 2015 15:06:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0EQ9-00014l-F2 for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 15:06:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0EQ6-0003Ze-6K for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 15:06:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0EQ6-0003Za-1w for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 15:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a0EQ5-0007Ne-Nh for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2015 15:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Nov 2015 20:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21662 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21662-submit@debbugs.gnu.org id=B21662.144813631228281 (code B ref 21662); Sat, 21 Nov 2015 20:06:01 +0000 Original-Received: (at 21662) by debbugs.gnu.org; 21 Nov 2015 20:05:12 +0000 Original-Received: from localhost ([127.0.0.1]:47318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0EPG-0007M3-Ng for submit@debbugs.gnu.org; Sat, 21 Nov 2015 15:05:12 -0500 Original-Received: from mail-vk0-f46.google.com ([209.85.213.46]:34810) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0EPD-0007Ls-TC for 21662@debbugs.gnu.org; Sat, 21 Nov 2015 15:05:09 -0500 Original-Received: by vkbs1 with SMTP id s1so16838419vkb.1 for <21662@debbugs.gnu.org>; Sat, 21 Nov 2015 12:05:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=DyqHEZL+Y6iXrPozljjGXK+4R6j6w7gGXeZPpFh8GTw=; b=R6JHf3oL3gGjEdCpnUDswwTyKpFtGtT6NIXsuBhfQUVMSVHEJF+gYOTLxCbA0sfIqa b5tcqv4hHdsRGKkT2dl+H9T1wQmjIjw4/DSG/tRhgRCSTjQs8YzXVE6jLu+qCiv0ZAgx RZIaqCzwzNMJeFYgDffMt1Lsju0gO8ou+bmxrccB5jyyboSYzji4kJDP3+F5e/SZPb8m Js2ERmrXEMYSL2k4OS+QqM5ZG0NezoVTAMA/e/XyB3uEcFhxle/Wuuby8U2Eoue/Ok8T qIYj4BVI1wuRRHupZa2uWWg/zZXBYrx9Pr2K/w0i7em2HX6c4mVKsk77EuXsk170JAi7 jt1g== X-Received: by 10.31.11.204 with SMTP id 195mr8099991vkl.23.1448136307485; Sat, 21 Nov 2015 12:05:07 -0800 (PST) Original-Received: by 10.31.210.133 with HTTP; Sat, 21 Nov 2015 12:05:07 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109031 Archived-At: --001a114560ce31bd29052512828a Content-Type: multipart/alternative; boundary=001a114560ce31bd240525128288 --001a114560ce31bd240525128288 Content-Type: text/plain; charset=UTF-8 Hi again, I decided to reimplement Mustafas ideas in a 10.6.8 compatible manner, and to address the problem with the image being covered by scroll bars I mentioned before. In addition, my implementation is aware that several bell:s may be active at once and won't remove the image until the last one times out, which eliminated flickering. Unless anyone objects, I will publish this in the beginning of next week. Sincerely, Anders Lindgren On Wed, Nov 18, 2015 at 9:27 PM, Anders Lindgren wrote: > Hi, > > Today I tested suggested patch on an 10.11 and on 10.6.8. > > The good news is that, visually, the patch looks really good! It replaced > the boring black square with the standard OS X icon "Caution" icon -- an > exclamation mark on a triangle. It is less intrusive, which I consider a > good thing. > > Unfortunately, the code doesn't compile under 10.6.8. The code use the > "hidden" property of NSView (introduced in 10.10), and it the compiler > complains about the "." in the "[BellView.instance ..." construct. > > I notices a minor problem under 10.11 as well. The icon is shadowed by > scroll bars, if they happen to be displayed in the middle of the frame, > like when having two side-by-side windows. > > I will make an attempt to rewrite to code to work under 10.6.8. > > Sincerely, > Anders Lindgren > > --001a114560ce31bd240525128288 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi again,

I decided to reimplement Must= afas ideas in a 10.6.8 compatible manner, and to address the problem with t= he image being covered by scroll bars I mentioned before. In addition, my i= mplementation is aware that several bell:s may be active at once and won= 9;t remove the image until the last one times out, which eliminated flicker= ing.

Unless anyone objects, I will publish this in= the beginning of next week.

Sincerely,
= =C2=A0 =C2=A0 Anders Lindgren

On Wed, Nov 18, 2015 at 9:27 PM, Anders Lindgren <= andlind@gmail.com> wrote:
<= div dir=3D"ltr">Hi,

Today I tested suggested patch on an= 10.11 and on 10.6.8.

The good news is that, visua= lly, the patch looks really good! It replaced the boring black square with = the standard OS X icon "Caution" icon -- an exclamation mark on a= triangle. It is less intrusive, which I consider a good thing.
<= br>
Unfortunately, the code doesn't compile under 10.6.8. The= code use the "hidden" property of NSView (introduced in 10.10), = and it the compiler complains about the "." in the "[BellVie= w.instance ..." construct.

I notices a minor = problem under 10.11 as well. The icon is shadowed by scroll bars, if they h= appen to be displayed in the middle of the frame, like when having two side= -by-side windows.

I will make an attempt to rewrit= e to code to work under 10.6.8.

Sincerely,
=C2=A0 =C2=A0 Anders Lindgren


--001a114560ce31bd240525128288-- --001a114560ce31bd29052512828a Content-Type: text/plain; charset=US-ASCII; name="bell-3.diff" Content-Disposition: attachment; filename="bell-3.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ih9iy8hx0 ZGlmZiAtLWdpdCBhL3NyYy9uc3Rlcm0ubSBiL3NyYy9uc3Rlcm0ubQppbmRleCA1OGFjZTQ4Li41 ZjIyNDA1IDEwMDY0NAotLS0gYS9zcmMvbnN0ZXJtLm0KKysrIGIvc3JjL25zdGVybS5tCkBAIC01 ODQsMjggKzU4NCw2IEBAIG5zX2xvYWRfcGF0aCAodm9pZCkKICAgcmV0dXJuIE5VTEw7CiB9CiAK LXN0YXRpYyB2b2lkCi1uc190aW1lb3V0IChpbnQgdXNlY3MpCi0vKiAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQotICAgICBCbG9ja2luZyB0aW1lciB1dGlsaXR5IHVzZWQgYnkgbnNfcmluZ19iZWxsCi0gICAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLSAqLwotewotICBzdHJ1Y3QgdGltZXNwZWMgd2FrZXVwID0gdGltZXNw ZWNfYWRkIChjdXJyZW50X3RpbWVzcGVjICgpLAotCQkJCQkgbWFrZV90aW1lc3BlYyAoMCwgdXNl Y3MgKiAxMDAwKSk7Ci0KLSAgLyogS2VlcCB3YWl0aW5nIHVudGlsIHBhc3QgdGhlIHRpbWUgd2Fr ZXVwLiAgKi8KLSAgd2hpbGUgKDEpCi0gICAgewotICAgICAgc3RydWN0IHRpbWVzcGVjIHRpbWVv dXQsIG5vdyA9IGN1cnJlbnRfdGltZXNwZWMgKCk7Ci0gICAgICBpZiAodGltZXNwZWNfY21wICh3 YWtldXAsIG5vdykgPD0gMCkKLQlicmVhazsKLSAgICAgIHRpbWVvdXQgPSB0aW1lc3BlY19zdWIg KHdha2V1cCwgbm93KTsKLQotICAgICAgLyogVHJ5IHRvIHdhaXQgdGhhdCBsb25nLS1idXQgd2Ug bWlnaHQgd2FrZSB1cCBzb29uZXIuICAqLwotICAgICAgcHNlbGVjdCAoMCwgTlVMTCwgTlVMTCwg TlVMTCwgJnRpbWVvdXQsIE5VTEwpOwotICAgIH0KLX0KLQogCiB2b2lkCiBuc19yZWxlYXNlX29i amVjdCAodm9pZCAqb2JqKQpAQCAtMTE2MSw2ICsxMTM5LDc3IEBAIG5zX2NsaXBfdG9fcm93IChz dHJ1Y3Qgd2luZG93ICp3LCBzdHJ1Y3QgZ2x5cGhfcm93ICpyb3csCiB9CiAKIAorLyogPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KKworICAgIFZpc2liZWwgYmVsbCBhbmQgYmVlcC4KKworICAgPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0gKi8KKworCitAaW50ZXJmYWNlIEVtYWNzQmVsbCA6IE5TSW1hZ2VWaWV3Cit7Cisg IC8vIE51bWJlciBvZiBjdXJyZW50bHkgYWN0aXZlIGJlbGw6cy4KKyAgdW5zaWduZWQgaW50IG5l c3RDb3VudDsKK30KKy0gKHZvaWQpc2hvdzooTlNWaWV3ICopdmlldzsKKy0gKHZvaWQpaGlkZTsK K0BlbmQKKworQGltcGxlbWVudGF0aW9uIEVtYWNzQmVsbAorCistIChpZClpbml0OworeworICBp ZiAoKHNlbGYgPSBbc3VwZXIgaW5pdF0pKQorICAgIHsKKyAgICAgIG5lc3RDb3VudCA9IDA7Cisg ICAgICBzZWxmLmltYWdlID0gW05TSW1hZ2UgaW1hZ2VOYW1lZDpOU0ltYWdlTmFtZUNhdXRpb25d OworICAgIH0KKyAgcmV0dXJuIHNlbGY7Cit9CisKKy0gKHZvaWQpc2hvdzooTlNWaWV3ICopdmll dworeworICBOU1RSQUNFICgiW0VtYWNzQmVsbCBzaG93Ol0iKTsKKyAgTlNUUkFDRV9NU0cgKCJu ZXN0Q291bnQ6ICV1IiwgbmVzdENvdW50KTsKKworICAvLyBTaG93IHRoZSBpbWFnZSwgdW5sZXNz IGl0J3MgYWxyZWFkeSBzaG93bi4KKyAgaWYgKG5lc3RDb3VudCA9PSAwKQorICAgIHsKKyAgICAg IE5TUmVjdCByZWN0ID0gW3ZpZXcgYm91bmRzXTsKKyAgICAgIE5TUG9pbnQgcG9zOworICAgICAg cG9zLnggPSByZWN0Lm9yaWdpbi54ICsgKHJlY3Quc2l6ZS53aWR0aCAgLSBzZWxmLmltYWdlLnNp emUud2lkdGggKS8yOworICAgICAgcG9zLnkgPSByZWN0Lm9yaWdpbi55ICsgKHJlY3Quc2l6ZS5o ZWlnaHQgLSBzZWxmLmltYWdlLnNpemUuaGVpZ2h0KS8yOworCisgICAgICBbc2VsZiBzZXRGcmFt ZU9yaWdpbjpwb3NdOworICAgICAgW3NlbGYgc2V0RnJhbWVTaXplOnNlbGYuaW1hZ2Uuc2l6ZV07 CisKKyAgICAgIFtbW3ZpZXcgd2luZG93XSBjb250ZW50Vmlld10gYWRkU3VidmlldzpzZWxmCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBvc2l0aW9uZWQ6TlNXaW5kb3dBYm92 ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWxhdGl2ZVRvOm5pbF07Cisg ICAgfQorCisgICsrbmVzdENvdW50OworCisgIFtzZWxmIHBlcmZvcm1TZWxlY3RvcjpAc2VsZWN0 b3IoaGlkZSkgd2l0aE9iamVjdDpzZWxmIGFmdGVyRGVsYXk6MC41XTsKK30KKworCistICh2b2lk KWhpZGUKK3sKKyAgLy8gTm90ZTogVHJhY2Ugb3V0cHV0IGZyb20gdGhpcyBtZXRob2QgaXNuJ3Qg c2hvd24sIHJlYXNvbiB1bmtub3duLgorICAvLyBOU1RSQUNFICgiW0VtYWNzQmVsbCBoaWRlXSIp OworCisgIC0tbmVzdENvdW50OworCisgIC8vIFJlbW92ZSB0aGUgaW1hZ2Ugb25jZSB0aGUgbGFz dCBiZWxsIGJlY2FtZSBpbmFjdGl2ZS4KKyAgaWYgKG5lc3RDb3VudCA9PSAwKQorICAgIHsKKyAg ICAgIFtzZWxmIHJlbW92ZUZyb21TdXBlcnZpZXddOworICAgIH0KK30KKworQGVuZAorCiBzdGF0 aWMgdm9pZAogbnNfcmluZ19iZWxsIChzdHJ1Y3QgZnJhbWUgKmYpCiAvKiAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQpAQCAtMTE3MCwzNyArMTIxOSwyNCBAQCBuc19yaW5nX2JlbGwgKHN0cnVjdCBmcmFtZSAq ZikKICAgTlNUUkFDRSAoIm5zX3JpbmdfYmVsbCIpOwogICBpZiAodmlzaWJsZV9iZWxsKQogICAg IHsKLSAgICAgIE5TQXV0b3JlbGVhc2VQb29sICpwb29sOwogICAgICAgc3RydWN0IGZyYW1lICpm cmFtZSA9IFNFTEVDVEVEX0ZSQU1FICgpOwogICAgICAgTlNWaWV3ICp2aWV3OwogCisgICAgICBz dGF0aWMgRW1hY3NCZWxsICogYmVsbF92aWV3ID0gbmlsOworICAgICAgaWYgKGJlbGxfdmlldyA9 PSBuaWwpCisgICAgICAgIHsKKyAgICAgICAgICBiZWxsX3ZpZXcgPSBbW0VtYWNzQmVsbCBhbGxv Y10gaW5pdF07CisgICAgICAgICAgW2JlbGxfdmlldyByZXRhaW5dOworICAgICAgICB9CisKICAg ICAgIGJsb2NrX2lucHV0ICgpOwotICAgICAgcG9vbCA9IFtbTlNBdXRvcmVsZWFzZVBvb2wgYWxs b2NdIGluaXRdOwogCiAgICAgICB2aWV3ID0gRlJBTUVfTlNfVklFVyAoZnJhbWUpOwogICAgICAg aWYgKHZpZXcgIT0gbmlsKQogICAgICAgICB7Ci0gICAgICAgICAgTlNSZWN0IHIsIHN1cnI7Ci0g ICAgICAgICAgTlNQb2ludCBkaW0gPSBOU01ha2VQb2ludCAoMTI4LCAxMjgpOwotCi0gICAgICAg ICAgciA9IFt2aWV3IGJvdW5kc107Ci0gICAgICAgICAgci5vcmlnaW4ueCArPSAoci5zaXplLndp ZHRoIC0gZGltLngpIC8gMjsKLSAgICAgICAgICByLm9yaWdpbi55ICs9IChyLnNpemUuaGVpZ2h0 IC0gZGltLnkpIC8gMjsKLSAgICAgICAgICByLnNpemUud2lkdGggPSBkaW0ueDsKLSAgICAgICAg ICByLnNpemUuaGVpZ2h0ID0gZGltLnk7Ci0gICAgICAgICAgc3VyciA9IE5TSW5zZXRSZWN0IChy LCAtMiwgLTIpOwotICAgICAgICAgIG5zX2ZvY3VzIChmcmFtZSwgJnN1cnIsIDEpOwotICAgICAg ICAgIFtbdmlldyB3aW5kb3ddIGNhY2hlSW1hZ2VJblJlY3Q6IFt2aWV3IGNvbnZlcnRSZWN0OiBz dXJyIHRvVmlldzpuaWxdXTsKLSAgICAgICAgICBbbnNfbG9va3VwX2luZGV4ZWRfY29sb3IgKE5T X0ZBQ0VfRk9SRUdST1VORAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo RlJBTUVfREVGQVVMVF9GQUNFIChmcmFtZSkpLCBmcmFtZSkgc2V0XTsKLSAgICAgICAgICBOU1Jl Y3RGaWxsIChyKTsKLSAgICAgICAgICBbW3ZpZXcgd2luZG93XSBmbHVzaFdpbmRvd107Ci0gICAg ICAgICAgbnNfdGltZW91dCAoMTUwMDAwKTsKLSAgICAgICAgICBbW3ZpZXcgd2luZG93XSByZXN0 b3JlQ2FjaGVkSW1hZ2VdOwotICAgICAgICAgIFtbdmlldyB3aW5kb3ddIGZsdXNoV2luZG93XTsK LSAgICAgICAgICBuc191bmZvY3VzIChmcmFtZSk7CisgICAgICAgICAgW2JlbGxfdmlldyBzaG93 OnZpZXddOwogICAgICAgICB9Ci0gICAgICBbcG9vbCByZWxlYXNlXTsKKwogICAgICAgdW5ibG9j a19pbnB1dCAoKTsKICAgICB9CiAgIGVsc2UKQEAgLTEyMDksNiArMTI0NSw3IEBAIG5zX3Jpbmdf YmVsbCAoc3RydWN0IGZyYW1lICpmKQogICAgIH0KIH0KIAorCiAvKiA9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQogCiAgICAgRnJhbWUgLyB3aW5kb3cgbWFuYWdlciByZWxhdGVkIGZ1bmN0aW9ucwo= --001a114560ce31bd29052512828a--