From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Date: Sun, 12 May 2019 20:48:03 +0200 Message-ID: References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000a5c110588b53ebf" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="47576"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35695@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 12 20:49:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPtX6-000CHy-4k for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 20:49:12 +0200 Original-Received: from localhost ([127.0.0.1]:46209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPtX4-0003XU-Qt for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 14:49:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPtWx-0003XP-G9 for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 14:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPtWw-00081E-4w for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 14:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57996) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPtWw-0007zl-1G for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 14:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hPtWv-0000l0-QW for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 14:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 18:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs Original-Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.15576869042865 (code B ref 35695); Sun, 12 May 2019 18:49:01 +0000 Original-Received: (at 35695) by debbugs.gnu.org; 12 May 2019 18:48:24 +0000 Original-Received: from localhost ([127.0.0.1]:43307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPtWJ-0000k8-Mg for submit@debbugs.gnu.org; Sun, 12 May 2019 14:48:24 -0400 Original-Received: from mail-lf1-f43.google.com ([209.85.167.43]:34357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPtWH-0000ju-DH for 35695@debbugs.gnu.org; Sun, 12 May 2019 14:48:22 -0400 Original-Received: by mail-lf1-f43.google.com with SMTP id v18so7429465lfi.1 for <35695@debbugs.gnu.org>; Sun, 12 May 2019 11:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kpMM/vwdkiEzE3odtQ5aU5Xw9aK5pj7sXM6JaowHTMw=; b=hAiamHDE3Q+IhM31moFcdRmW/tN7HRKjQpQV66RdHIw9EdemQY3oz1dfC4HY77+xj7 Y+1tPynU053fZ4ZmrpP8CL3XCUimaDrLgJuP/ZLtB/wlJrvuQcZxRPIVIs92Egngrppc a6TmAyji/gIRCaiaLVdnV/Bd3Iire+lDUK8SBWncSK854ho6Tc/DEoCXc5XRxm2i4wsX eT0/d9gvO8TLaL/Ijecb4WRSlIgBR7Q37+wdidg+kSZLnfyPI0nqcs3x+jglxgcPqKBK x9MTGfFonCmHKjsQylZfaGMZ2Ks3Rom/+0JO+2tupHdVBMKUxKnR7e7XzoYowmXDPNVX oJWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kpMM/vwdkiEzE3odtQ5aU5Xw9aK5pj7sXM6JaowHTMw=; b=aNzA/2Rjtk8CIKU/LF/CateAL9c8bR+tfAXlD5Wzd2ev+y6NN8xXChkWPsuY6tMmvf gjLGRL/TGBNCc5vaH6KV4BZWtthdttfXS1mB7TT+qQTh5hOdyXTGyZpwff1IU3gRNkCE 6j5kYY/AJbAuUZvpE+Jd6XlghvbRk8L4ZrxLTL/fm+LFJJwsn4SosAHfq+GYoUk5sFq5 3p+cHtl6g7yct/I1Ms8V/JatJGl99QkSV8kZccyO/+VScTdIsNIYFjr35wLJdT2O5ww8 AA9kDW8pvNtzHYfMnwWbfoG3cOJKiD4FTs8eHdrQ/nhSWkuLNx+wSe/2aJvdlhrT1cvw hciQ== X-Gm-Message-State: APjAAAVOILfG8l2NRGSuZ/+m/rY0EGt3RM1unmDPGN3+Q4FL5ozJSNyh Wq8+GqgfBF0rSC8J5/rSw4tPvPS3MPtbx+YmB7zbwc0bR6Q= X-Google-Smtp-Source: APXvYqzOjU7CqKhZ0/Ubn7EV1bMGBiQe3A8fep6luCprF5tS1g4b6dsdqVJgxjiqkh+8guI0zySol9rV20zqmxboj1Q= X-Received: by 2002:a19:760e:: with SMTP id c14mr11570047lff.48.1557686894876; Sun, 12 May 2019 11:48:14 -0700 (PDT) In-Reply-To: <83v9ygb4dm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159147 Archived-At: --0000000000000a5c110588b53ebf Content-Type: text/plain; charset="UTF-8" Hi! On Sun, May 12, 2019 at 7:59 AM Eli Zaretskii wrote: > I think we should go back to the old values when min-colors is 256 > or less. > Sounds good to me. I just gave the following a try. It seems to be working, but I'd like to double check the details so that I haven't missed a face. (Dark mode isn't affected, as far as I can see.) diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el index a26e9ee..079806d 100644--- a/lisp/vc/diff-mode.el +++ b/lisp/vc/diff-mode.el@@ -314,8 +314,10 @@ diff-hunk-header (defface diff-removed '((default :inherit diff-changed)- (((class color) (min-colors 88) (background light))+ (((class color) (min-colors 257) (background light)) :background "#ffeeee")+ (((class color) (min-colors 88) (background light))+ :background "#ffdddd") (((class color) (min-colors 88) (background dark)) :background "#553333") (((class color))@@ -325,8 +327,10 @@ diff-removed (defface diff-added '((default :inherit diff-changed)- (((class color) (min-colors 88) (background light))+ (((class color) (min-colors 257) (background light)) :background "#eeffee")+ (((class color) (min-colors 88) (background light))+ :background "#ddffdd") (((class color) (min-colors 88) (background dark)) :background "#335533") (((class color))@@ -2040,8 +2044,10 @@ diff-refine-changed (defface diff-refine-removed '((default :inherit diff-refine-changed)- (((class color) (min-colors 88) (background light))+ (((class color) (min-colors 257) (background light)) :background "#ffcccc")+ (((class color) (min-colors 88) (background light))+ :background "#ffbbbb") (((class color) (min-colors 88) (background dark)) :background "#aa2222")) "Face used for removed characters shown by `diff-refine-hunk'." -- Anders Lindgren --0000000000000a5c110588b53ebf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

On Sun, May 12, 2019 at 7:59 AM Eli Zaretskii <= eliz@gnu.org> wrote:
=C2=A0 I think we should go bac= k to the old values when min-colors is 256
=C2=A0 or less.
=C2=A0
Sounds g= ood to me.

I just gave the following = a try. It seems to be working, but I'd like to double check the details= so that I haven't missed a face. (Dark mode isn't affected, as far= as I can see.)

diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el
= 
index a26e9ee..079806d 100644
--- a/lisp/vc/diff-=
mode.el
+++ b/lisp/vc/diff-mode.el
@@ -314,8 +314,10 =
@@ diff-hunk-heade=
r
 (defface diff-removed
   '((default
      :inherit diff-changed)
-    (((class color) (min-colors 88)=
 (background light))
+    (((class color) (min-colors 257=
) (background light))
      :background "#ffeeee&=
quot;)
+    (((class color) (min-colors 88)=
 (background light))
+     :background "#ffdddd"=
;)
     (((class color) (min-colors=
 88) (background dark))
      :background "#553333")
     (((class color))
@@ -325,8 +327,10 =
@@ diff-removed
 (defface diff-added
   '((default
      :inherit diff-changed)
-    (((class color) (min-colors 88)=
 (background light))
+    (((class color) (min-colors 257=
) (background light))
      :background "#eeffee&=
quot;)
+    (((class color) (min-colors 88)=
 (background light))
+     :background "#ddffdd"=
;)
     (((class color) (min-colors=
 88) (background dark))
      :background "#335533")
     (((class color))
@@ -2040,8 +2044,1=
0 @@ diff-refine-c=
hanged
 (defface diff-refine-removed
   '((default
      :inherit diff-refine-changed)
-    (((class color) (min-colors 88)=
 (background light))
+    (((class color) (min-colors 257=
) (background light))
      :background "#ffcccc&=
quot;)
+    (((class color) (min-colors 88)=
 (background light))
+     :background "#ffbbbb"=
;)
     (((class color) (min-colors=
 88) (background dark))
      :background "#aa2222"))
   "Face used for removed characters shown by `diff-refine-hunk'.&=
quot;

=C2=A0 =C2=A0 -- Anders Lindgren=C2=A0
--0000000000000a5c110588b53ebf--