From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Date: Mon, 13 May 2019 22:45:59 +0200 Message-ID: References: <83woiwb58x.fsf@gnu.org> <83v9ygb4dm.fsf@gnu.org> <877eavwkin.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a3dee00588cb01f2" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="127389"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35695@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 13 22:57:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQI0Z-000X17-3m for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 22:57:15 +0200 Original-Received: from localhost ([127.0.0.1]:34890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQI0Y-0004Vm-3H for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 16:57:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQI0J-00049y-84 for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 16:57:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQHqh-0000bB-Lk for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 16:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32933) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQHqh-0000az-FP for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 16:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQHqh-0000L5-C7 for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 16:47:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 20:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35695 X-GNU-PR-Package: emacs Original-Received: via spool by 35695-submit@debbugs.gnu.org id=B35695.155778038631823 (code B ref 35695); Mon, 13 May 2019 20:47:03 +0000 Original-Received: (at 35695) by debbugs.gnu.org; 13 May 2019 20:46:26 +0000 Original-Received: from localhost ([127.0.0.1]:46470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHq5-0008Gm-SK for submit@debbugs.gnu.org; Mon, 13 May 2019 16:46:26 -0400 Original-Received: from mail-lf1-f43.google.com ([209.85.167.43]:39574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHpw-00083P-Tf for 35695@debbugs.gnu.org; Mon, 13 May 2019 16:46:21 -0400 Original-Received: by mail-lf1-f43.google.com with SMTP id f1so10094858lfl.6 for <35695@debbugs.gnu.org>; Mon, 13 May 2019 13:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uZ9gBc6lU9xBWl7ffuQDkB3YVCFeJ4BeOVakWSwfuPc=; b=Basv72LgnpPj1uGEAaLVYq8B0LzrDc2bqyU91lPk0NAuXkbc4qXixEndlnHIPjAvFi 03rM6yGgzHJMUKKocyVnXvzrpdAQSjXGed7SkD2ey0LEYVbOy9yrbRBvX5nCbrptMjH7 MSs7ZuBL+wB5W/je+7zF0c27lR8vR9/zCUi8HV25FEK+F4P7I5mvh6+AlQyAksJtbA3Z X75D+of0gR97W3Btis33DGP78JJveSPU3eoN68GQFiFwLUAdNB+L/1WF2k+r6u1lYc0R R/tXSyjlRz3u2WMQZagJS5ENoh2U3vivDU18msWvTcy7+oq9p09jbrLfDDB5dH4rIDnc hLWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uZ9gBc6lU9xBWl7ffuQDkB3YVCFeJ4BeOVakWSwfuPc=; b=s0yFGRwUpbg7Lugvh6wSbC1RXiAmTVd2srnRw+/8sPdv4CGF1WOmn++ojNCUt3Jkgh pbN3TiBFap+8D96XSY6TA9BBrSv7iUJKknYieUrkGGi5TLuBN5RAHUITKmk7Dme378k7 ZVWxbAOw4fgXiFRnocIvlH8aPGAg57f+QgpdwyjZqB4VB8Szu3if+exwoaZoYFMcx0IU uaeR9G8ReCnpdcbO0z+J4cj12W3PE0OS1rp/DtEvZNFiqj+6G0MVw6y/TQO7pT2uI2OP oDMUdalCKukzZ4IiYIWfThh/1biEwoHxKfs0qVBaPnMMudWYGQq5V9RI2f7/lrTLo0wB rUrA== X-Gm-Message-State: APjAAAWrXZefxDaiOYoHbS/yZ5Ze8il3jPHdQIrYpI4NQyjf7u0PMkaX bcyJM06y58eF4iW/9PnLUkAd5OjtxIU7VMWMDIs= X-Google-Smtp-Source: APXvYqzsMgpCiYCg98v0RKJ5hARyrLr7vhCIyipy5H0QPBmHsAwYnoZtqBs5R4TUkG0Nm2EhKlv4LtHlrZhFdhDPG5k= X-Received: by 2002:a19:29c4:: with SMTP id p187mr14564102lfp.69.1557780370806; Mon, 13 May 2019 13:46:10 -0700 (PDT) In-Reply-To: <877eavwkin.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159217 Archived-At: --000000000000a3dee00588cb01f2 Content-Type: text/plain; charset="UTF-8" Hi! On Sun, May 12, 2019 at 9:28 PM Juri Linkov wrote: > Thanks, diff-refine-added needs old values for 288 colors as well. > I didn't include it since the output looked good with the new value. However, for consistency, we should probably add one for it as well. Should I include a comment describing why we need to treat 256 color displays differently? -- Anders --000000000000a3dee00588cb01f2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

On Sun, May 12, 2019 at 9:28 PM Juri Linkov <juri@linkov.net> wrote:
Thanks, diff-refine-added n= eeds old values for 288 colors as well.

I didn't include it since the output looked good with the new value. H= owever, for consistency, we should probably add one for it as well.

Should I include a comment describing why we need to trea= t 256 color displays differently?

=C2=A0 =C2=A0 --= Anders

--000000000000a3dee00588cb01f2--