From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Date: Wed, 4 Dec 2013 22:49:34 +0100 Message-ID: References: <87vbz5zcxv.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bb04f688bc34504ecbc6399 X-Trace: ger.gmane.org 1386193816 17429 80.91.229.3 (4 Dec 2013 21:50:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Dec 2013 21:50:16 +0000 (UTC) Cc: 16035@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 04 22:50:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VoKKm-0005uC-S6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Dec 2013 22:50:17 +0100 Original-Received: from localhost ([::1]:50489 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoKKm-0002oo-Fs for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Dec 2013 16:50:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoKKe-0002mD-57 for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 16:50:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoKKZ-0000Hk-Eu for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 16:50:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoKKZ-0000EV-3L for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 16:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VoKKY-0002EB-3w for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2013 16:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Dec 2013 21:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16035 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16035-submit@debbugs.gnu.org id=B16035.13861937808528 (code B ref 16035); Wed, 04 Dec 2013 21:50:01 +0000 Original-Received: (at 16035) by debbugs.gnu.org; 4 Dec 2013 21:49:40 +0000 Original-Received: from localhost ([127.0.0.1]:58514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VoKKB-0002DU-Q0 for submit@debbugs.gnu.org; Wed, 04 Dec 2013 16:49:40 -0500 Original-Received: from mail-wi0-f173.google.com ([209.85.212.173]:53419) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VoKK8-0002DK-3z for 16035@debbugs.gnu.org; Wed, 04 Dec 2013 16:49:36 -0500 Original-Received: by mail-wi0-f173.google.com with SMTP id hn9so4599892wib.0 for <16035@debbugs.gnu.org>; Wed, 04 Dec 2013 13:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=xQUXTcyts/aogfXJicnAJP0N5GWBHbaTq4bhb8id3v4=; b=Mkxfpu7gARQCLATeGdhEZEICcS2N8CWS7lTPToqcbmZkcBdAdmpeM7v+uS3m+VqS+v jrA3QaLpDM6oQcf4e8Qs/GHcLguESIFw4pM9W2hMmZ2eD5ZFyFBSmWzmKLCFhKGvFDIu oV2uINEltZ1ZiENFLD0SiPfePnveko5sqryVMmi683eSlwoW32bMe5elidIf4g4rveOH jkzxhJbTVixW7KiPLqrQMtmCRXt0EK2w3wNmeHMmvzt+uDKNZHR2jUVJVmtcXu/tePUU 7PWObhtdAUDcw7KhjJJV+IlOe1OQc+chVDgkkEUWq5Jcvnds3B9aMSD7mdLO2a2ulEEO y2DA== X-Received: by 10.195.13.164 with SMTP id ez4mr66451471wjd.11.1386193774951; Wed, 04 Dec 2013 13:49:34 -0800 (PST) Original-Received: by 10.216.223.140 with HTTP; Wed, 4 Dec 2013 13:49:34 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81403 Archived-At: --047d7bb04f688bc34504ecbc6399 Content-Type: text/plain; charset=ISO-8859-1 Hi Stefan! For me, personally, I would be glad to sign a general assignment. Unfortunately, my employer does not want to sign a general sign-off agreement -- they prefer to do this case by case. (I respect this -- after all, the company I work for develop IDE:s for the embedded industry so there is a risk of conflict of interests, even though I mainly work on the compiler and not the editor.) In this case, for isearch.el, I do not see the need for an assignment, as I only have reported bugs I have found, not contributed actual code. However, if you think it is necessary, I will sign an assignment -- hopefully we can define a scope that is acceptable to my employer, like "basic Emacs functionality". -- Anders On Wed, Dec 4, 2013 at 6:57 PM, Stefan Monnier wrote: > > I tried you solution and it works perfectly! Just make sure to save the > > keymap after the call to "(run-hooks 'isearch-mode-hook)", as this is > where > > packages like "folding" installs its keymap. > > Great to hear. Juri, can you do that for me? > > > While looking around the isearch code, I came up with a theory why > > multi-buffer search in change-log-mode no longer works. isearch adds its > > hook to the LOCAL pre-command-hook. As change-log-mode search change > buffer > > and the hook is not installed in the new buffer, the user can't exit > > isearch. > > Sounds right, as well. Juri, can you take care of that while you're at it? > > BTW, Anders, I see you have signed more paperwork for Emacs than pretty > much anybody else, yet none of them covers changes to isearch.el. > If I were you, I'd sign a general assignment for all of Emacs and be > done with it once and for all. If that's OK with you, then just tell me > and I'll send you the relevant info, > > > Stefan > --047d7bb04f688bc34504ecbc6399 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Stefan!

For me, personally, I would = be glad to sign a general assignment. Unfortunately, my employer does not w= ant to sign a general sign-off agreement -- they prefer to do this case by = case. (I respect this -- after all, the company I work for develop IDE:s fo= r the embedded industry so there is a risk of conflict of interests, even t= hough I mainly work on the compiler and not the editor.)

In this case, for isearch.el, I do not see the need for= an assignment, as I only have reported bugs I have found, not contributed = actual code. However, if you think it is necessary, I will sign an assignme= nt -- hopefully we can define a scope that is acceptable to my employer, li= ke "basic Emacs functionality".

=A0 =A0 -- Anders



On Wed, Dec 4, 2013 at = 6:57 PM, Stefan Monnier <monnier@iro.umontreal.ca> wr= ote:
> I tried you solution = and it works perfectly! Just make sure to save the
> keymap after the call to "(run-hooks 'isearch-mode-hook)"= ;, as this is where
> packages like "folding" installs its keymap.

Great to hear. =A0Juri, can you do that for me?

> While looking around the isearch code, I came up with a theory why
> multi-buffer search in change-log-mode no longer works. isearch adds i= ts
> hook to the LOCAL pre-command-hook. As change-log-mode search change b= uffer
> and the hook is not installed in the new buffer, the user can't ex= it
> isearch.

Sounds right, as well. =A0Juri, can you take care of that while you&#= 39;re at it?

BTW, Anders, I see you have signed more paperwork for Emacs than pretty
much anybody else, yet none of them covers changes to isearch.el.
If I were you, I'd sign a general assignment for all of Emacs and be done with it once and for all. =A0If that's OK with you, then just tell= me
and I'll send you the relevant info,


=A0 =A0 =A0 =A0 Stefan

--047d7bb04f688bc34504ecbc6399--