From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#21415: 25.0.50; Emacs Trunk -- pixelwise width/height for x-create-frame Date: Thu, 22 Oct 2015 16:54:58 +0200 Message-ID: References: <561E92D8.1050500@gmx.at> <561F7943.9090309@gmx.at> <562746AA.7090004@gmx.at> <5627B83F.9060303@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a114239e8c7fb0f0522b2addb X-Trace: ger.gmane.org 1445525803 28525 80.91.229.3 (22 Oct 2015 14:56:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Oct 2015 14:56:43 +0000 (UTC) Cc: Keith David Bershatsky , 21415@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 22 16:56:34 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpHHu-0003qG-WA for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Oct 2015 16:56:19 +0200 Original-Received: from localhost ([::1]:60484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpHHp-0004uZ-Lo for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Oct 2015 10:56:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpHHl-0004uF-Ba for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 10:56:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpHHe-0002lN-Ny for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 10:56:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpHHe-0002lE-KN for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 10:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZpHHe-0007Mm-H3 for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2015 10:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Oct 2015 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21415 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21415-submit@debbugs.gnu.org id=B21415.144552570328244 (code B ref 21415); Thu, 22 Oct 2015 14:56:02 +0000 Original-Received: (at 21415) by debbugs.gnu.org; 22 Oct 2015 14:55:03 +0000 Original-Received: from localhost ([127.0.0.1]:33002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpHGf-0007LI-Rx for submit@debbugs.gnu.org; Thu, 22 Oct 2015 10:55:02 -0400 Original-Received: from mail-vk0-f53.google.com ([209.85.213.53]:36596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpHGd-0007L0-6X for 21415@debbugs.gnu.org; Thu, 22 Oct 2015 10:54:59 -0400 Original-Received: by vkex70 with SMTP id x70so47662768vke.3 for <21415@debbugs.gnu.org>; Thu, 22 Oct 2015 07:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=QmNbBZvX1MFcRWE+hJXi+CIryiv46Ahx6Yph6z8kbOE=; b=J3qSJ45soBjtk3tvdnfyZDThAAFrrWpCFnBtBAauG0NlbrK5UrXxlc59wqtProxc8p yEwvhI8rpRtyV7dRQxbIssaZAgAgg7rqVt6AzevegGK22ceTf2Xi3EyUSe+JerHTPl9e Zsa8YQrOwxdudoGdQBQQZ63mnFj/Y/sXx8r09XEHHbGCMD9JGp9UVAvGq+EgTuKz2iNY Pl6IfjGUuR3sB3UgK/vHI7sB/Jqwae3oWXWQzqUWXnueOQOfxpqVBdZ4w4nCS6Dqh6cK ox5NrwwP/apBpexSuZuoPvsTWWYyh02Z+A+OjdZR+6iQSRSeKv3vZmRL1wK4huXYmxaz 7V2A== X-Received: by 10.31.128.141 with SMTP id b135mr5853593vkd.70.1445525698634; Thu, 22 Oct 2015 07:54:58 -0700 (PDT) Original-Received: by 10.31.210.133 with HTTP; Thu, 22 Oct 2015 07:54:58 -0700 (PDT) In-Reply-To: <5627B83F.9060303@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107848 Archived-At: --001a114239e8c7fb0f0522b2addb Content-Type: text/plain; charset=UTF-8 Hi, I have never used GNUStep, maybe I should try it out so that my patch work there. Are there build instructions for this somewhere? Anyway, I think the problem you are seeing is due to the fact that I have replaced the code in "zoom" with custom code that simply resizes the frame. On OS X there is nothing special happening when maximizing the frame -- the outer frame (one pixel thick) is still there, no buttons should change state etc. One thing we should try is to check is the old zoom system would work better in GNUStep after all (this is the first of the three different zoom version in the code). Also, it would be interesting to see the NSTRACE output of a session where we go "fullwidth" and then "maximized" and compare it with what happens under OS X -- if it still is a problem after changing the zoom method. When it comes to the double tool bar, I have unfortunately no idea what the problem is. -- Anders Lindgren On Wed, Oct 21, 2015 at 6:07 PM, martin rudalics wrote: > Hi Anders > > Four problems encountered when running your patch with GNUStep Emacs > under xfwm4: > > > (1) With emacs -Q doing > > (set-frame-parameter (selected-frame) 'fullscreen 'maximized) > > maximizes the frame but (a) the "restore size button" of the window > manager decoration is not enabled, (b) leaves the external borders > visible on screen and (c) has the task bar hide the echo area of the > Emacs frame, see screenshot-1.png. > > (a) is probably due to a failed interaction with the window manager. > (b) is not critical because even with GTK, for example, I can still see > the top border on a maximized frame. (c) is not really acceptable. > > > (2) With > > emacs -Q --eval "(setq default-frame-alist '((fullscreen . maximized)))" > > I see the same symptoms as with (1) however the initial frame also > contains two tool bar lines, see screenshot-2.png. This is the same > problem I had earlier with emacs -Q and which now disappeared. > > > (3) With emacs -Q hitting the window manager key for maximizing the > window that has focus, the Emacs frame loses its external borders but > does not extend to the edges of the screen, see screenshot-3.png. Not > grave but slightly annoying. Note that here the "restore size button" > is enabled correctly. > > > (4) After doing > > (set-frame-parameter (selected-frame) 'fullscreen 'fullwidth) > > doing > > (set-frame-parameter (selected-frame) 'fullscreen 'maximized) > > does not change the frame size at all. Same after making a fullheight > frame. I suppose this also makes your ert test fail here. > > > martin > > --001a114239e8c7fb0f0522b2addb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

I have never used GNUStep, maybe I = should try it out so that my patch work there. Are there build instructions= for this somewhere?

Anyway, I think the problem y= ou are seeing is due to the fact that I have replaced the code in "zoo= m" with custom code that simply resizes the frame. On OS X there is no= thing special happening when maximizing the frame -- the outer frame (one p= ixel thick) is still there, no buttons should change state etc.
<= br>
One thing we should try is to check is the old zoom system wo= uld work better in GNUStep after all (this is the first of the three differ= ent zoom version in the code).

Also, it would be i= nteresting to see the NSTRACE output of a session where we go "fullwid= th" and then "maximized" and compare it with what happens un= der OS X -- if it still is a problem after changing the zoom method.
<= div>
When it comes to the double tool bar, I have unfortunate= ly no idea what the problem is.

=C2=A0 =C2=A0 -- A= nders Lindgren

On Wed, Oct 21, 2015 at 6:07 PM, martin rudalics <rudalics@gmx.at> wrote:
Hi Anders

Four problems encountered when running your patch with GNUStep Emacs
under xfwm4:


(1) With emacs -Q doing

(set-frame-parameter (selected-frame) 'fullscreen 'maximized)

maximizes the frame but (a) the "restore size button" of the wind= ow
manager decoration is not enabled, (b) leaves the external borders
visible on screen and (c) has the task bar hide the echo area of the
Emacs frame, see screenshot-1.png.

(a) is probably due to a failed interaction with the window manager.
(b) is not critical because even with GTK, for example, I can still see
the top border on a maximized frame.=C2=A0 (c) is not really acceptable.

(2) With

emacs -Q --eval "(setq default-frame-alist '((fullscreen . maximiz= ed)))"

I see the same symptoms as with (1) however the initial frame also
contains two tool bar lines, see screenshot-2.png.=C2=A0 This is the same problem I had earlier with emacs -Q and which now disappeared.


(3) With emacs -Q hitting the window manager key for maximizing the
window that has focus, the Emacs frame loses its external borders but
does not extend to the edges of the screen, see screenshot-3.png.=C2=A0 Not=
grave but slightly annoying.=C2=A0 Note that here the "restore size bu= tton"
is enabled correctly.


(4) After doing

(set-frame-parameter (selected-frame) 'fullscreen 'fullwidth)

doing

(set-frame-parameter (selected-frame) 'fullscreen 'maximized)

does not change the frame size at all.=C2=A0 Same after making a fullheight=
frame.=C2=A0 I suppose this also makes your ert test fail here.


martin


--001a114239e8c7fb0f0522b2addb--