From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Date: Tue, 3 Dec 2013 10:38:50 +0100 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bae4922607b1804ec9e10eb X-Trace: ger.gmane.org 1386063613 26083 80.91.229.3 (3 Dec 2013 09:40:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Dec 2013 09:40:13 +0000 (UTC) To: 16035@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 03 10:40:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VnmSj-0007zt-Lt for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Dec 2013 10:40:13 +0100 Original-Received: from localhost ([::1]:41281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnmSj-0004Rh-6k for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Dec 2013 04:40:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnmSc-0004Od-NX for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2013 04:40:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnmSa-0007AA-Ey for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2013 04:40:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnmSa-000790-CD for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2013 04:40:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VnmSZ-0006Ea-2R for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2013 04:40:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Dec 2013 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16035 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138606354923892 (code B ref -1); Tue, 03 Dec 2013 09:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Dec 2013 09:39:09 +0000 Original-Received: from localhost ([127.0.0.1]:55519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnmRg-0006DH-BY for submit@debbugs.gnu.org; Tue, 03 Dec 2013 04:39:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55630) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnmRc-0006Cl-7I for submit@debbugs.gnu.org; Tue, 03 Dec 2013 04:39:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnmRU-0006mf-VQ for submit@debbugs.gnu.org; Tue, 03 Dec 2013 04:38:59 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:36533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnmRU-0006mb-Rx for submit@debbugs.gnu.org; Tue, 03 Dec 2013 04:38:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnmRS-0003YP-SA for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2013 04:38:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnmRQ-0006lr-Mz for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2013 04:38:54 -0500 Original-Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:62836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnmRQ-0006la-CI for bug-gnu-emacs@gnu.org; Tue, 03 Dec 2013 04:38:52 -0500 Original-Received: by mail-wg0-f48.google.com with SMTP id z12so13217835wgg.15 for ; Tue, 03 Dec 2013 01:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=Wc4RX4h0Rr2sUImCxS/mLnoiTLi8QM5M8xQvF3aJi6U=; b=KOT0lpmeoMkuBL5z426uRFrtKQn8O+nJAq6hWO+GTsxSn31x10C8tbH0f1YYIzMWfo 0hYTbC4ccr3h67GoDlYAFhQDe6yyj8QkX0btphf1lhjy2amBdbXSLrM5fzzySNO0SE5P xO0MyAyS9enxVhNQ9wPxX4H0pUkaJWJISGkwt8Ih/LBlEly0WaApwRLkxYylQFkqgWqF p3gQzOrmiPAHIPGrPu+gUKKIflLJSEVvBpY2rljqRHRKeivN7ok99FYaGgfXNF+lMlhT vf+pb733zTcDd0TDy4YMaxsV7lZpwfBS8dsA0FwWMoDp+EynPJ2ROfoVAN6dQGyi/8mP UA9A== X-Received: by 10.194.193.39 with SMTP id hl7mr454383wjc.91.1386063530587; Tue, 03 Dec 2013 01:38:50 -0800 (PST) Original-Received: by 10.216.124.76 with HTTP; Tue, 3 Dec 2013 01:38:50 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81296 Archived-At: --047d7bae4922607b1804ec9e10eb Content-Type: text/plain; charset=ISO-8859-1 Recent changes in the isearch package has made packages that customize isearch fail. Case 1: change-log-mode customizes isearch so that you could search multiple files. Emacs -Q lisp/ChangeLog C-s refresh-d C-s C-a Here, the symbol "font-lock-refresh-defaults" in ChangeLog.16 has been found. C-a typically exits isearch, however, now it doesn't. You can see this on the fact that the isearch highlight is still active and when more characters are typed, they are added to the search string. This broke on revision 114586. Log for revision 114586: fixes bug: http://debbugs.gnu.org/15200 committer: Juri Linkov branch nick: trunk timestamp: Wed 2013-10-09 02:20:12 +0300 message: * lisp/isearch.el (isearch-help-map, isearch-mode-map): Don't bind [t] to isearch-other-control-char. (isearch-mode): Add isearch-pre-command-hook to pre-command-hook and isearch-post-command-hook to post-command-hook. (isearch-done): Remove isearch-pre-command-hook from pre-command-hook and isearch-post-command-hook from post-command-hook. (isearch-unread-key-sequence) (isearch-reread-key-sequence-naturally) (isearch-lookup-scroll-key, isearch-other-control-char) (isearch-other-meta-char): Remove functions. (isearch-pre-command-hook, isearch-post-command-hook): New functions based on isearch-other-meta-char rewritten relying on the new behavior of overriding-terminal-local-map that does not replace the local keymaps any more. Case 2: isearch in the popular third-part package "folding" is broken, same symptoms as above. (If you don't have it I can supply a copy.) ./nextstep/Emacs.app/Contents/MacOS/Emacs -Q folding.el -l folding.el y M-x folding-mode RET C-s defvar C-a This broke in revision 114633. Log for 114633: committer: Stefan Monnier branch nick: trunk timestamp: Fri 2013-10-11 21:10:25 -0400 message: * lisp/isearch.el (isearch-pre-command-hook): Don't build in knowledge about internals of universal-argument. -- Anders Lindgren In GNU Emacs 24.3.50.1 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00) of 2013-12-03 on macpro.lan Bzr revision: 115300 rgm@gnu.org-20131130084228-ifjblwsxjxkeeta7 Windowing system distributor `Apple', version 10.3.1265 Configured using: `configure --with-ns' Important settings: value of $LC_CTYPE: UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Change Log Minor modes in effect: bug-reference-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-s r e f r e s h - d C-s C-a d C-g C-g C-g C-h v e m a c z - b s - b z C-x 1 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Quit [2 times] Type C-x 1 to delete the help window. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu help-fns misearch multi-isearch vc-bzr bug-reference add-log time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) --047d7bae4922607b1804ec9e10eb Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Recent changes in the isearch package has m= ade packages that customize isearch fail.

Case 1:<= /div>

change-log-mode customizes isearch so that you cou= ld search multiple files.

=A0 =A0 Emacs -Q lisp/ChangeLog
=A0 =A0 C-s r= efresh-d
=A0 =A0 C-s
=A0 =A0 C-a

Here, the symbol "font-lock-refresh-defaults" in ChangeLog.16 = has been found. C-a typically exits isearch, however, now it doesn't. Y= ou can see this on the fact that the isearch highlight is still active and = when more characters are typed, they are added to the search string.

This broke on revision=A0114586.

Log for revision 114586:

fixes bug: http://de= bbugs.gnu.org/15200

committer: Juri Linkov <= juri@jurta.org>

branch nick: trunk

timestamp: Wed 2013-10-09 02:20:12 +0300

message:

=A0 * lisp/isearch.el (isearch-help-map, isearch-mode-map): D= on't bind [t]

=A0 to isearch-other-control-char.

=A0 (isearch-mode): Add isearch-pre-command-hook to pre-comma= nd-hook

=A0 and isearch-post-command-hook to post-command-hook.

=A0 (isearch-done): Remove isearch-pre-command-hook from pre-= command-hook

=A0 and isearch-post-command-hook from post-command-hook.

=A0 (isearch-unread-key-sequence)

=A0 (isearch-reread-key-sequence-naturally)

=A0 (isearch-lookup-scroll-key, isearch-other-control-char)

=A0 (isearch-other-meta-char): Remove functions.

=A0 (isearch-pre-command-hook, isearch-post-command-hook):

=A0 New functions based on isearch-other-meta-char rewritten<= /p>

=A0 relying on the new behavior of overriding-terminal-local-= map

=A0 that does not replace the local keymaps any more.


Case 2:

isearch in the popul= ar third-part package "folding" is broken, same symptoms as above= . (If you don't have it I can supply a copy.)

=A0 =A0 ./nextstep/Emacs.app/Contents/MacOS/Emacs -Q fo= lding.el -l folding.el
=A0 =A0 y
=A0 =A0 M-x folding-mo= de RET
=A0 =A0 C-s defvar
=A0 =A0 C-a

This broke in revision 114633.

Log for 114633:

committer: Stefan Monnier <monnier@iro.umontreal.ca>

branch nick: trunk

timestamp: Fri 2013-10-11 21:10:25 -0400

message:

=A0 * lisp/isearch.el (isearch-pre-command-hook): Don't b= uild in knowledge about

=A0 internals of universal-argument.


=
=A0 =A0 -- Anders Lindgren





In GNU Emacs 24.3.50.1 (x86= _64-apple-darwin13.0.0, NS apple-appkit-1265.00)
=A0of 2013-12-03 on macpro.lan
Bzr revision: 115300 rgm@gnu.= org-20131130084228-ifjblwsxjxkeeta7
Windowing system distributor = `Apple', version 10.3.1265
Configured using:
=A0`co= nfigure --with-ns'

Important settings:
=A0 value of $LC_CTYPE: U= TF-8
=A0 locale-coding-system: utf-8-unix
=A0 default e= nable-multibyte-characters: t

Major mode: Change L= og

Minor modes in effect:
=A0 bug-reference-mode= : t
=A0 tooltip-mode: t
=A0 electric-indent-mode: t
=A0 mouse-wheel-mode: t
=A0 tool-bar-mode: t
=A0= menu-bar-mode: t
=A0 file-name-shadow-mode: t
=A0 global-font-lock-mode: t
=A0 font-lock-mode: t
=A0 blink-cursor-mode: t
= =A0 auto-composition-mode: t
=A0 auto-encryption-mode: t
=A0 auto-compression-mode: t
=A0 line-number-mode: t
=A0 transient-mark-mode: t

Recent input:
C-s r e f r e s h - d C-s C-a <u= p> d C-g C-g C-g C-h=A0
v e m a c z - b <backspace> <= backspace> <backspace>=A0
s - b z <tab> <return> C-x 1 <menu-bar> <help-men= u>=A0
<send-emacs-bug-report>

R= ecent messages:
For information about GNU Emacs and the GNU syste= m, type C-h C-a.
Quit [2 times]
Type C-x 1 to delete the help window.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug mess= age format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils help-mode easymenu help-fns misearch multi-is= earch
vc-bzr bug-reference add-log time-date tooltip electric uniquify
=
ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset=
image regexp-opt fringe tabulated-list newcomment lisp-mode prog= -mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
=
jit-lock font-lock syntax facemenu font-core frame cham georgian
=
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abb= rev
minibuffer nadvice loaddefs button faces cus-face macroexp fi= les
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-proces= s
cocoa ns multi-tty emacs)

--047d7bae4922607b1804ec9e10eb--