From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal Date: Sun, 12 May 2019 07:03:41 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005259920588a9b8df" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="37497"; mail-complaints-to="usenet@blaine.gmane.org" To: 35695@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 12 07:11:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPglW-0009f1-6B for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 07:11:14 +0200 Original-Received: from localhost ([127.0.0.1]:38834 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPglV-0000PQ-5I for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 01:11:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPglM-0000Ov-IV for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:11:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPglL-0007aE-3N for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:11:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPglK-0007Zz-Ut for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hPglK-0002lK-KY for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 05:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35695 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155763783110461 (code B ref -1); Sun, 12 May 2019 05:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 May 2019 05:10:31 +0000 Original-Received: from localhost ([127.0.0.1]:41602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPgko-0002if-PZ for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPgkm-0002iP-Mt for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:29 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:37414) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hPgkh-000789-FH for submit@debbugs.gnu.org; Sun, 12 May 2019 01:10:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPgkf-0008B2-P5 for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:10:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPge2-0000bQ-9K for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:03:31 -0400 Original-Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:45429) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPge1-0000UR-RP for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 01:03:30 -0400 Original-Received: by mail-lf1-x144.google.com with SMTP id n22so6713678lfe.12 for ; Sat, 11 May 2019 22:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=c1qF43AsterVkbT3r1lkKIxoBq/d59NTRNfYgzHpf08=; b=uXdmKh9X5pFvORZrMOvNtj5Rg7QbeosilL29XzgMacgywH9I3VSK2hUftL+txiKO/c Pnd2gTPqAzO0ZW8MOJJvKhmtaL2mzQx4Hjc16i9ldAm4cihCEKLLpe5Hnw6WNOhZx+FA cDyinaAt8UPOeAfhZmk2pZX3HkGhnE+qztw7ImczI5QyCAfB0fNW44gP4GfyifBtihe2 Ahu+e4dg2j7XF0vyBpZDShTArKOwd7MUB4Yt3y53L703uZGev1oHQ18iBsVQ+BEGpIRF EaqWYpwty8brXhuMkkzpMCjz3XASujFnya85Ih+F36xnxDWmUJxwxQb+otFaluxxILWv yvxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=c1qF43AsterVkbT3r1lkKIxoBq/d59NTRNfYgzHpf08=; b=Ukuqi9Q3n3TP5w8z9EbUY4HPqISShQqwpgF2PfPqnBN8yNf8Cvm21ju3OiZyZ3NQ/+ yBupU6uXk/d9jYZqhPW6cejhMsPD48z2W60vFKe//IhNgiaj2JxdJLaYJqZUcq1IIJsQ tPYJMovtmSAmxf5rUbsRAmqizuLpb289iNM0ruZXPdoMz7PUeF73a8y1EPGeLxjpVX// JpeGA/8Z07RGmCssonnV1GZ4b3quCPQTkgnNkTxxz8OuqOYMtnm/ptL+OZzZjIyJR2Qa gkzs/uOs/LHYxn/ryb7ZAQYxnGqQVjBh1V3T5k+FoYXJ1JQgcFatwwHSkkRZb6r9JOSz je7w== X-Gm-Message-State: APjAAAXd+1Cpl1NeEfVlvXJBAJaSBIUyzOEqVyrrhNIc+d82Ia8Lvces WeIM5k4c96BQP76BJThMYgvhv9A3glCSwaW3A9DSAjPufrQ= X-Google-Smtp-Source: APXvYqxA3GIZOKKcdKTfS4OWpKkMV7+8PwXY21YFcUFW7MhEw8GtN1c33iX80KWNDL5PTOw6CjGe7aqFOkzZAv/V5GQ= X-Received: by 2002:a19:c394:: with SMTP id t142mr5520656lff.102.1557637406807; Sat, 11 May 2019 22:03:26 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159115 Archived-At: --0000000000005259920588a9b8df Content-Type: text/plain; charset="UTF-8" Hi! When using Emacs in a terminal that supports 256 colors (such as the built-in terminal on macOS), the faces diff-added and diff-removed look the same. They are defined to have a background color of #eeffee and #ffeeee, respectively, in light background mode. When a diff is viewed in a terminal, they are both rendered using light grey background, so it's impossible to distinguish between them. In Emac 26, they were defined using #ddffdd and #ffdddd, respectively, which is rendered fine in the terminal (on both Emacs 26 and 27). One way to solve this is to add alternative color definitions using the "min-colors" requirement. Another is to go back to the old values. -- Anders Lindgren In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29)) of 2019-05-01 built on mbp.lan Repository revision: 7dafbe3ab91e838803a84ab388bca03ff985e312 Repository branch: master System Description: Mac OS X 10.12.6 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. delete-backward-char: Text is read-only Quit Mark saved where search started Making completion list... Configured using: 'configure --with-gnutls=no' Configured features: NOTIFY KQUEUE ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREADS PDUMPER GMP Important settings: value of $LC_CTYPE: UTF-8 value of $LANG: en_SE.UTF-8 locale-coding-system: utf-8-unix Major mode: Apropos Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch multi-isearch help-mode cl-loaddefs cl-lib apropos smerge-mode vc-dispatcher vc-svn diff-mode easymenu easy-mmode term/xterm xterm elec-pair tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 56669 7188) (symbols 48 6625 1) (strings 32 17368 1666) (string-bytes 1 565596) (vectors 16 7835) (vector-slots 8 78808 10720) (floats 8 25 439) (intervals 56 860 4) (buffers 992 14)) --0000000000005259920588a9b8df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

<= /div>
When using Emacs in a terminal that supports 256 colors (such as = the built-in terminal on macOS), the faces diff-added and diff-removed look= the same.

They are defined to have a background c= olor of #eeffee and #ffeeee, respectively, in light background mode. When a= diff is viewed in a terminal, they are both rendered using light grey back= ground, so it's impossible to distinguish between them.

<= /div>
In Emac 26, they were defined using #ddffdd and #ffdddd, respecti= vely, which is rendered fine in the terminal (on both Emacs 26 and 27).

One way to solve this is to add alternative color def= initions using the "min-colors" requirement. Another is to go bac= k to the old values.

=C2=A0 =C2=A0 =C2=A0-- Anders= Lindgren

In GNU Emacs 27.0.50 (build 1, x86_64-ap= ple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29))
=C2=A0of 2019-05-01 built on mbp.lan
Repository revision: 7dafb= e3ab91e838803a84ab388bca03ff985e312
Repository branch: master
System Description:=C2=A0 Mac OS X 10.12.6

= Recent messages:
For information about GNU Emacs and the GNU syst= em, type C-h C-a.
delete-backward-char: Text is read-only
Quit
Mark saved where search started
Making completi= on list...

Configured using:
=C2=A0'= configure --with-gnutls=3Dno'

Configured featu= res:
NOTIFY KQUEUE ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS THREAD= S PDUMPER
GMP

Important settings:
<= div>=C2=A0 value of $LC_CTYPE: UTF-8
=C2=A0 value of $LANG: en_SE= .UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major mode: Apropos

Minor modes in effect:<= /div>
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t=
=C2=A0 font-lock-mode: t
=C2=A0 auto-composition-mode:= t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compressi= on-mode: t
=C2=A0 buffer-read-only: t
=C2=A0 line-numbe= r-mode: t
=C2=A0 transient-mark-mode: t

= Load-path shadows:
None found.

Features:=
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv=
bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc= 822 mml
mml-sec password-cache epa derived epg epg-config gnus-ut= il rmail
rmail-loaddefs text-property-search time-date mm-decode = mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailh= eader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail= -utils misearch
multi-isearch help-mode cl-loaddefs cl-lib apropo= s smerge-mode
vc-dispatcher vc-svn diff-mode easymenu easy-mmode = term/xterm xterm
elec-pair tooltip eldoc electric uniquify ediff-= hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-norma= lize mule-util
term/common-win tool-bar dnd fontset image regexp-= opt fringe
tabulated-list replace newcomment text-mode elisp-mode= lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch t= imer select
scroll-bar mouse jit-lock font-lock syntax facemenu f= ont-core
term/tty-colors frame cl-generic cham georgian utf-8-lan= g misc-lang
vietnamese tibetan thai tai-viet lao korean japanese = eucjp-ms cp51932
hebrew greek romanian slovak czech european ethi= opic indian cyrillic
chinese composite charscript charprop case-t= able epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer= cl-preloaded nadvice loaddefs
button faces cus-face macroexp fil= es text-properties overlay sha1 md5
base64 format env code-pages = mule custom widget hashtable-print-readable
backquote threads kqu= eue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 56669 7188)
=C2=A0(sym= bols 48 6625 1)
=C2=A0(strings 32 17368 1666)
=C2=A0(st= ring-bytes 1 565596)
=C2=A0(vectors 16 7835)
=C2=A0(vec= tor-slots 8 78808 10720)
=C2=A0(floats 8 25 439)
=C2=A0= (intervals 56 860 4)
=C2=A0(buffers 992 14))

=
--0000000000005259920588a9b8df--